Andrew n marshall
0156f2e103
Addressing comments from #703
2016-10-28 16:04:57 -07:00
Rachel Fenichel
0c015fd439
Merge pull request #710 from rachel-fenichel/feature/save_load_optimization
...
Disable resizing the workspace during clearing and loading from xml, …
2016-10-28 15:01:05 -07:00
Neil Fraser
144be4d49f
Block highlighting
...
* Separate block selection (editing) from highlighting (execution).
* Remove add/removeDragging functions. They clutter the API for no reason.
2016-10-26 18:39:56 -07:00
Rachel Fenichel
e2e2a3e298
Disable resizing the workspace during clearing and loading from xml, as an optimization
2016-10-21 14:30:30 -07:00
Andrew n marshall
81499e4392
Merge pull request #703 from AnmAtAnm/alert-confirm-prompt
...
Adding hooks to support custom alert, confirm, and prompt dialogs
2016-10-20 17:20:00 -07:00
Andrew n marshall
8f3b4bcb5e
Replaces calls to window.alert(), window.confirm(), and window.prompt() with Blockly.alert(), Blockly.confirm(), and Blockly.prompt(). These are designed to allow app developers to replace the dialogs with versions that match their own open app, possibly avoiding modal browser dialogs. They each take a callback, so the developer has the opportunity to implement non-modal behavior.
2016-10-20 16:30:40 -07:00
Rachel Fenichel
0537f4829e
Merge pull request #685 from trodi/toolbox-typing
...
Add a few missing type definitions
2016-10-18 17:31:54 -07:00
Neil Fraser
7550cb1e96
Fix loading of Block Factory in Firefox.
2016-10-14 02:20:25 -07:00
Neil Fraser
5df55ddea0
Block(ly) Factory prompts should have defaults. Drop unused copy of colourpicker code.
2016-10-11 12:16:17 -07:00
picklesrus
dad6e47f86
Fix null pointer bug from commit 7928fac3ce. In this context the options object is in "this", not workspace. ( #692 )
2016-10-11 11:03:03 -07:00
Shannon McCabe
f7bbaaa82d
JSDoc format fixes
2016-10-07 14:30:14 -07:00
Neil Fraser
415c6ed65e
Add $ back into the ID soup. Issue #251 .
2016-10-06 18:52:25 -07:00
Rachel Fenichel
157441f4b1
Add @this annotation to get/set metrics. ( #639 )
2016-10-06 18:06:41 -07:00
Neil Fraser
7928fac3ce
Collapse the five 0/1-based index flags into one option.
2016-10-06 17:54:43 -07:00
Troy McKinnon
ad3541992e
add a few type definitions
2016-09-30 16:26:44 -05:00
Rachel Fenichel
ed983333eb
bindEventWithChecks_ for internal use, and bindEvent_ with old behaviour but deprecated
2016-09-23 13:46:11 -07:00
Rachel Fenichel
ba1238812f
Revert "Revert "Ignore everything but the first touch stream""
2016-09-23 13:36:53 -07:00
Rachel Fenichel
b2faa41eb1
Revert "Ignore everything but the first touch stream"
2016-09-22 15:26:52 -07:00
Rachel Fenichel
b771d8daf4
Cleanup
2016-09-07 18:14:05 -07:00
Rachel Fenichel
109e4bb352
Move code to touch.js
2016-09-07 17:42:09 -07:00
Rachel Fenichel
c373d6d091
Make context menus work again; fix dragging from the toolbox with variables.
2016-09-07 15:49:20 -07:00
Rachel Fenichel
706d74c81e
Handle touches on/in comments and right-clicks on the workspace
2016-09-01 14:15:03 -07:00
Rachel Fenichel
b77c080678
Fix bugs with missing mouseUp events on mutators. Also stop filtering out key presses.
2016-08-25 15:18:53 -07:00
Rachel Fenichel
cc9396d739
Prefer functions in workspaceSvg to functions in blockly.js
2016-08-19 14:13:20 -07:00
rachel-fenichel
21fea1279c
Merge pull request #557 from google/feature/variable_management
...
Integrate variable management into develop.
2016-08-18 15:56:18 -07:00
Katelyn Mann
33e9d75457
Fix for #521 .
...
Add a isMutator member similar to isFlyout to workspace_svg so it knows whether
it is mutator or not. Allow blocks to access that property so that they can recalculate
coordinates appropriately.
2016-08-16 11:19:29 -07:00
rachel-fenichel
c7dea98e88
Merge pull request #534 from picklesrus/develop-screenctm-bugs
...
Fix for #498 . Recalculate the things that use screen coordinates (de…
2016-08-12 17:15:20 -07:00
Katelyn Mann
244733467d
Fix for #498 . Recalculate the things that use screen coordinates (delete area and
...
screen transformation matrix) when a scroll happened.
This is not done using a scroll handler since the update
is expensive (getScreenCTM and getClientBoundingRect) and we don't need to do it
until the scroll is done and the user is interacting with blocks again.
2016-08-12 16:56:22 -07:00
Rachel Fenichel
a2b3a3638a
Merge branch 'develop' into feature/variable_management
2016-08-12 14:32:26 -07:00
Katelyn Mann
bbd57a9a16
Fix #536 by changing workspace's dispose method to remove the injectDiv wrapper of the
...
svg. The wrapper div was introduced in #512 .
2016-08-11 11:00:02 -07:00
Rachel Fenichel
350e1ff2cc
Merge remote-tracking branch 'upstream/develop' into feature/variable_management_merge_develop
2016-08-08 16:58:51 -07:00
Emma Dauterman
831a14e1e4
Made Blockly.WorkspaceSvg.cleanUp public
2016-08-02 17:18:12 -07:00
rachel-fenichel
b4a938f804
Merge pull request #478 from drigz/bugfix/476
...
Check flyout in isDragging()
2016-07-19 10:58:48 -07:00
Neil Fraser
4f498dc99c
Make tooltips reflect from-end indexing behaviour.
2016-07-15 14:55:05 -07:00
Rachel Fenichel
f040929bd8
Merge remote-tracking branch 'upstream/develop' into feature/merge_develop
2016-07-15 13:07:07 -07:00
Rodrigo Queiro
74e905c611
Check flyout in isDragging()
...
We also have to record startFlyout_ on background scrolls - before
dragMode_ wasn't being reset by terminateDrag() for background scrolls,
which would suppress clicks from that point on.
Fixes #476 .
2016-07-15 10:35:45 +02:00
Rodrigo Queiro
d3d0ca4fd0
Record whether the workspace has been dragged ( #475 )
...
* Record whether the workspace has been dragged
This fixes #473 by differentiating between a touch on an unmovable block
and using it to drag the workspace.
* Remove isScrolling and add DRAG_BEGIN
Applied after PR review.
2016-07-12 11:34:02 -07:00
Rodrigo Queiro
ab03c4f411
Remove out-of-date comment ( #474 )
...
This comment made sense [before multiple workspace support](67140282a0/core/blockly.js (L297) ), where it was near a (Blockly.readOnly || isTargetSvg) check. Now, this logic is implemented in BlockSvg.onMouseDown_() instead.
2016-07-11 16:43:29 -07:00
Neil Fraser
e849c93db9
Merge branch 'master' into develop
2016-07-08 16:52:18 -07:00
Neil Fraser
2dab19c015
Ensure that if a procedure call exists, so does its definition.
...
Specifically, if a call is copied, then the def is deleted, then the
call is pasted, the def should be created.
2016-07-08 15:50:09 -07:00
Rachel Fenichel
13c6c63daa
Create variables from the flyout
2016-07-07 14:39:45 -07:00
Rachel Fenichel
cb3bef8f32
Flyout button with click handler
2016-07-07 14:37:12 -07:00
Neil Fraser
555eac8b7f
Simplify field validator chaining.
2016-06-29 17:44:12 -07:00
Rodrigo Queiro
589f6ae13f
Re-enable events even when an exception is thrown
...
This prevents a recoverable exception permanently disabling events. This
could be caused by calling domToWorkspace() to load a corrupt program.
2016-06-29 14:46:06 +02:00
Rodrigo Queiro
2dcb6cb68b
Ignore mouseup at end of drag with isDragging ( #416 )
...
This includes both block drags and workspace scrolls and fixes #404 . I
used isDragging rather than checking the origin of click so that it can
easily be extended to the case where the flyout is scrolled by dragging
a block, a la LLK/scratch-blocks#206 .
2016-06-28 18:11:48 -07:00
Rachel Fenichel
a234506324
Merge branch 'develop' into feature/cache_screen_ctm
2016-06-21 15:57:53 -07:00
Rachel Fenichel
c4cad3c6e4
Cache screen CTM for performance improvement.
2016-06-17 14:26:04 -07:00
Rachel Fenichel
8f601345bb
cache delete areas instead of recalculating them onMouseDown
2016-06-17 12:39:18 -07:00
Neil Fraser
fd6f743f0e
Remove unneeded generated parens around function calls in indexOf blocks.
2016-06-13 18:49:18 -07:00
picklesrus
6851baea12
Fix #425 . Attash the resize handler to the workspace so it can be removed ( #429 )
...
when workspace.dispose() is called.
2016-06-13 14:46:58 -07:00