CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-19 06:47:12 +01:00
Code Issues Packages Projects Releases Wiki Activity
6,794 Commits 116 Branches 106 Tags
7454d2f2c97ff45d55aaa48e69df96285de958bb
Commit Graph

99 Commits

Author SHA1 Message Date
Beka Westberg
f77526e558 Move browser event utils from utils.js to browser_events.js (#5464) 
* fix: move browser event utils to browserEvents

* fix: mark browser event utils in utils as deprecated

* fix: move uses of browser event funcs to browserEvents

* fix: remove browserEvents definition of noEvent

* fix: add renames for browser event utils

* docs: add suggested alternatives for browser event utils

* fix: change deprecations to stubs

* fix: PR comments
 2021-09-17 14:49:01 -07:00
Aaron Dodson
7aab18409f Migrate selected from Blockly to Blockly.common (#5489) 
* Add getSelected/setSelected to core/common.js

* Migrate core to use Blockly.common.getSelected/setSelected instead of Blockly.selected

* Migrate demos to use Blockly.common.getSelected/setSelected instead of Blockly.selected

* Remove Blockly.selected

* Use variable instead of calling common.getSelected() multiple times

* Add accessor for selected on Blockly

* Add renaming record for Blockly.selected -> Blockly.common.getSelected/setSelected
 2021-09-17 11:42:43 -07:00
Aaron Dodson
6a4a359f7b Migrate hideChaff() from Blockly to WorkspaceSvg (#5460) 
* Add hideChaff() to core/workspace_svg.js

* Mark Blockly.hideChaff as deprecated

* Update uses of Blockly.hideChaff() to WorkspaceSvg.hideChaff() in core

* Update uses of Blockly.hideChaff() to WorkspaceSvg.hideChaff() in demos

* Style and formatting fixes

* Switch from accessor to stub wrapper for Blockly.hideChaff

Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>

Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
 2021-09-15 13:41:20 -07:00
kozbial
9561cb20c9 Migrate core/touch.js to goog.module 2021-08-17 14:42:31 -07:00
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343) 
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
 2021-08-11 18:50:45 +01:00
kozbial
0b16c9da9a Remove extra eslint disable from core/gesture.js 2021-07-30 15:58:10 -07:00
Rachel Fenichel
2e30bbe7ce Update uses of mainWorkspace in core 2021-07-30 11:30:34 -07:00
Rachel Fenichel
adc4c02abf Fix lint 2021-07-27 16:39:44 -07:00
kozbial
46c0050ce6 clang-format core/gesture.js 2021-07-26 09:41:35 -07:00
kozbial
12aa4af674 Migrate core/gesture.js named requires 2021-07-26 09:41:35 -07:00
kozbial
1d847eda4a Migrate core/gesture.js to goog.module 2021-07-26 09:41:35 -07:00
kozbial
71e187adc9 Migrate core/gesture.js to ES6 const/let 2021-07-26 09:41:35 -07:00
Rachel Fenichel
8b5f5f72d6 Refer to more constants through internalConstants 2021-07-21 15:33:55 -07:00
Rachel Fenichel
ad5836b26d Convert more names to use internalConstants 2021-07-21 15:33:55 -07:00
alschmiedt
9eaca6a1e1 Adds necessary methods for scroll-options plugin (#4893) 2021-06-10 15:50:42 -07:00
Neil Fraser
d919b0af21 Update JSDoc from Array.<> to Array<> 
Same with Object.
 2021-05-27 21:30:26 -07:00
Sam El-Husseini
f2f878db8c Fix multiple strict require warnings (#4793) 2021-04-21 16:46:04 -07:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677) 
* Add extra requires check
 2021-03-05 09:50:51 -08:00
Sam El-Husseini
ab8a11784d Fix event related missing requires (#4656) 
* Fix event related missing requires
 2021-02-25 14:28:11 -08:00
Rachel Fenichel
1d8c234d33 Update uses of bindEvent_, bindEventWithChecks_, and unbindEvent_. Add missing requires for Blockly.browserEvents. 2021-02-23 11:23:28 -08:00
Rachel Fenichel
54c4e8de39 Rename Blockly.eventHandling->Blockly.browserEvents and replace all Blockly.EventData annotations 2021-02-22 13:23:19 -08:00
Rachel Fenichel
a392fcc57c More missing requireType calls 2021-02-17 11:32:54 -08:00
Monica Kozbial
17d7d1b449 Use ScrollbarPair and WorkspaceDragger in flyouts (#4607) 
* Use ScrollbarPair for flyouts

* Address PR comments

* Fix compile error
 2021-02-02 11:46:06 -08:00
alschmiedt
efdcb89b5c Register cursors (#4599) 2021-01-21 16:01:31 -08:00
alschmiedt
a3adc42e8a Remove keyboard navigation from core (#4593) 2021-01-19 11:50:51 -08:00
Monica Kozbial
637497148d Renaming ui event properties and updating documentation for consistency (#4432) 
* Renaming properties and updating documentation for consistency

* Update more properties

* fix tests
 2020-11-05 11:40:17 -08:00
Monica Kozbial
40ef586260 Refactoring Ui events in core (#4418) 
* Ui events base (#4370)

* Add constants for new ui event types

* Add property to indicate an event as UI event

* Click events (#4372)

* Creating new ui base class.

* Refactor theme event (#4391)

* Add themeName property to theme event

* Refactor marker move events. (#4389)

* Refactor trashcan open event (#4392)

* Refactor selected event (#4387)

* Refactor toolbox item change event (#4394)

* Refactor bubble open events (#4390)

* Refactor block drag event (#4388)

* Viewport events (#4395)

* Fix event filtering for ui events (#4401)

* Move events to new directory and rename Ui events base (#4400)

* Move events to new directory and rename Ui events base

* Add missing fromJson implementation for click event (#4410)

* Adding serialization tests for events

* Zoom controls event (#4407)

* Refactor zoom event

* Rename IS_UI_EVENT to isUiEvent
 2020-11-04 14:43:54 -08:00
Sam El-Husseini
f3fdab11fb Add IBubble interface (#4104) 
* Add IBubble interface and make use of it for WorkspaceCommentSvgs
 2020-08-04 17:28:12 -04:00
alschmiedt
0f00f42580 Adds Ability to Add a Flyout as a Plugin (#4059) 2020-07-22 17:13:19 -07:00
Monica Kozbial
64488c1402 Add listener for flyout events to playground. (#4035) 
* Update workspace click and add listener for flyout events to playground.

* Fix test.

* Fix typing error

* change variable

* Update variable.
 2020-07-20 14:00:03 -07:00
Monica Kozbial
d3b8b78035 Update click event handling for workspace and trashcan. (#4024) 
* Update click event handling for workspace and trashcan.

* Fix typo

* Change event name for trashcan flyout open
 2020-07-10 13:23:08 -07:00
alschmiedt
459b1ef1fb Update jsdoc for keyboard nav (#4023) 2020-07-07 17:31:04 -07:00
alschmiedt
84e9802cdb Fix disposing of a workspace (#3960) 2020-06-11 14:14:18 -07:00
alschmiedt
6811010caf Fix emitting workspace event (#3959) 2020-06-11 11:30:54 -07:00
alschmiedt
0272401dcb Emit workspace click event (#3956) 2020-06-11 10:21:55 -07:00
Sam El-Husseini
e3babee1f3 Add Blockly.utils.Metrics @record (#3913) 
* Add Blockly.utils.Metrics
 2020-05-21 15:03:17 -07:00
alschmiedt
3a902ee970 Update ast node (#3808) 
* Update ast node
 2020-04-15 10:10:21 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences. 
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
 2020-02-11 13:27:20 -08:00
Sam El-Husseini
20e55b67d7 Fix bug with dropdown menu propagating the opening click event to a menu item (#3570) 
* Prevent dropdown field menu from propagating a click event onto a menu item when the dropdown appears above the field
 2020-01-09 18:08:29 -08:00
alschmiedt
bfa6fa6581 Removes ability to enter accessibility mode using shift click (#3538) 
* Removes ability to enter accessibility mode using shift click
 2020-01-03 11:21:42 -08:00
Neil Fraser
a15d9611d0 Add missing requires. 2019-11-12 13:15:06 -08:00
Beka Westberg
dad8738e75 Cleaned up unbindEvent_ calls (#3429) 
* Cleaned up unbindEvent_ calls.
 2019-11-12 10:14:31 -08:00
alschmiedt
40bdfac017 Fix setting focus for workspace (#3425) 
* Fix setting focus for workspace
 2019-11-11 16:44:58 -08:00
Neil Fraser
123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
alschmiedt
cbf867f441 Add keyboard navigation support for multiple workspaces (#3352) 
* Add keyboard navigation support for multiple workspaces
 2019-10-28 12:53:51 -07:00
Sam El-Husseini
d387841db2 Resolve remaining compiler warnings with visibility issues (#3335) 2019-10-24 19:13:51 -04:00
Sam El-Husseini
270781113d Fix warnings related to gestures and drag. (#3307) 
* Fix warnings related to gestures and drag.
 2019-10-22 14:21:00 -04:00
Sam El-Husseini
a5a4e5161c Fix 11 warnings related to block_svg (#3276) 
* Fix 11 warnings related to block_svg
 2019-10-17 16:30:48 -05:00
Sam El-Husseini
3c2c4677df Fix 55 warnings related to flyouts. (#3211) 
* Fix 55 warnings related to flyouts.
 2019-10-16 12:13:37 -05:00
Sam El-Husseini
986e965be8 Private/protected visibility cleanup (#3263) 
* Fix a number of private visibility issues
 2019-10-16 11:48:09 -05:00