Rachel Fenichel
ed245a3c9e
Remove dealWithOffsetFields
2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70
Cleanup and comments
2019-08-06 11:03:53 -07:00
Rachel Fenichel
3802a0c960
Remove getCorrectedSize for fields
2019-08-05 16:01:50 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83
Remove all calls to goog.math ( #2739 )
...
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Sam El-Husseini
4c626e7b76
Fix setOnClickHandler jsdoc casing ( #2730 )
2019-07-29 15:29:06 -07:00
Rachel Fenichel
08982ce55e
Merge pull request #2668 from BeksOmega/fixes/DeprecateSetText
...
Deprecated Field.setText
2019-07-26 13:02:35 -07:00
Sam El-Husseini
c1b49a1da7
Fix some jsdoc types ( #2701 )
...
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
Rachel Fenichel
5ab6977c89
Merge branch 'develop' into feature/SetOnClickImage
2019-07-24 14:23:54 -07:00
Rachel Fenichel
fc4372dbc2
Add TODOs with github issue number
2019-07-22 16:29:44 -07:00
Beka Westberg
ed41b7f900
Added a setOnClickHandler function to the image field.
2019-07-19 09:17:09 -07:00
Beka Westberg
20837da54f
Deprecated field setText function.
2019-07-19 08:57:34 -07:00
Rachel Fenichel
f469a388ed
Add getCorrectedSize functions to fields
2019-07-17 11:00:20 -07:00
Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
0122f36450
Fixed field disposal, and reorganized editor creation.
2019-06-11 13:30:50 -07:00
Neil Fraser
98a98bcce6
Add Blockly.utils.dom.XLINK_NS
...
And fix provide/require mixup.
2019-06-07 10:32:57 -07:00
Neil Fraser
848d3a3509
Move setCssTransform & createSvgElement to dom.
...
Also move SVG_NS and HTML_NS properties.
2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Beka Westberg
f0d6fbd192
Reorganized field view initialization.
2019-05-31 10:38:18 -07:00
Beka Westberg
e1e746b845
Fixed how fields handle size.
2019-05-31 07:32:43 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb
Refactored field validation.
2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5
Added Field Value Tests ( #2459 )
...
* Added field value tests.
* Fixed field image src param.
* Fixed falsy values with label fields.
* Fixed falsy values with text input fields.
* Fixed some angle field tests.
* Fixed other text input when editing tests.
* Fixed colour tests.
* Cleaned up some number and variable field tests.
* Added angle field > 360 degrees tests.
* Fixed variable validator tests.
* Split setValue tests into sub-suites.
* Fixed angle >360 tests
* Changed var declarations to property declarations.
2019-05-17 15:19:14 -07:00
Beka Westberg
354d402c49
Refactored field.init into field.initView and field.initModel
2019-05-03 07:12:46 -07:00
Beka Westberg
e8573bc0db
Added isSerializable function and SERIALIZABLE property to fields.
2019-04-21 08:28:37 -07:00
Neil Fraser
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Beka Westberg
969687ec34
Added flipRtl Support for FieldImages ( #2203 )
...
* Added flipRtl support for FieldImages. Added a flipRtl test block.
* Added blockfactory support.
* Fixed JSDoc.
2019-01-10 08:59:35 -08:00
Sandeep Dubey
b5146036e1
Fix #1632 : Added alt attribute to the field image. ( #2178 )
...
* Added alt for field image.
* Removed lint issues.
2018-12-18 13:38:53 -08:00
Rachel Fenichel
3aa0cac22b
Fix setting tooltips in init
2018-10-17 13:27:32 -07:00
duzc2dtw@gmail.com
c92a4f31f5
fix #1887
2018-09-11 00:57:52 +08:00
Andrew n marshall
411ec9724e
Replacing node.parentNode.removeChild(node)
...
...with Blockly.utils.removeNode(..), which includes
a null/undefined check on parentNode before continuing.
2018-09-04 13:31:53 -07:00
Neil Fraser
c51cf0b79c
Remove goog.dom.removeNode
2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
Neil Fraser
1d385f8d69
Require goog.userAgent in the correct files.
2018-04-11 16:59:35 -07:00
Rachel Fenichel
615c403b44
Use @nocompress annotation to fix advanced compilation.
2018-03-01 12:35:55 -08:00
Mark Gibson
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Mark Gibson
2308ae8c22
Remove underscore from fromJson_
2018-02-07 18:18:35 +00:00
Mark Gibson
d40ef474ae
See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers
2018-02-07 12:22:26 +00:00
Rachel Fenichel
3e62ffc20a
Split at higher level for multiline function calls
2018-01-24 11:26:41 -08:00
Rachel Fenichel
fb897d7786
Even more lint. 90 errors remaining.
2018-01-23 18:33:30 -08:00
Rachel Fenichel
7ef19b6851
Fix #1467
2017-12-06 17:00:22 -08:00
Neil Fraser
e100c66659
Linting.
2017-10-24 14:06:29 -07:00
Neil Fraser
5c00256e96
Style improvements. No functional changes. ( #1367 )
2017-10-17 15:19:50 -07:00
Rachel Fenichel
d4c21cea3a
Fix field_image click handler ( #1320 )
2017-09-18 13:01:19 -07:00
Neil Fraser
fc8d4c90b4
Compatibility for Closure Compiler. ( #1240 )
2017-07-31 09:07:41 -07:00
Rachel Fenichel
104958e25f
Cleanup: semicolons, spacing, etc. ( #1116 )
2017-05-19 16:27:48 -07:00
Derek Brown
63fe91180b
Add image_onclick option ( #1080 )
2017-05-19 16:18:54 -07:00
picklesrus
fd7d8b1ac8
Fix #967 by overriding the updateWidth method in FieldImage blocks to be a no-op. FieldImage fields should not change size after the width is set in init. The updateWidth and, therefore, getCachedWidth is now being called by BlockSvg renderFields_ (see commit d55d9cbd9f). IIUC, updateWidth/getCachedWidth was only called from render before which is overridden in FieldImage to be a no-op already. ( #979 )
2017-03-17 16:15:40 -07:00
Andrew n marshall
dc0d3beba3
Moving FieldImage string dereferencing back into Block.interpolate_() (part of jsonInit()). This sets a clear boundary of where dereferencing should happen.
...
Towards this, I've added message dereferencing for other field types here, as well. I've used a pattern of field-type specific helper functions.
2017-02-14 11:00:34 -08:00
Andrew n marshall
6b692a0802
Initial text block, with a mixin to generate quote image fields. ( #923 )
...
Text block now uses the extension "text_quotes", supported by Blockly.Constants.Text.QUOTE_IMAGE_MIXIN.quoteField_(fieldName), so that each platform can use the best platform appropriate image (size, density, etc.) for the quotes.
2017-02-13 15:00:02 -08:00