Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
0122f36450
Fixed field disposal, and reorganized editor creation.
2019-06-11 13:30:50 -07:00
Rachel Fenichel
8ce82d5142
Merge pull request #2558 from BeksOmega/fixes/ReadOnlyFields
...
Fixed Fields Still Being Editable on Non-Editable Blocks
2019-06-11 11:09:26 -07:00
Beka Westberg
e0909b4ef8
Fixed fields still being editable on non-editable blocks.
2019-06-10 10:42:58 -07:00
Neil Fraser
848d3a3509
Move setCssTransform & createSvgElement to dom.
...
Also move SVG_NS and HTML_NS properties.
2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba
Alphabetize require statements.
...
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
2019-06-07 10:32:57 -07:00
Neil Fraser
566f182fa8
Move Blockly.userAgent to Blockly.utils.userAgent
2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Neil Fraser
cf91b82bb0
Fix three new and ten existing Closure warnings.
...
Current count: 638
2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f
Remove goog.math.Coordinate
2019-06-07 10:32:57 -07:00
Rachel Fenichel
b99d71ba80
Merge pull request #2509 from BeksOmega/fixes/FieldInitializationReorganization
...
Reorganized Field View Initialization
2019-05-31 10:46:37 -07:00
Beka Westberg
f0d6fbd192
Reorganized field view initialization.
2019-05-31 10:38:18 -07:00
Rachel Fenichel
37d8038aa2
Merge pull request #2526 from BeksOmega/fixes/FieldNameXML
...
Moved Serializing the Field's Name up to xml.js
2019-05-31 10:31:00 -07:00
Beka Westberg
2f0b02525a
Moved serializing the field's name up to xml.js
2019-05-31 10:12:57 -07:00
Beka Westberg
e1e746b845
Fixed how fields handle size.
2019-05-31 07:32:43 -07:00
alschmiedt
ceffe5c9f5
Merge pull request #2498 from BeksOmega/tests/SetValueAbstract
...
Added More setValue Test Coverage
2019-05-30 13:10:08 -07:00
Beka Westberg
73ff710a4d
Added getSourceBlock function to field. ( #2508 )
2019-05-29 12:50:00 -07:00
Beka Westberg
e6caa50131
Added more setValue test coverage.
2019-05-25 10:20:20 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb
Refactored field validation.
2019-05-24 14:23:42 -07:00
Neil Fraser
28ad3a9bd3
Blockly.utils.userAgent moved to Blockly.userAgent
2019-05-10 16:56:26 -07:00
Neil Fraser
4062030731
Remove goog.userAgent dependency.
2019-05-10 14:03:21 -07:00
Beka Westberg
354d402c49
Refactored field.init into field.initView and field.initModel
2019-05-03 07:12:46 -07:00
Beka Westberg
247aafae7e
Added updateColour to field.
2019-04-29 16:53:59 -07:00
Beka Westberg
123b5dc91e
Added fromXml and toXml to fields.
2019-04-25 16:00:09 -07:00
Beka Westberg
5c4c816a9b
Removed setVisible from the public API ( #2406 )
2019-04-24 16:07:47 -07:00
asunwoo98
aa4d885cba
Validate newValue parameter in setValue ( #2392 )
...
* Validate newValue parameter in setValue
* bugfix
* alternate fix
* test
* cleanup
2019-04-22 16:00:37 -07:00
Beka Westberg
e8573bc0db
Added isSerializable function and SERIALIZABLE property to fields.
2019-04-21 08:28:37 -07:00
Beka Westberg
0617cc7fea
Added isDirty_ property to fields.
2019-04-15 16:37:11 -07:00
asunwoo98
ef1c6d08d4
typo fix in line 134 of field.js for documentation
2019-04-08 18:00:38 -04:00
Neil Fraser
f118d33855
Corrections to JSDoc comments
2019-03-29 15:24:37 -07:00
Neil Fraser
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Rachel Fenichel
1546f56308
Add click target property to fields, with accessor
2019-02-26 16:23:21 -08:00
Beka Westberg
2db7055827
Removed render_ call, which was causing fields to calculate their size incorrectly.
2019-01-29 15:18:18 -08:00
Neil Fraser
aa09ad9175
Line wrap at 80.
2018-10-16 11:34:10 -07:00
Neil Fraser
dddb94aedd
Fix circular dependency.
2018-10-16 11:34:10 -07:00
Rachel Fenichel
d09c340c79
Mark some field properties protected
2018-09-11 16:19:34 -07:00
Andrew n marshall
411ec9724e
Replacing node.parentNode.removeChild(node)
...
...with Blockly.utils.removeNode(..), which includes
a null/undefined check on parentNode before continuing.
2018-09-04 13:31:53 -07:00
Andrew n marshall
26903a8ca5
Update the docs related to fieldvalidators.
2018-08-22 13:27:07 -07:00
Neil Fraser
dce60fd152
Replace ReferenceError with Error.
...
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser
c51cf0b79c
Remove goog.dom.removeNode
2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a
Remove all goog.asserts and goog.isXxx
...
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Rachel Fenichel
8ead7dabd8
Use .textContent setter for field text
2018-05-16 14:48:41 -07:00
Rachel Fenichel
a8767ee6c9
Add a referencesVariables function to field
2018-04-25 15:15:05 -07:00
Rachel Fenichel
52e0241f66
Add argsIgnorePattern to the eslintrc
2018-04-06 13:29:22 -07:00
Rachel Fenichel
4c9b602523
Move event classes into separate files, and update requires accordingly
2018-02-27 17:47:33 -08:00
Mark Gibson
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Rachel Fenichel
3e62ffc20a
Split at higher level for multiline function calls
2018-01-24 11:26:41 -08:00
Rachel Fenichel
3575d53018
57 errors remaining
2018-01-23 18:42:45 -08:00
