Beka Westberg
27a6593d27
Removed Class Option Check from Text Input fromJson ( #2588 )
...
* Removed class option check from text input fromJson, as text input fields don't accept a class.
* Fixed syntax error.
2019-06-24 13:34:28 -07:00
Beka Westberg
4a0d5f5df0
Added sending the bad value to doValueInvalid.
2019-06-14 12:00:10 -07:00
Neil Fraser
b8cbd9e7df
Resolve 13 warnings
...
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
392119680e
Fixed misc PR comments.
2019-06-11 13:32:10 -07:00
Beka Westberg
81035c3bcb
Fixed unit tests.
2019-06-11 13:32:10 -07:00
Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
217206911a
Fixed some formatting in text input.
2019-06-11 13:30:50 -07:00
Beka Westberg
0122f36450
Fixed field disposal, and reorganized editor creation.
2019-06-11 13:30:50 -07:00
Neil Fraser
a9fdf7844a
Fix ordering of requires
...
Search and replace of a name strikes again.
2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba
Alphabetize require statements.
...
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
2019-06-07 10:32:57 -07:00
Neil Fraser
566f182fa8
Move Blockly.userAgent to Blockly.utils.userAgent
2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f
Remove goog.math.Coordinate
2019-06-07 10:32:57 -07:00
Beka Westberg
f0d6fbd192
Reorganized field view initialization.
2019-05-31 10:38:18 -07:00
Beka Westberg
38f437a87e
Fixed angle fields not displaying 0 when given an empty string.
2019-05-25 17:36:27 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb
Refactored field validation.
2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5
Added Field Value Tests ( #2459 )
...
* Added field value tests.
* Fixed field image src param.
* Fixed falsy values with label fields.
* Fixed falsy values with text input fields.
* Fixed some angle field tests.
* Fixed other text input when editing tests.
* Fixed colour tests.
* Cleaned up some number and variable field tests.
* Added angle field > 360 degrees tests.
* Fixed variable validator tests.
* Split setValue tests into sub-suites.
* Fixed angle >360 tests
* Changed var declarations to property declarations.
2019-05-17 15:19:14 -07:00
Neil Fraser
28ad3a9bd3
Blockly.utils.userAgent moved to Blockly.userAgent
2019-05-10 16:56:26 -07:00
Neil Fraser
4062030731
Remove goog.userAgent dependency.
2019-05-10 14:03:21 -07:00
Beka Westberg
e8573bc0db
Added isSerializable function and SERIALIZABLE property to fields.
2019-04-21 08:28:37 -07:00
Neil Fraser
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Rachel Fenichel
dfc74b8c4f
Use dropdownDiv for the angle field as well
2019-02-26 14:54:21 -08:00
alschmiedt
4bd21c5128
Added todo
2018-12-13 14:39:27 -08:00
alschmiedt
aae15f01f4
Groups events fired during field input change
2018-12-13 12:52:55 -08:00
Rachel Fenichel
d09c340c79
Mark some field properties protected
2018-09-11 16:19:34 -07:00
Andrew n marshall
7ee9b6bc3e
Fix lint errors.
2018-08-28 11:21:21 -07:00
Neil Fraser
ac2fa96d7f
Replace goog.dom.createDom for creating HTML
2018-07-11 12:20:02 -07:00
Neil Fraser
51e86263c7
Correct requires for goog.math.*
2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
Neil Fraser
eea2794e38
Remove goog.dom.TagName
2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a
Remove all goog.asserts and goog.isXxx
...
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Neil Fraser
4cb4b42f8d
Use named properties on Msg.
2018-04-27 11:50:51 -07:00
Rachel Fenichel
52e0241f66
Add argsIgnorePattern to the eslintrc
2018-04-06 13:29:22 -07:00
Rachel Fenichel
615c403b44
Use @nocompress annotation to fix advanced compilation.
2018-03-01 12:35:55 -08:00
Mark Gibson
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Mark Gibson
2308ae8c22
Remove underscore from fromJson_
2018-02-07 18:18:35 +00:00
Mark Gibson
d40ef474ae
See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers
2018-02-07 12:22:26 +00:00
Rachel Fenichel
3e62ffc20a
Split at higher level for multiline function calls
2018-01-24 11:26:41 -08:00
Rachel Fenichel
fb897d7786
Even more lint. 90 errors remaining.
2018-01-23 18:33:30 -08:00
Rachel Fenichel
f06aed4710
Fix text input widget position in RTL
2017-11-06 12:50:22 -08:00
Rachel Fenichel
8c51935025
More lint for unused variables
2017-11-03 14:04:36 -07:00
Rachel Fenichel
7277e897bc
Fix FieldTextInput showPromptEditor_ ( #1350 )
2017-09-27 17:00:44 -07:00
Rachel Fenichel
00b2b85e8c
Decompose the showEditor_ function in FieldTextInput ( #1285 )
...
* Explicit annotations
* Decompose the showEditor_ function in FieldTextInput
* Remove extra newline
2017-08-18 15:19:05 -07:00
Rachel Fenichel
2d5f1156d7
Clean up code in FieldTextInput ( #1284 )
...
* Clean up code in FieldTextInput
* Explicit annotations
* Remove extra newline
2017-08-18 14:55:40 -07:00
marisaleung
aff9c4867c
Correctly named block events called.
2017-06-08 15:44:43 -07:00
Rachel Fenichel
915f097480
Use setValue in fieldTextInput so that procedure renaming works
2017-01-18 17:08:40 -08:00
Rachel Fenichel
528ea86cbf
Check if the text has changed before firing an event
2017-01-03 14:58:05 -08:00
Rachel Fenichel
056824593e
Now that text input's setText skips setValue, it needs to explicitly create a change event
2017-01-03 14:51:28 -08:00
Rachel Fenichel
20cf6abb5f
End event groups when you finish editing a field
2017-01-03 14:09:41 -08:00
