Commit Graph

76 Commits

Author SHA1 Message Date
Aaron Dodson
3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser
90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser
c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Monica Kozbial
49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial
d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Aaron Dodson
e0693a65d2 chore: Remove declareLegacyNamespace() from files in core (#5525)
* chore: Remove declareLegacyNamespace() from files in core

* fix: Update missing/errant re-exports in blockly.js
2021-09-23 14:48:52 -07:00
Beka Westberg
f77526e558 Move browser event utils from utils.js to browser_events.js (#5464)
* fix: move browser event utils to browserEvents

* fix: mark browser event utils in utils as deprecated

* fix: move uses of browser event funcs to browserEvents

* fix: remove browserEvents definition of noEvent

* fix: add renames for browser event utils

* docs: add suggested alternatives for browser event utils

* fix: change deprecations to stubs

* fix: PR comments
2021-09-17 14:49:01 -07:00
Monica Kozbial
bec82da358 Remove require destructuring (#5294) 2021-08-03 15:07:14 -07:00
Aaron Dodson
35673a79e1 Remove unused Block.Block require 2021-07-23 13:02:15 -07:00
Aaron Dodson
08c18b479c clang-format core/flyout_horizontal.js 2021-07-23 08:13:11 -07:00
Aaron Dodson
7ee9b0a41c Migrate core/flyout_horizontal.js to named requires 2021-07-23 08:11:53 -07:00
Aaron Dodson
8b0d1df173 Migrate core/flyout_horizontal.js to goog.module 2021-07-23 08:04:52 -07:00
Aaron Dodson
b1f868fbaf Migrate core/flyout_horizontal.js to ES6 const/let 2021-07-23 08:02:15 -07:00
Rachel Fenichel
cf7a8b95b8 Remove extra requires of Blockly.constants 2021-07-21 15:35:19 -07:00
hpnrep6
048e77dc9a Include button heights in flyout height calculation 2021-07-12 01:26:03 -04:00
Aaron Dodson
50fcdfb7ac Keep horizontal flyout delete area in sync with its bounds. 2021-06-17 15:39:15 +00:00
Monica Kozbial
73b06f14bb Fix bug in Flyout getClientRect (#4901) 2021-06-11 11:10:22 -07:00
Monica Kozbial
11390341b1 Adding IDragTarget support. (#4852) 2021-06-09 13:59:22 -07:00
Neil Fraser
e661c92a36 More JSDoc improvements 2021-05-27 21:30:26 -07:00
Neil Fraser
d919b0af21 Update JSDoc from Array.<> to Array<>
Same with Object.
2021-05-27 21:30:26 -07:00
Sam El-Husseini
f2f878db8c Fix multiple strict require warnings (#4793) 2021-04-21 16:46:04 -07:00
alschmiedt
d58c80db76 Refactor flyout and toolbox metrics (#4648) 2021-03-15 12:37:23 -07:00
alschmiedt
869e4eb366 Update flyout metrics to work with the new metrics manager (#4684) 2021-03-09 17:09:49 -08:00
Rachel Fenichel
f7e0d5f4ea Use existing toolbox position enum 2021-03-05 14:16:43 -08:00
Rachel Fenichel
59084a043c TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc 2021-03-05 13:48:45 -08:00
alschmiedt
26104d280d Update metrics to support mutators (#4679) 2021-03-05 11:44:29 -08:00
Monica Kozbial
0246e2a132 Fix flyout metrics and workspace scroll (#4674)
* Fix flyout metrics and max scroll logic in scroll

* Fix horizontal scroll wheel logic
2021-03-05 11:34:29 -08:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Monica Kozbial
57749e6eb8 Updating bump logic to support single-direction scrollbars (#4652)
* Updating bump logic to support single-direction scrollbars
2021-03-01 12:20:12 -08:00
Maribeth Bottorff
4fd6d1b229 Add overrideable function to get flyout scale (#4647) 2021-02-26 12:06:27 -08:00
Monica Kozbial
dd7e365882 Scrolling readability refactor (#4643)
* Refactors scrolling logic in scrollbars and adds comments to be more readable
* Updates JSDoc description for ScrollbarPair.set and Scrollbar.set
2021-02-24 15:09:43 -08:00
Rachel Fenichel
26d2b51681 Fix missing require types 2021-02-17 11:17:48 -08:00
Monica Kozbial
17d7d1b449 Use ScrollbarPair and WorkspaceDragger in flyouts (#4607)
* Use ScrollbarPair for flyouts

* Address PR comments

* Fix compile error
2021-02-02 11:46:06 -08:00
Maribeth Bottorff
b5c77137bd factor out getX and getY methods for flyouts (#4463) 2020-11-19 10:12:06 -08:00
alschmiedt
8eb794f30e Uses the ws scroll value when updating flyout (#4415) 2020-10-30 13:30:53 -07:00
Sam El-Husseini
fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
Beka Westberg
111b47980d Fix toolbox sizes not being updated properly (#4139)
* Fix toolbox changing size

* Fix flyout changing size

* Fix mutator bumping blocks

* Fix accessing .flyout_
2020-08-13 08:19:40 -07:00
alschmiedt
0f00f42580 Adds Ability to Add a Flyout as a Plugin (#4059) 2020-07-22 17:13:19 -07:00
Sam El-Husseini
1052f7548b Enable unusedPrivateMembers check (#3924)
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
Sam El-Husseini
e3babee1f3 Add Blockly.utils.Metrics @record (#3913)
* Add Blockly.utils.Metrics
2020-05-21 15:03:17 -07:00
Sam El-Husseini
1e251e812b Hide the dropdown div when the flyout toolbox is scrolled (#3884) 2020-05-06 09:41:58 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
016a4f1b0a Fix bottom horizontal flyout delete areas (#3551) 2020-01-06 17:03:41 -08:00
Sam El-Husseini
4f02ceeba0 Make Blockly options an interface (#3312)
* Make workspace options an interface so it can be extended in the d.ts.
2019-10-22 14:20:26 -04:00
Neil Fraser
2eaabd180d Minor cleanup in keyboard nav (#3264)
* Clean cursor code

Some obvious inefficiencies that jumped out while randomly browsing the compiled code.

* Typos

* Multiplying by minus one.
2019-10-16 08:19:37 -05:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Neil Fraser
6e76b6f49e Make flyout buttons be an optional module. 2019-09-24 10:58:33 -07:00
kozbial
a12a47e0f8 Fixing require ordering and bug in horizontal layout computation. 2019-09-12 11:05:30 -07:00
kozbial
b26f50ab8d Fixing x positioning of blocks with output connections in vertical flyout. 2019-09-12 11:05:30 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00