Commit Graph

403 Commits

Author SHA1 Message Date
kozbial
30fe1aacec Migrate core/metrics_manager.js to goog.module 2021-08-18 09:54:19 -07:00
kozbial
7974e6325b Split classes from core/metrics_manager.js into multiple files 2021-08-18 09:54:19 -07:00
kozbial
2ea51db549 Migrate core/renderers/zelos/renderer.js to goog.module 2021-08-18 09:43:17 -07:00
kozbial
3be64d78aa Migrate core/theme/classic.js to goog.module 2021-08-18 09:36:31 -07:00
kozbial
221f0b9c42 Migrate core/theme/zelos.js to goog.module 2021-08-18 09:16:16 -07:00
kozbial
9561cb20c9 Migrate core/touch.js to goog.module 2021-08-17 14:42:31 -07:00
kozbial
974c73f0b9 Migrate core/renderers/measurables/connections.js to goog.module 2021-08-17 12:41:28 -07:00
kozbial
d50247664a Split classes from core/renderers/measurables/connections.js into multiple files 2021-08-17 12:41:28 -07:00
kozbial
d6eb6c14ef Migrate core/renderers/zelos/path_object.js to goog.module 2021-08-17 12:31:31 -07:00
kozbial
6bf554643a Migrate core/renderers/measurables/rows.js to goog.module 2021-08-17 09:41:32 -07:00
kozbial
11f4479faf Split classes from core/renderers/measurables/rows.js into multiple files 2021-08-17 09:41:32 -07:00
Aaron Dodson
dbe7aaa8c8 Migrate core/renderers/measurables/row_elements.js to goog.module syntax (#5381)
* Split provides in core/renderers/measurables/row_elements.js into individual files

* Migrate core/renderers/measurables/row_elements.js to ES6 const/let

* Migrate core/renderers/measurables/row_elements.js to goog.module

* Migrate core/renderers/measurables/row_elements.js to named requires

* clang-format core/renderers/measurables/row_elements.js
2021-08-16 15:54:11 -07:00
kozbial
1cd9e1c8ea Migrate core/renderers/thrasos/info.js to goog.module 2021-08-16 11:23:51 -07:00
kozbial
9daf2f3be1 Migrate core/renderers/thrasos/renderer.js to goog.module 2021-08-16 11:01:50 -07:00
Aaron Dodson
9046ce165b Migrate core/widgetdiv.js to goog.module syntax (#5331)
* Migrate core/widgetdiv.js to ES6 const/let

* Migrate core/widgetdiv.js to goog.module

* Migrate core/widgetdiv.js to named requires

* clang-format core/widgetdiv.js

* Mark WidgetDiv.DIV as deprecated and refactor callers to use setters/getters

* Fix deprecation date

* Refactor tests to make setDiv() in core/widgetdiv.js test-only

* Fix type annotations for WidgetDiv.DIV and move test cleanup into sharedTestTeardown
2021-08-16 10:23:50 -07:00
Aaron Dodson
26195a6d9c Migrate core/renderers/minimalist/info.js to goog.module syntax (#5364)
* Migrate core/renderers/minimalist/info.js to goog.module

* Migrate core/renderers/minimalist/info.js to named requires

* clang-format core/renderers/minimalist/info.js
2021-08-16 08:49:49 -07:00
Aaron Dodson
1e32aee7ac Migrate core/renderers/minimalist/constants.js to goog.module syntax (#5363)
* Migrate core/renderers/minimalist/constants.js to goog.module

* Migrate core/renderers/minimalist/constants.js to named requires

* clang-format core/renderers/minimalist/constants.js
2021-08-16 08:48:56 -07:00
Aaron Dodson
8e3cf41d2b Migrate core/renderers/minimalist/renderer.js to goog.module syntax (#5365)
* Migrate core/renderers/minimalist/renderer.js to goog.module

* Migrate core/renderers/minimalist/renderer.js to named requires

* clang-format core/renderers/minimalist/renderer.js
2021-08-16 08:24:36 -07:00
kozbial
42ce46bdd8 Migrate core/renderers/zelos/marker_svg.js to goog.module 2021-08-12 17:04:18 -07:00
kozbial
a0980ae3be Migrate core/renderers/zelos/info.js to goog.module 2021-08-12 16:00:29 -07:00
kozbial
8073b0e282 Migrate core/renderers/zelos/drawer.js to goog.module 2021-08-12 13:20:24 -07:00
Aaron Dodson
ee3f4d257b Migrate core/utils/string.js to goog.module syntax (#5059)
* Migrate core/utils/string.js to ES6 const/let

* Migrate core/utils/string.js to goog.module

* clang-format core/utils/string.js

* Migrate core/utils/string.js to current exports convention

* Convert two remaining vars to lets in core/utils/string.js
2021-08-12 11:44:08 -07:00
Aaron Dodson
c86c8f8e92 Migrate core/variables.js to goog.module syntax (#5321)
* Migrate core/variables.js to ES6 const/let

* Migrate core/variables.js to goog.module

* Migrate core/variables.js to named requires

* clang-format core/variables.js

* Add JSDoc and make testdeps function test-only

* Fix return type for getTestDeps

* Migrate to new style of exposing methods for mocking in core/variables.js
2021-08-12 09:55:38 -07:00
kozbial
d6dc3807e9 Migrate core/renderers/common/debugger.js to goog.module 2021-08-12 09:53:30 -07:00
kozbial
c539c53981 Migrate core/renderers/zelos/constants.js to goog.module 2021-08-12 09:46:10 -07:00
Maribeth Bottorff
13fdf601b7 Merge branch 'goog_module' of github.com:google/blockly into module_aria 2021-08-11 17:22:12 -07:00
Maribeth Bottorff
f1e8f75f75 Merge branch 'goog_module' of github.com:google/blockly into bubble-module 2021-08-11 17:12:33 -07:00
kozbial
a64097d23f Migrate core/xml.js to goog.module 2021-08-11 16:09:44 -07:00
kozbial
61eb96c831 Migrate core/insertion_marker_manager.js to goog.module 2021-08-11 16:02:56 -07:00
kozbial
e16a0a4bce Migrate core/events/events_ui.js and core/events/events_ui_base.js to goog.module 2021-08-11 15:44:43 -07:00
kozbial
3bdcfd9821 Split core/ui_events.js into multiple files 2021-08-11 15:44:43 -07:00
Aaron Dodson
cf96aac58e Migrate core/procedures.js to goog.module syntax (#5265)
* Migrate core/procedures.js to ES6 const/let

* Migrate core/procedures.js to goog.module

* Migrate core/procedures.js to named requires

* clang-format core/procedures.js

* Rename xml to utilsXml to disambiguate from Xml
2021-08-11 14:04:02 -07:00
kozbial
26d4431ae5 Migrate core/renderers/geras/measurables/input.js to goog.module 2021-08-11 13:51:05 -07:00
kozbial
87568c5869 Split classes from core/renderers/geras/measurables/input.js into multiple files 2021-08-11 13:51:05 -07:00
kozbial
59dee77fa8 Migrate core/renderers/measurables/inputs.js to goog.module 2021-08-11 13:49:50 -07:00
kozbial
09573bcf16 Split classes from core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial
c1bf49ae5c Migrate core/renderers/common/renderer.js to goog.module 2021-08-11 13:45:38 -07:00
kozbial
7c45b039f3 Migrate core/renderers/minimalist/drawer.js to goog.module 2021-08-11 13:44:17 -07:00
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson
a5729043c1 Migrate core/events/events_block_drag.js to goog.module syntax (#5286)
* Migrate core/events/events_block_drag.js to ES6 const/let

* Migrate core/events/events_block_drag.js to goog.module

* Migrate core/events/events_block_drag.js to named requires

* clang-format core/events/events_block_drag.js
2021-08-11 08:40:01 -07:00
Aaron Dodson
4b6ccf868c Migrate core/events/events_theme_change.js to goog.module syntax (#5279)
* Migrate core/events/events_theme_change.js to ES6 const/let

* Migrate core/events/events_theme_change.js to goog.module

* Migrate core/events/events_theme_change.js to named requires

* clang-format core/events/events_theme_change.js
2021-08-11 08:35:01 -07:00
Aaron Dodson
228ecb0f2d Migrate core/renderers/geras/renderer.js to goog.module syntax (#5307)
* Migrate core/renderers/geras/renderer.js to goog.module

* Migrate core/renderers/geras/renderer.js to named requires

* clang-format core/renderers/geras/renderer.js
2021-08-11 08:30:05 -07:00
Aaron Dodson
0f7f597758 Migrate core/renderers/geras/drawer.js to goog.module syntax (#5300)
* Migrate core/renderers/geras/drawer.js to ES6 const/let

* Migrate core/renderers/geras/drawer.js to goog.module

* Migrate core/renderers/geras/drawer.js to named requires

* clang-format core/renderers/geras/drawer.js

* Remove Blockly prefix on call to blockRendering in core/renderers/geras/drawer.js
2021-08-11 08:26:04 -07:00
Aaron Dodson
18283e816f Migrate core/renderers/measurables/base.js to goog.module syntax (#5308)
* Migrate core/renderers/measurables/base.js to goog.module

* Migrate core/renderers/measurables/base.js to named requires
2021-08-11 08:11:44 -07:00
kozbial
ee53e8e812 Update optional requires 2021-08-10 11:18:38 -07:00
Aaron Dodson
6bae1ce9f9 Migrate core/workspace_svg.js to goog.module syntax (#5334)
* Migrate core/workspace_svg.js to ES6 const/let

* Migrate core/workspace_svg.js to goog.module

* Migrate core/workspace_svg.js to named requires

* clang-format core/workspace_svg.js
2021-08-10 08:09:46 -07:00
kozbial
ec1567020b Migrate core/toolbox/toolbox.js to goog.module 2021-08-09 18:53:11 -07:00
kozbial
9ac531ba58 Migrate core/events/block_events.js to goog.module 2021-08-09 18:52:07 -07:00
kozbial
d1ab960f0f Split classes from core/events/variable_events.js into multiple files 2021-08-09 18:52:07 -07:00
kozbial
fd0385dd63 Migrate core/events/block_events.js to goog.module 2021-08-09 18:26:43 -07:00