Commit Graph

1929 Commits

Author SHA1 Message Date
Rachel Fenichel 981761f7da Move the base Measurable class to its own file 2019-08-19 13:54:07 -07:00
Rachel Fenichel 450ac4ba15 Consider min height and min width in row measure 2019-08-19 13:30:41 -07:00
Rachel Fenichel efdf80c49c Reset height and width at the beginning of a measure 2019-08-19 11:28:39 -07:00
Rachel Fenichel b2ebe89493 Cleanup 2019-08-19 11:28:39 -07:00
Rachel Fenichel 88a9307cdb Move all rows into rows.js 2019-08-19 11:28:12 -07:00
Rachel Fenichel 4a3fdb83db Move rows to a new file and annotate 2019-08-19 11:28:12 -07:00
Sam El-Husseini 445419e8f8 Update css to show visual indicator of focus on dropdowndivs and widget dropdowns (#2860) 2019-08-19 10:51:17 -07:00
Monica Kozbial a1ab4b92bd Merge pull request #2845 from moniika/moniika-render-draw-simple-warnings
Fixing basic warnings in block_render_draw_debug.
2019-08-19 10:40:25 -07:00
alschmiedt a72950cc83 Fix cursor svg to work with new rendering (#2856) 2019-08-16 18:52:29 -07:00
Sam El-Husseini c99734b8f9 Add valuemin and valuemax aria properties for number fields (#2850) 2019-08-16 18:41:05 -07:00
Sam El-Husseini 63f55da379 Remove last bit of closure! (#2858) 2019-08-16 18:39:25 -07:00
Sam El-Husseini ff76ee5b0d Dropdown field with Blockly.Menu (#2832)
* Switch dropdown field from using goog.ui.Menu to Blockly.Menu
2019-08-16 18:22:05 -07:00
Rachel Fenichel b42214abd1 Guarantee that the top and bottom rows exist 2019-08-16 17:36:02 -07:00
Rachel Fenichel 40b3f18766 Merge pull request #2851 from rachel-fenichel/annotations
Fix some compiler warnings
2019-08-16 17:30:17 -07:00
Sam El-Husseini 8cfb67187f Contextmenu with Blockly.Menu (#2834)
* Switch contextmenu  from using goog.ui.Menu to Blockly.Menu
2019-08-16 17:25:56 -07:00
Sam El-Husseini 2b26787185 Blockly menus without closure (#2831)
* Blockly Menu and MenuItem that don't rely on the closure library.
2019-08-16 17:23:14 -07:00
Rachel Fenichel ca6e591047 Turn off debug rendering 2019-08-16 17:10:06 -07:00
Rachel Fenichel 04a77f0ef2 Fix some compiler warnings 2019-08-16 17:05:24 -07:00
Sam El-Husseini 8e4d904095 Listen to focus events on children and add a focused class in the dropdown (#2848) 2019-08-16 16:29:34 -07:00
Sam El-Husseini ca83f97074 Colour field accessibility (#2836)
* Implement key board navigation and aria accessibility for the colour field.
2019-08-16 13:49:05 -07:00
Rachel Fenichel 803a20b6bc Merge pull request #2789 from BeksOmega/feature/FieldUtils
Extracted Common Field Support Methods Into Utils Files
2019-08-16 13:38:33 -07:00
Beka Westberg 0516122dff Added case-insensativity & safety rebuild. 2019-08-16 12:49:18 -07:00
kozbial 41e6167334 Fixing basic warnings in block_render_draw_debug. 2019-08-16 11:51:24 -07:00
Monica Kozbial 5f9e54a309 Merge pull request #2841 from moniika/moniika-misc-cleanup
Cleaning up some warnings in block_render_draw.js.
2019-08-16 11:23:15 -07:00
Beka Westberg f1afb61694 Maybe fix mocha? 2019-08-16 10:26:01 -07:00
Beka Westberg ae3e8895b7 Maybe fix Mocha? 2019-08-16 10:00:46 -07:00
Beka Westberg 891d23795e Corrected some language. 2019-08-16 09:57:28 -07:00
Beka Westberg 0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg 84937a0ff6 Fixed lint error. 2019-08-16 09:57:27 -07:00
Beka Westberg 16c59d2ffc Added tests and remove jsunit fields test file. 2019-08-16 09:57:27 -07:00
Beka Westberg cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Sam El-Husseini f539dbe6f6 Add aria invalid for when a text input field is invalid (#2839) 2019-08-15 17:13:06 -07:00
Sam El-Husseini f174f422ff Set the border size on a text input to take into account scaling. (#2837) 2019-08-15 16:23:17 -07:00
kozbial ca357aa71f Cleaning up some warnings in block_render_draw.js. 2019-08-15 16:16:26 -07:00
alschmiedt 9b3e05e3d9 Field accessibility (#2823)
* Gives fields a chance to handle keyboard events
2019-08-15 15:44:54 -07:00
Rachel Fenichel a01d1eb5bc Merge pull request #2825 from rachel-fenichel/block_widths
Correctly calculate widths of blocks with children on external inputs.
2019-08-15 14:35:15 -07:00
Rachel Fenichel f4d8c24e53 Merge pull request #2833 from rachel-fenichel/remove_render_icon
Remove renderIcon function
2019-08-15 11:28:21 -07:00
Rachel Fenichel 26e9348b07 Center some fields and inputs vertically 2019-08-15 11:06:05 -07:00
Rachel Fenichel eea2e2c61f Remove renderIcon function 2019-08-15 10:28:26 -07:00
Monica Kozbial 47400f2b8e Merge pull request #2829 from moniika/moniika-fix-zero-height-spacer-row-rtl
Prevent incorrectly drawing vertical line for zero height spacer rows in RTL.
2019-08-14 16:50:39 -07:00
kozbial c4165e92b8 Prevent incorrectly drawing vertical line for zero height spacer rows. 2019-08-14 16:16:48 -07:00
Beka Westberg 0eacbd7217 Fixed typo. 2019-08-14 15:45:37 -07:00
Beka Westberg c862a13a38 Cleaned up BlockBase and CommentBase toJson and fromJson calls. 2019-08-14 15:45:37 -07:00
Rachel Fenichel f3aca51ba9 Merge pull request #2827 from rachel-fenichel/delete_old_rendering
DELETE CODE
2019-08-14 14:53:56 -07:00
Rachel Fenichel 9325e993b2 Remove call to renderInternal 2019-08-14 14:48:25 -07:00
Sam El-Husseini 174fe53516 Minor jsdoc issue (#2826)
The JavaScript closure compiler barfs at this. No such thing as JSDOC @throw.
2019-08-14 14:40:54 -07:00
Rachel Fenichel 3e85d7b05a DELETE CODE 2019-08-14 14:32:48 -07:00
Sam El-Husseini 4a10ff833d Remove all calls to goog.events.KeyCodes (#2824)
* Remove all calls to goog.events.keyCodes
2019-08-14 14:14:49 -07:00
Rachel Fenichel 7b5e6eee63 Correctly calculate widths of blocks with children on external inputs. 2019-08-14 14:09:20 -07:00
Sam El-Husseini f118d6de88 No closure toolbox (#2819)
* Update the toolbox to not rely on closure and instead use the built in Blockly.tree component
2019-08-14 13:48:21 -07:00