Commit Graph

4166 Commits

Author SHA1 Message Date
Beka Westberg
41db0c5fb0 fix: feedback on procedure model implementations (#6560)
* fix: feedback on procedure model implementations

* chore: format
2022-10-25 08:46:42 -07:00
Rachel Fenichel
a46e12b06b chore: remove underscores from menuitem and menu (#6567)
* chore: remove underscores in menuitem.ts

* chore: remove underscores in menu.ts

* chore: format
2022-10-25 08:33:59 -07:00
Blake Thomas Williams
f22303b91d chore: added type information to core/field_dropdown.ts (#6550)
* chore: added generator type to `core/field_dropdown.ts` and updated affected files

* chore: added type to ARROW_CHAR in `core/field_dropdown.ts`

* chore: cleaned up misc 'AnyDuringMigration' cases and related comments

* fix: misc adjustments from PR feedback

* Fix: simplified `getOptions`

* fix: removed outdated arrow and cleaned up formatting

* fix: cleanup format after rebase
2022-10-24 14:35:25 -07:00
Beka Westberg
d58844d23c Revert "chore: update procedure map tests to match the refactored API (#6562)" (#6568)
This reverts commit 5f70fc415b.
2022-10-19 10:42:32 -07:00
Beka Westberg
5f70fc415b chore: update procedure map tests to match the refactored API (#6562)
* fix: feedback on procedure model implementations

* chore: format

* chore: add tests for the backing variable of parameter models

* chore: update existing procedure map tests

* chore: update block update tests to use refactored API

* chore: update tests to actually use fluent API

* chore: format

* chore: fix tests

* chore: reorganize tests

* chore: format

* chore: add comment
2022-10-19 10:28:40 -07:00
Beka Westberg
04dffbc33a chore: fix mutator blocks jumping (#6559)
* chore: fix mutator blocks jumping

* chore: format
2022-10-18 14:15:53 -07:00
Neil Fraser
321f619e28 fix: Don't warn if field is acually 0 width (#6558)
One part of issue 6557.
2022-10-18 23:01:41 +02:00
Beka Westberg
df660af66c fix: make getSourceBlock nullable again (#6542)
* fix: make getSourceBlock nullable again

* chore: format

* chore: move to a specific error

* chore: also update procedures with new error

* chore: format
2022-10-18 12:57:44 -07:00
Rachel Fenichel
b0c897224a chore: clean up code in field_angle.ts (#6551) 2022-10-17 09:27:42 -07:00
Neil Fraser
5a23c84e6e Don't quote fromJson property. (#6545)
This is the only place in our codebase where it's quoted.  The result is a failure to compile correctly using advanced optimizations.
2022-10-14 19:01:28 +02:00
Maribeth Bottorff
caf91c82a6 fix: fix pinch to zoom (#6544)
* fix: fix pinch to zoom

* chore: format
2022-10-13 18:05:42 -07:00
Beka Westberg
a7247af7c3 feat: add basic observable implementations of procedure interfaces (#6489)
* feat: implement basic observable procedure model

* feat: implement basic observable procedure model

* feat: implement basic observable parameter model

* feat: implement basic observable procedure map

* chore: format

* chore: refactor parameter model

* chore: update the observable procedure model to match interface

* chore: update the observable parameter model to match interface

* chore: update the observable procedure map

* chore: update concrete implementations to use this return type

* chore: format

* chore: remove legacy module IDs

* chore: fix typo
2022-10-13 15:23:10 -07:00
Beka Westberg
1162a660a0 feat: add interface definitions for procedure stuff (#6488)
* feat: add interface definitions for procedure stuff

* fix: signature of insertParameter

* fix: remove declareModuleId

* fix: remove variable-ness from the parameter interface

* chore: types -> type

* chore: PR comments

* fix: update interfaces to use this return type

* chore: format
2022-10-13 11:21:37 -07:00
Beka Westberg
7147813693 fix: parent blocks not bumping neighbours (#6538)
* fix: parent blocks not bumping neighbours

* chore: add more comments
2022-10-13 10:59:04 -07:00
Neil Fraser
9b81317d32 chore: Remove blockly factory use of utils.dom.add/removeClass (#6534)
* Remove usages of utils.dom.add/removeClass from Blockly Factory
* Use template strings for error messages.

(Random stuff found while working on something larger.)
2022-10-13 01:30:17 +02:00
Rachel Fenichel
ab9825cfaf chore: remove underscores from some private properties and methods (#6537)
* chore: rename properties to remove underscores in zoom_controls.ts

* chore: remove underscores from private methods in zoom_controls.ts

* chore: fix underscores in private property names in ws_svg

* chore: format
2022-10-12 16:07:13 -07:00
Rachel Fenichel
25fe27221f chore: remove underscores from private properties in workspace.ts (#6536) 2022-10-12 13:28:29 -07:00
Rachel Fenichel
a9b0b199e3 chore: clean up some underscores (#6492)
* chore: clean up block_drag_surface.ts

* chore: remove underscores in property names in bubble.ts

* chore: remove underscores from method names in bubble.ts

* chore: format, and remove one cast
2022-10-11 15:48:21 -07:00
Beka Westberg
ca3b9bd079 fix: move Theme to use a Partial type for BlockStyle (#6532)
* fix: move theme to use Partial type

* chore: remove useless error throwing

* chore: format

* chore: update validatedBlockStyle_ to use Partial
2022-10-11 15:40:56 -07:00
koenvanwijk
581e8acf4b fix: Connections can be highlighted multiple times (#6502)
* fix: Connections can be highlighted multiple times

* fix: remove spaces to fix clang-formating
2022-10-10 11:34:27 -07:00
Beka Westberg
a263587ca0 chore: rearrange serialization export to make APIExtractor happy (#6480)
* chore: rearrange serialization export to make APIExtractor happy

* chore: format
2022-10-05 13:43:07 -07:00
Neil Fraser
84f6dfef4f Fix: // isn't a legal comment in CSS (#6467) 2022-10-05 06:38:32 +02:00
YAMADA Yutaka
2a2cbb4722 fix: Modifying size update handling for multiline field in parent block. (#6461) 2022-10-03 11:48:57 -07:00
Beka Westberg
d3447ea565 fix!: Update deprecations for the new release. (#6470)
* chore: bump early deprecations to v10

* fixup

* fixup

* chore: remove deprecated properties

* chore: add missing @deprecated tags

* chore: format

* chore: format

* chore: fix import
2022-10-03 11:21:52 -07:00
Blake Thomas Williams
e0b60cbf8a chore: fixed tsdoc missing deprecation messages (#6460)
* chore: added missing deprecation messages for `core/renderers/common/block_rendering.ts`

* chore: added missing deprecation messages for `core/utils.ts`

* chore: updated format

* fix: reverted runAfterPageLoad to internal and updated messaging
2022-09-30 14:25:44 -07:00
Blake Thomas Williams
fa925e8c35 chore: cleaned up several type cases in core/field.ts and impacted files (#6363)
* chore: cleaned up several type cases in core/field.ts and impacted files

* chore: updated instances of `sourceBlock_!` to `getSourceBlock()`

* chore: updated instances of `fieldGroup_!` to `getSvgRoot()`

* chore: updated nullable variables in `field.ts` to use internal functions

* chore: updated getSourceBlock and getSvgRoot to handle nullability

* chore: updated comments to reference throwing an error

* fix: reverted `getSvgRoot` to `fieldGroup_` in null-accepting areas

* fix: updated `getSvgRoot` to allow null and added null handling methods

* fix: moved click target error handling to their specific cases

* fix: updated drawer.ts to handle cast svg group to defined
2022-09-30 08:53:19 -07:00
Rachel Fenichel
dd0d0f6bcf fix(tests): revert change in marker_svg to keep keyboard nav tests working (#6457) 2022-09-30 08:03:13 -07:00
Beka Westberg
8530e6d537 fix: adding and removing css classes that contained spaces (#6455)
* fix: adding CSS classes

* fix: removing css classes

* fix: add a test for multiple icon classes

* chore: format
2022-09-28 15:51:17 -07:00
Beka Westberg
f678531389 chore: remove AnyDuringMigration from events (#6382)
* chore: remove AnyDuringMigration from events

* chore: format

* chore: lint

* chore: fix tests

* fix: correct types for JSON properties

* chore: fix tests

* refactor: replace exclamation markers with errors

* chore: fix build and tests

* chore: set event types as members, rather than in constructor

* chore: update comment

* chore: export new types

* chore: format

* chore: remove unnecessary override

* chore: change how we're overriding isBlank

* chore: remove unnecessary ?

* chore: remove non-null assertion in block move event

* chore: format

* chore: revert changes to isNull

* chore: format
2022-09-27 15:08:05 -07:00
Beka Westberg
eb1b78663c fix: field defaults not being defined correctly (#6453) 2022-09-27 14:53:44 -07:00
Aaron Dodson
ab03c65f9f fix: Fix blocks with mutators. (#6440)
* refactor: Revert the Mutator/Icon constructor API changes with a deprecation warning.

* fix: Update the block definitions to use the new Mutator constructor.
2022-09-27 13:42:52 -07:00
Beka Westberg
9c81e7591a fix: message types being incorrect (#6414)
* chore: regen msg dts files

* fix: package tasks not packaging msg.d.ts files

* fix: add setLocale to blockly.ts

* chore: format

* chore: move setLocale

* chore: add comment about setLocale not being useful when used with script tags

* chore: format
2022-09-26 14:02:57 -07:00
Beka Westberg
893787b285 fix: path object not checking theme props (#6451)
* fix: path object not checking theme props

* fix: error msgs
2022-09-26 13:58:57 -07:00
Beka Westberg
abad51fdb0 fix: theme types (#6423)
* chore: fix theme types

* chore: format
2022-09-26 12:52:46 -07:00
Beka Westberg
f2e408b6fa fix: disposing of a workspace that has overwritten shadows (#6424)
* fix: disposing of a workspace that has overwritten shadows

* fix: try slightly different placement to fix tests

* fix: add disposing parameter to guaruntee consistent behavior

* chore: wrap properties in a isDeadOrDying method

* chore: make disposing private
2022-09-26 12:37:36 -07:00
Neil Fraser
e5dcb766bd chore: Remove radix from parseInt, simplify Blockly.utils.dom methods, use Unicode characters. (#6441)
* chore: remove radix from parseInt

Previously any number starting with '0' would be parsed as octal if the radix was left blank.  But this was changed years ago.  It is no longer needed to specify a radix.

* chore: 'ID' is identification

'id' is a part of Freud's brain.

* Use Unicode characters instead of codes

This is in line with the current style guide.

* Simplify Blockly.utils.dom methods.

classList add/remove/has supports SVG elements in all browsers Blockly supports (i.e. not IE).
2022-09-22 06:59:24 -07:00
Aaron Dodson
c84febbe07 refactor: Remove more uses of AnyDuringMigration (#6439)
* refactor: Remove uses of AnyDuringMigration from workspace_comment.ts

* refactor: Remove uses of AnyDuringMigration from separator.ts.

* refactor: Remove uses of AnyDuringMigration from category.ts.

* refactor: Remove uses of AnyDuringMigration from rendered_connection.ts.

* refactor: Removed uses of AnyDuringMigration from flyout_metrics_manager.ts.

* refactor: Remove uses of AnyDuringMigration from dom.ts.
2022-09-21 12:28:35 -07:00
Rachel Fenichel
c2cbed1146 fix: some AnyDuringMigration (#6430)
* fix: remove some AnyDuringMigrations

* fix: some instances of AnyDuringMigration

* fix: some AnyDuringMigration

* chore: revert comment removal
2022-09-15 12:48:40 -07:00
Christopher Allen
c063d12abb chore: Re-remove core/blockly.js (#6422)
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:

* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.

Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
2022-09-14 18:11:14 +01:00
Neil Fraser
05b221b1d6 fix: Deep copy options used by dropdown fields (#6425)
This uncovered a broken test that was only passing because of a side effect of the dropdown option data getting modified.
2022-09-13 13:29:38 -07:00
Rachel Fenichel
e3fa43d861 feat: return element from menu.render (#6426)
* feat: return element from menu.render

* chore: format

* chore: add returns annotation
2022-09-13 13:29:18 -07:00
Rachel Fenichel
5f11f3449f fix: remove calls to removeClass and hasClass (#6413)
* fix: stop using dom.addClass in most cases

* chore: format

* fix: remove use of dom.addClass in toolbox

* chore: lint and format

* fix: add checks around non-constant class names

* fix: switch back to quoted access

* chore: format

* fix: remove calls to removeClass

* chore: format

* chore: remove unused deps

* fix: remove uses of hasClass

* chore: format and lint

* chore: format
2022-09-13 08:33:49 -07:00
Beka Westberg
26561947fb chore: remove AnyDuringMigration from the other renderers (#6409)
* chore: remove AnyDuringMigration from geras renderer

* chore: more removing AnyDuringMigration from renderers

* chore: remove AnyDuringMigration from constants

* chore: format

* chore: work on PR comments

* chore: fix typo and resulting build issues
2022-09-12 15:01:01 -07:00
Beka Westberg
b5cd839000 chore: remove AnyDuringMigration from common renderer (#6402)
* chore: remove AnyDuringMigration from common renderer

* chore: remove AnyDuringMigration in common drawer

* chore: format

* chore: add dividers back

* chore: format
2022-09-11 13:06:41 -07:00
Beka Westberg
d754c6d278 chore: remove AnyDuringMigration from gesture code (#6401)
* chore: work on refactoring gesture code

* chore: reorganize throw order

* chore: format

* chore: PR comments

* chore: format
2022-09-09 16:29:06 -07:00
Christopher Allen
5d3ba79ab3 fix!(connection): Correctly handle multiple highlighted connections (#6416)
Modify RenderedConnection.prototype.highlight and .unhighlight to
store the highlight path on this rather than as a static property
on Connection (which is where it had been stored since this
functionality was originally created, previously to RenderedConnection
and Connection being split).
2022-09-09 18:00:59 +01:00
ktbytechibong
e58cf77b7f fix: TS errors on dependent projects with certain tsconfig settings (#6360) (#6361)
* fix: TS errors on dependent projects with certain tsconfig settings (#6360)

* Address PR comments
2022-09-06 13:19:56 -07:00
Maribeth Bottorff
ec72e8bb4d chore: add api extractor configuration and fix some associated problems (#6388)
* chore: add configuration for api extractor

* fix: remove extra param names

* chore: private to internal

* remove unrestricted

* chore: remove double backticks

* chore: remove fileoverview and export * as

* chore: return to returns

* chore: fix backslashes and angle brackets in tsdoc

* chore: final to sealed

* chore: ignore to internal

* chore: fix link tags

* chore: add api-extractor configuration

* chore: add unrecognized tag names

* chore: remove tsdoc-metadata

* fix: correct index.d.ts

* chore: fix connection link
2022-09-01 11:39:05 -07:00
Rachel Fenichel
55ea12bd21 fix: stop using is3dSupported (#6400)
* fix: remove prefix checks from is3dSupported

* fix: stop using is3dSupported

* chore: mark is3dSupported deprecated

* chore: fix lint
2022-08-31 12:59:16 -04:00
Beka Westberg
21237c9362 chore: remove AnyDuringMigration from the insertion marker manager (#6398)
* chore: remove AnyDuringMigration from the insertion marker manager

* chore: fix final issues

* chore: format
2022-08-31 09:27:23 -07:00