* chore: added generator type to `core/field_dropdown.ts` and updated affected files
* chore: added type to ARROW_CHAR in `core/field_dropdown.ts`
* chore: cleaned up misc 'AnyDuringMigration' cases and related comments
* fix: misc adjustments from PR feedback
* Fix: simplified `getOptions`
* fix: removed outdated arrow and cleaned up formatting
* fix: cleanup format after rebase
* fix: feedback on procedure model implementations
* chore: format
* chore: add tests for the backing variable of parameter models
* chore: update existing procedure map tests
* chore: update block update tests to use refactored API
* chore: update tests to actually use fluent API
* chore: format
* chore: fix tests
* chore: reorganize tests
* chore: format
* chore: add comment
* fix: make getSourceBlock nullable again
* chore: format
* chore: move to a specific error
* chore: also update procedures with new error
* chore: format
* feat: implement basic observable procedure model
* feat: implement basic observable procedure model
* feat: implement basic observable parameter model
* feat: implement basic observable procedure map
* chore: format
* chore: refactor parameter model
* chore: update the observable procedure model to match interface
* chore: update the observable parameter model to match interface
* chore: update the observable procedure map
* chore: update concrete implementations to use this return type
* chore: format
* chore: remove legacy module IDs
* chore: fix typo
* feat: add interface definitions for procedure stuff
* fix: signature of insertParameter
* fix: remove declareModuleId
* fix: remove variable-ness from the parameter interface
* chore: types -> type
* chore: PR comments
* fix: update interfaces to use this return type
* chore: format
* Remove usages of utils.dom.add/removeClass from Blockly Factory
* Use template strings for error messages.
(Random stuff found while working on something larger.)
* chore: rename properties to remove underscores in zoom_controls.ts
* chore: remove underscores from private methods in zoom_controls.ts
* chore: fix underscores in private property names in ws_svg
* chore: format
* chore: clean up block_drag_surface.ts
* chore: remove underscores in property names in bubble.ts
* chore: remove underscores from method names in bubble.ts
* chore: format, and remove one cast
* chore: cleaned up several type cases in core/field.ts and impacted files
* chore: updated instances of `sourceBlock_!` to `getSourceBlock()`
* chore: updated instances of `fieldGroup_!` to `getSvgRoot()`
* chore: updated nullable variables in `field.ts` to use internal functions
* chore: updated getSourceBlock and getSvgRoot to handle nullability
* chore: updated comments to reference throwing an error
* fix: reverted `getSvgRoot` to `fieldGroup_` in null-accepting areas
* fix: updated `getSvgRoot` to allow null and added null handling methods
* fix: moved click target error handling to their specific cases
* fix: updated drawer.ts to handle cast svg group to defined
* refactor: Revert the Mutator/Icon constructor API changes with a deprecation warning.
* fix: Update the block definitions to use the new Mutator constructor.
* chore: regen msg dts files
* fix: package tasks not packaging msg.d.ts files
* fix: add setLocale to blockly.ts
* chore: format
* chore: move setLocale
* chore: add comment about setLocale not being useful when used with script tags
* chore: format
* fix: disposing of a workspace that has overwritten shadows
* fix: try slightly different placement to fix tests
* fix: add disposing parameter to guaruntee consistent behavior
* chore: wrap properties in a isDeadOrDying method
* chore: make disposing private
* chore: remove radix from parseInt
Previously any number starting with '0' would be parsed as octal if the radix was left blank. But this was changed years ago. It is no longer needed to specify a radix.
* chore: 'ID' is identification
'id' is a part of Freud's brain.
* Use Unicode characters instead of codes
This is in line with the current style guide.
* Simplify Blockly.utils.dom methods.
classList add/remove/has supports SVG elements in all browsers Blockly supports (i.e. not IE).
* refactor: Remove uses of AnyDuringMigration from workspace_comment.ts
* refactor: Remove uses of AnyDuringMigration from separator.ts.
* refactor: Remove uses of AnyDuringMigration from category.ts.
* refactor: Remove uses of AnyDuringMigration from rendered_connection.ts.
* refactor: Removed uses of AnyDuringMigration from flyout_metrics_manager.ts.
* refactor: Remove uses of AnyDuringMigration from dom.ts.
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:
* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.
Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
* fix: stop using dom.addClass in most cases
* chore: format
* fix: remove use of dom.addClass in toolbox
* chore: lint and format
* fix: add checks around non-constant class names
* fix: switch back to quoted access
* chore: format
* fix: remove calls to removeClass
* chore: format
* chore: remove unused deps
* fix: remove uses of hasClass
* chore: format and lint
* chore: format
* chore: remove AnyDuringMigration from geras renderer
* chore: more removing AnyDuringMigration from renderers
* chore: remove AnyDuringMigration from constants
* chore: format
* chore: work on PR comments
* chore: fix typo and resulting build issues
* chore: remove AnyDuringMigration from common renderer
* chore: remove AnyDuringMigration in common drawer
* chore: format
* chore: add dividers back
* chore: format
Modify RenderedConnection.prototype.highlight and .unhighlight to
store the highlight path on this rather than as a static property
on Connection (which is where it had been stored since this
functionality was originally created, previously to RenderedConnection
and Connection being split).