Commit Graph

1336 Commits

Author SHA1 Message Date
Rachel Fenichel aae8277513 Merge pull request #2022 from rachel-fenichel/feature/canvas_transition
Add support for transitioning the workspace block and bubble canvases on scrollCenter
2018-08-27 11:31:06 -07:00
Rachel Fenichel 48dac195f7 CSS style 2018-08-27 11:23:24 -07:00
Neil Fraser cb3ea2f56e Remove goog.ui.ColorPicker (#2020)
Adds the ability to set the tooltip titles for each colour.

Note that Closure’s colour picker in Blockly used to have keyboard controls (as of > 3 years ago); but no longer seems to.  This replacement does not currently have keyboard controls either.
2018-08-24 12:14:42 -07:00
Rachel Fenichel 8f675fd82e Add support for transitioning the workspace block and bubble canvases on scrollCenter 2018-08-24 11:55:55 -07:00
RoboErikG 9eacd7d3b9 Disable/enable function calls along with their definitions (#2019)
Fixes #1344

Extends the event listener on procedure caller blocks to also check
for their definition being enabled/disabled and update their own
state in response.
2018-08-23 11:18:29 -07:00
Andrew n marshall 26903a8ca5 Update the docs related to fieldvalidators. 2018-08-22 13:27:07 -07:00
picklesrus 962fcd5c2e Fix #1959 by calling bring to front when a block drag starts inside a mutator. (#2013) 2018-08-21 12:51:43 -07:00
DD 4a34663d49 Fix lint 2018-08-08 21:10:02 -04:00
DD 8d3dea4c74 Add issue to todo and getter for isVisible on workspace 2018-08-08 20:44:23 -04:00
DD e06807155d Add todo per code review 2018-08-07 18:04:04 -04:00
Rachel Fenichel 2eeee8b9af Stop handling keypresses when the workspace is hidden. 2018-08-07 18:03:23 -04:00
Andrew n marshall e064a147c7 Create a common helper function for Comment[Create|Delete]) (PR #1988)
Resolves #1871
2018-08-07 12:54:47 -07:00
Rachel Fenichel 341865c80c Merge pull request #1995 from rachel-fenichel/feature/unplug_horizontal
Heal rows when unplugging, and add tests
2018-08-06 11:28:12 -07:00
Rachel Fenichel b89487e332 Ignore whether parent has multiple inputs 2018-08-06 11:18:00 -07:00
Rachel Fenichel a8d52903e2 update comment with todo 2018-08-06 10:29:12 -07:00
Dhruv 3ab37dbe46 #1871 Create a common helper function for Comment[Create|Delete] 2018-08-07 00:17:55 +08:00
Neil Fraser c6afb08c4b Add unit tests and code cleanup to utils (#1993)
* Add unit tests for new util functions
* Utils functions shouldn’t be package, not private.
* Use existing utility function for insertAfter
2018-08-03 14:31:50 -07:00
Rachel Fenichel b65491e656 Heal rows when unplugging, and add tests 2018-08-03 13:54:29 -07:00
Neil Fraser 6ce31942e0 Some goog.dom removal (#1991) 2018-08-01 15:47:28 -07:00
RoboErikG 99ebefa1bf Revert "Fix #1960 by collecting block info before icons are destroyed" (#1973)
* Revert "Localisation updates from https://translatewiki.net."

This reverts commit c4a0b64945.

* Revert "Fix #1960 by collecting block info before icons are destroyed (#1970)"

This reverts commit 9a3bd45b22.
2018-07-16 10:18:40 -07:00
RoboErikG 9a3bd45b22 Fix #1960 by collecting block info before icons are destroyed (#1970)
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
2018-07-12 15:34:32 -07:00
Neil Fraser ac2fa96d7f Replace goog.dom.createDom for creating HTML 2018-07-11 12:20:02 -07:00
Neil Fraser dce60fd152 Replace ReferenceError with Error.
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser c51cf0b79c Remove goog.dom.removeNode 2018-07-11 12:20:02 -07:00
Neil Fraser f802859547 Remove goog.dom.removeChildren
HTML can be nullified with innerHTML, SVG needs a loop.
2018-07-11 12:20:02 -07:00
Neil Fraser c8e08109f2 Correct requires for goog.style 2018-07-11 12:20:02 -07:00
Neil Fraser 51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00
Neil Fraser 0583bee502 Correct requires for goog.dom 2018-07-11 12:20:02 -07:00
Neil Fraser 8f7674ea08 Correct requires for goog.events 2018-07-11 12:20:02 -07:00
Neil Fraser 67a18036d0 Fix Travis errors 2018-07-11 12:20:02 -07:00
Neil Fraser 07d1d86283 Remove remaining goog.math 2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 60cce6cd0c Remove goog.math angle functions. 2018-07-11 12:20:02 -07:00
Neil Fraser eea2794e38 Remove goog.dom.TagName 2018-07-11 12:20:02 -07:00
Neil Fraser 06d90c9b34 Remove goog.array 2018-07-11 12:20:02 -07:00
Neil Fraser 03bf9f5e71 Remove goog.string 2018-07-11 12:20:02 -07:00
Neil Fraser 3909bd420a Remove all goog.asserts and goog.isXxx
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Andrew n marshall 02dc7b1d1d Fixing JSDoc for the return type of Blockly.WorkspaceComment.parseAttributes (#1966) 2018-07-03 12:07:25 -07:00
Andrew n marshall cf3f914be8 Moving TODOs out of jsdoc comments. (#1965) 2018-07-03 11:42:40 -07:00
Neil Fraser 13f7e75ffb Supress empty <variables> tag in XML. 2018-06-29 17:52:26 -07:00
Rachel Fenichel caac6b8324 Merge pull request #1932 from rachel-fenichel/lint/infix_curly
Add curly and space-infix-ops rules
2018-06-25 17:12:44 -04:00
Rachel Fenichel 5b1e249adc Fix lint 2018-06-25 12:12:24 -07:00
Mark Gibson 709d31b729 Fix case of duplicate var (i) 2018-06-19 11:00:24 +01:00
Andrew n marshall 100d9f1a1c Support %{..} in flyout_button (#1927) (#1929)
Expand %{..} references in toolbox <button> and <label>
2018-06-18 11:45:36 -07:00
Neil Fraser 05fcdc3510 Remove goog.Timer 2018-06-12 14:06:10 -07:00
Andrew n marshall 7886d24130 Fixing xml.js: Always throw XML I/O errors; Support parsing in Node (#1911)
* Improved Blockly.XML comments.
 * Support JSDOM as an alternate parser under Node.js
 * Throw standard errors instead of goog.asserts.
 * Adding textToDomDocument_ and override in gulpfile.
2018-06-12 14:03:10 -07:00
Andrew n marshall 2c84161b4a Correct require goog.Timer statements. (#1906) 2018-06-06 15:57:53 -07:00
Rachel Fenichel bae346963f Remove custom touch handling code for dropdown fields 2018-06-06 12:34:28 -07:00
Andrew n marshall dc081e3677 Fixed typo (#1899)
Correct name in FieldButton member reference.
2018-06-06 10:42:19 -07:00
Andrew n marshall e9aae34388 Adaptive popup size for FieldDropdowns (#1897)
Replace the fixed dropdown height with one responsive to the document's viewport.

This is adapted from Bohdan-Tereta's proposed solution:
https://github.com/google/blockly/pull/1483#issuecomment-381638639

It is sub-optimal, in that is does not adapt to field height (variable
due to workspace zoom), and it does not fully utilize the space above
or below the field if the block is near the top or the bottom.
2018-05-31 16:37:09 -07:00