CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-26 18:20:10 +01:00
Code Issues Packages Projects Releases Wiki Activity
3,744 Commits 114 Branches 106 Tags
b54ec1e2dbf8eaeb7bd931e490ca67421bcfcc35
Commit Graph

256 Commits

Author SHA1 Message Date
Sam El-Husseini
c1b49a1da7 Fix some jsdoc types (#2701) 
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
 2019-07-25 12:24:36 -07:00
Rachel Fenichel
4901c6c040 Merge branch 'develop' into choose_renderer 2019-07-24 14:21:30 -07:00
Rachel Fenichel
eb8f1819e2 Make it possible to choose the renderer at runtime, with a constant. 2019-07-24 14:04:58 -07:00
Abby
3dd1973a5a Ran the rename script 2019-07-24 13:48:25 -07:00
Abby
1c26b6d79b Adds helper functions for keyboard nav 2019-07-24 11:42:37 -07:00
Neil Fraser
e06d4e648c Rename BlockAnimation > blockAnimation 
Issue 2102.  And do a full recompile due to changed the dependency name.
 2019-07-08 17:31:38 -07:00
alschmiedt
a7ec185c69 Adds fill to svg dark path 2019-07-03 14:10:56 -07:00
Neil Fraser
d23dc0ae55 Minor cleanup from #2581 2019-06-28 16:47:12 -07:00
Neil Fraser
712576a5b1 Fix IE not unhighlighting 
This is a rework of PR #2580.
 2019-06-28 16:47:12 -07:00
amber-cd
492d0719d6 Pull Request: Split showContextMenu_ (#2581) 
* Split showContextMenu_

Split showContextMenu_ into generateContextMenu_ and showContextMenu_. This allows for custom Blockly forks to easily extend the context menu options available on all blocks by just doing something like

```
var oldGenerateContextMenu_ = Blockly.BlockSvg.prototype.generateContextMenu_;
Blockly.BlockSvg.prototype.generateContextMenu_ = function() {
  var menuOptions = Blockly.BlockSvg.prototype.generateContextMenu_() || [];
  // Push other options into menuOptions
  return menuOptions;
}
```

Rather than having to modify the core code in such a way as to cause unnecessary maintenance overhead when upgrading Blockly versions.

* Forgot the docblock, sorry

* Oops, missed a few ESLint things

* Update block_svg.js

Updated to be protected rather than private.
 2019-06-21 15:14:11 -07:00
Neil Fraser
b8cbd9e7df Resolve 13 warnings 
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
 2019-06-12 10:59:33 -07:00
Neil Fraser
0213de11bc Use Rect in more places. 2019-06-07 10:32:57 -07:00
Neil Fraser
848d3a3509 Move setCssTransform & createSvgElement to dom. 
Also move SVG_NS and HTML_NS properties.
 2019-06-07 10:32:57 -07:00
Neil Fraser
02e9b25f03 Flaten bounding box data structure. 
Old: a box object with two coordinate objects, each with two numbers.
New: a box object with four numbers.

The old system would make sense if there was a reason to group the top-left and bottom-right coordinates.  But in our code we only pulled out top/bottom/left/right numbers.

New code is simpler and faster.
 2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba Alphabetize require statements. 
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
 2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8 Move utilities into own directory. 
TODO: There are more functions which may be migrated into dom and string.
 2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f Remove goog.math.Coordinate 2019-06-07 10:32:57 -07:00
Neil Fraser
9f528922a7 Fix some dependencies 2019-05-24 15:45:05 -07:00
Neil Fraser
5cf52c566a Fix a dozen compiler warnings. 2019-05-17 16:48:40 -07:00
Neil Fraser
32631577a4 Defenestration 2019-05-17 15:04:39 -07:00
Neil Fraser
4161ba0fa7 Move goog.global to Blockly.utils.global 
Can’t use Blockly.global since that’s the last file to load.
 2019-05-17 15:04:39 -07:00
Neil Fraser
25ddecab50 Undo workaround for IE10. 
Due to no longer supporting IE10, we don’t need the code added here: 92f3880008
 2019-05-10 16:39:32 -07:00
Beka Westberg
247aafae7e Added updateColour to field. 2019-04-29 16:53:59 -07:00
Jim Jiang
1b10d134a5 Add Block.setEnabled (#2386) 
* Implement Block.setEnabled()

From issue #1593. This commit:
- add setEnabled
- deprecate setDisabled

* Update setDisabled calls to setEnabled

Add setEnabled and deprecate setDisabled in
- core/block_svg

Update calls in
- blocks/loops
- blocks/procedures
- core/block_events
- core/events
- core/flyout_base
- core/xml
- tests/workplace_svg/procedure_svg_test

* Implement changes from comments from RoboErikG

- Implement isEnabled()
- Make this.disabled @private
- Make setDisabled(disabled) call setEnabled(!disabled)
- Update setEnabled to use isEnabled()

* Utilize isEnabled() and fix typos

Fix missing parentheses
Implement isEnabled() more widely
Fix lint and parentheses errors

* Change prevDisabledState to prevEnabledState
 2019-04-23 08:49:07 -07:00
ahigerd
bc77024670 Reorganize conditionals for block context menu (#2390) 
* Reorganize conditionals for block context menu

* Disable comments and disabling in block factory
 2019-04-18 08:49:07 -07:00
Neil Fraser
e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Neil Fraser
6fb95f9038 Consistent speling. 2019-03-29 15:24:37 -07:00
alschmiedt
58c365e377 Changes colour names 2019-02-06 14:24:41 -08:00
alschmiedt
7941651444 Merge pull request #2184 from alschmiedt/blockly_colours 
Blockly Themes
 2019-01-11 10:57:57 -08:00
Beka Westberg
7f160bd322 Fixed comments not being recorded in delete event. (#2211) 2019-01-10 14:35:06 -08:00
alschmiedt
f125065a17 Merge branch 'develop' of https://github.com/alschmiedt/blockly into blockly_colours 2018-12-19 10:39:10 -08:00
alschmiedt
9afe497b7e Fixes jsdocs 2018-12-19 08:45:20 -08:00
alschmiedt
2fa7ab2825 Fixes setting border and updating shadow color 2018-12-18 10:57:20 -08:00
Beka Westberg
8241068630 Updated JSDoc. 2018-12-17 15:29:25 -08:00
Beka Westberg
44df2d4680 Changed parent blocks to display "Collapsed blocks contain warnings." instead of having warnings "bubble up" from children. Added message to msg/messages.js . 2018-12-17 14:54:56 -08:00
Beka Westberg
f16cdf912d Changed Warnings to Interact Properly with Collapsing/Expanding. 2018-12-15 15:52:34 -08:00
alschmiedt
56c2e5fc31 Initial commit for adding a style 2018-12-11 13:22:25 -08:00
Neil Fraser
db0dbc69ee Update todos and requires. 2018-10-16 11:34:10 -07:00
Neil Fraser
aa09ad9175 Line wrap at 80. 2018-10-16 11:34:10 -07:00
Rachel Fenichel
a0e90627f7 Add some functions for insertion markers 2018-09-13 15:55:49 -07:00
Andrew n marshall
411ec9724e Replacing node.parentNode.removeChild(node) 
...with Blockly.utils.removeNode(..), which includes
a null/undefined check on parentNode before continuing.
 2018-09-04 13:31:53 -07:00
RoboErikG
9eacd7d3b9 Disable/enable function calls along with their definitions (#2019) 
Fixes #1344

Extends the event listener on procedure caller blocks to also check
for their definition being enabled/disabled and update their own
state in response.
 2018-08-23 11:18:29 -07:00
RoboErikG
99ebefa1bf Revert "Fix #1960 by collecting block info before icons are destroyed" (#1973) 
* Revert "Localisation updates from https://translatewiki.net."

This reverts commit c4a0b64945.

* Revert "Fix #1960 by collecting block info before icons are destroyed (#1970)"

This reverts commit 9a3bd45b22.
 2018-07-16 10:18:40 -07:00
RoboErikG
9a3bd45b22 Fix #1960 by collecting block info before icons are destroyed (#1970) 
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
 2018-07-12 15:34:32 -07:00
Neil Fraser
dce60fd152 Replace ReferenceError with Error. 
Change to 4-space indentation rather than aligning with parent structure.
 2018-07-11 12:20:02 -07:00
Neil Fraser
c51cf0b79c Remove goog.dom.removeNode 2018-07-11 12:20:02 -07:00
Neil Fraser
06d90c9b34 Remove goog.array 2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a Remove all goog.asserts and goog.isXxx 
First step to reducing Closure’s footprint.
 2018-07-11 12:20:02 -07:00
Andrew n marshall
2c84161b4a Correct require goog.Timer statements. (#1906) 2018-06-06 15:57:53 -07:00
Rachel Fenichel
73e6cf1265 Fix undoing a drag to connect 2018-05-23 14:56:41 -07:00