Commit Graph

85 Commits

Author SHA1 Message Date
alschmiedt
c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00
Neil Fraser
28953d8ea0 Simplify Blockly.utils.IdGenerator
Also drop unused menu highlight hook.
2019-09-20 10:36:06 -07:00
Sam El-Husseini
cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
Sam El-Husseini
8fae0411f7 Check if a type exists before testing instanceof (#3031)
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
Sam El-Husseini
f3f3329355 Fix configure method (#2915)
* Fix configure method.
2019-09-12 17:01:03 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini
03b1e7f8d4 Fixes toolbox and menu dropdown on mobile. (#2931)
* Fixes toolbox and menu dropdown for mobile.
2019-08-30 10:23:42 -07:00
Beka Westberg
23e0733f21 Changed field and colour constructors to use better organization. (#2900) 2019-08-23 10:54:44 -07:00
Beka Westberg
0d482c6488 Changed colour field to new configuration paradigm. 2019-08-20 09:44:14 -07:00
Sam El-Husseini
8a04d5d71b Field colour + Blockly actions (#2855)
* Update field colour to support blockly actions
2019-08-19 16:09:38 -07:00
Neil Fraser
096959fde9 Cleanup of last fortnight’s commits. (#2865)
No functional changes.
2019-08-19 14:07:48 -07:00
Sam El-Husseini
ca83f97074 Colour field accessibility (#2836)
* Implement key board navigation and aria accessibility for the colour field.
2019-08-16 13:49:05 -07:00
Beka Westberg
0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg
cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Rachel Fenichel
40ba284c3f Change constant 2019-08-06 13:40:06 -07:00
Rachel Fenichel
c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00
Rachel Fenichel
3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
Neil Fraser
45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Neil Fraser
6aedfab4d1 Misc JSDoc fixes. (#2747) 2019-07-30 16:28:48 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Rachel Fenichel
b5c75ff24d Merge pull request #2651 from rachel-fenichel/field_corrected_sizes
Add getCorrectedSize functions to fields
2019-07-22 16:45:13 -07:00
Rachel Fenichel
fc4372dbc2 Add TODOs with github issue number 2019-07-22 16:29:44 -07:00
Beka Westberg
2464e3af46 Added setting a colour fields options through JSON. (#2655) 2019-07-18 12:23:31 -07:00
Rachel Fenichel
f469a388ed Add getCorrectedSize functions to fields 2019-07-17 11:00:20 -07:00
Beka Westberg
bf6d621c63 Added colour and date editor auto close on selection. 2019-06-11 16:22:24 -07:00
Beka Westberg
303115953e Moved to #2125 disposal. Cleaned up some doc. 2019-06-11 13:32:09 -07:00
Beka Westberg
0122f36450 Fixed field disposal, and reorganized editor creation. 2019-06-11 13:30:50 -07:00
Neil Fraser
aca1a43ec8 Fix regular expressions.
1) Simplifications.
2) Enable toolbox category colours to be specified using the full range of CSS formats (not just hue or #rrggbb).
3) Fix bug where `Blockly.utils.checkMessageReferences('%{BKY_today}  %{BKY_xxx}')` returns true.
2019-06-10 11:03:22 -07:00
Neil Fraser
cdaded4296 Remove goog.color.parse 2019-06-05 16:41:04 -07:00
Neil Fraser
4f20264128 Remove orphaned regexp. 2019-06-05 16:41:04 -07:00
Beka Westberg
54eb726063 Removed extra DropDownDiv calls. (#2532) 2019-06-03 11:02:05 -07:00
Beka Westberg
f0d6fbd192 Reorganized field view initialization. 2019-05-31 10:38:18 -07:00
Beka Westberg
e1e746b845 Fixed how fields handle size. 2019-05-31 07:32:43 -07:00
Beka Westberg
06c6d83355 Changed colour field class validator to accept all documented values. 2019-05-24 16:14:49 -07:00
Neil Fraser
9f528922a7 Fix some dependencies 2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb Refactored field validation. 2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5 Added Field Value Tests (#2459)
* Added field value tests.

* Fixed field image src param.

* Fixed falsy values with label fields.

* Fixed falsy values with text input fields.

* Fixed some angle field tests.

* Fixed other text input when editing tests.

* Fixed colour tests.

* Cleaned up some number and variable field tests.

* Added angle field > 360 degrees tests.

* Fixed variable validator tests.

* Split setValue tests into sub-suites.

* Fixed angle >360 tests

* Changed var declarations to property declarations.
2019-05-17 15:19:14 -07:00
Neil Fraser
25bc3e0268 Fix require statements.
Also throw error instead of string.
And stop using goog.asserts.
2019-05-17 15:04:39 -07:00
Neil Fraser
28ad3a9bd3 Blockly.utils.userAgent moved to Blockly.userAgent 2019-05-10 16:56:26 -07:00
Beka Westberg
354d402c49 Refactored field.init into field.initView and field.initModel 2019-05-03 07:12:46 -07:00
Beka Westberg
e8573bc0db Added isSerializable function and SERIALIZABLE property to fields. 2019-04-21 08:28:37 -07:00
Beka Westberg
0617cc7fea Added isDirty_ property to fields. 2019-04-15 16:37:11 -07:00
Neil Fraser
e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Rachel Fenichel
e20a7ef3c2 Use constants for dropdown div colours in the colour field 2019-03-01 12:38:37 -08:00
Rachel Fenichel
0b1bd78674 Clarify some dropdown rendering code 2019-02-28 15:11:57 -08:00
Rachel Fenichel
4f3bb673ef Add require and rebuild for travis 2019-02-26 11:05:27 -08:00
Rachel Fenichel
2c624c5144 Use dropdowndiv for field colour but not field dropdown 2019-02-26 11:03:28 -08:00
Rachel Fenichel
763a06a7ac Use dropdown div for colour field 2019-02-21 13:41:45 -08:00
Neil Fraser
cb3ea2f56e Remove goog.ui.ColorPicker (#2020)
Adds the ability to set the tooltip titles for each colour.

Note that Closure’s colour picker in Blockly used to have keyboard controls (as of > 3 years ago); but no longer seems to.  This replacement does not currently have keyboard controls either.
2018-08-24 12:14:42 -07:00
Neil Fraser
0583bee502 Correct requires for goog.dom 2018-07-11 12:20:02 -07:00