Commit Graph

172 Commits

Author SHA1 Message Date
Monica Kozbial
a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Monica Kozbial
a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Sam El-Husseini
57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
kozbial
60e6b8c6df style and doc updates. 2019-09-19 10:38:23 -07:00
kozbial
3d06e7eb33 Creating cursordrawer in renderer. 2019-09-19 10:38:23 -07:00
Sam El-Husseini
8fae0411f7 Check if a type exists before testing instanceof (#3031)
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
Monica Kozbial
e551db41e0 Merge pull request #3017 from moniika/moniika-debug-render-checkmarks
Adding checkboxes for debug rendering options to playground.
2019-09-16 17:18:32 -07:00
Rachel Fenichel
77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
kozbial
53cb811f78 Addressing PR comments. 2019-09-16 11:42:28 -07:00
kozbial
02e5b77a20 Adding checkboxes for debug rendering options to playground. 2019-09-16 11:42:28 -07:00
Sam El-Husseini
e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini
fc420b7037 Support for registering renderers and switching between them (#3013)
* Added support for registering renderers and for choosing which renderer the workspace wants to use.
2019-09-13 10:30:20 -07:00
Neil Fraser
23caa12571 Error is a constructor, ‘new’ is not required. 2019-09-12 18:02:59 -07:00
kozbial
8a00ed9eb2 Remove duplicate check and undo changes in debugger render. 2019-09-12 13:36:45 -07:00
kozbial
90a10e5f44 Fix logic in shouldStartNewRow_ and between row padding in geras. 2019-09-12 11:34:08 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel
4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Sam El-Husseini
4c8e28c53d Dynamic output shapes (#2980)
* Round and triangle dynamic output shapes.
2019-09-06 13:04:01 -07:00
Rachel Fenichel
e96acf476c Add dark path offset in geras info. 2019-09-05 16:55:56 -07:00
Rachel Fenichel
261040a6fd Add jsdoc 2019-09-05 16:19:51 -07:00
Rachel Fenichel
e48c60fee6 Use strings instead of arrays for highlight paths 2019-09-05 15:48:46 -07:00
Rachel Fenichel
77c6344a37 Reset renderer 2019-09-05 12:01:54 -07:00
Rachel Fenichel
2ffe71f0a0 Remove references to dark path offset; fix highlights while dragging' 2019-09-05 11:59:28 -07:00
Rachel Fenichel
da6d28b818 More cleanup 2019-09-05 11:16:27 -07:00
Rachel Fenichel
87e7be9619 Cleanup 2019-09-04 17:19:31 -07:00
Rachel Fenichel
581705cc7b Create a Renderer base class and extend it for each type of renderer 2019-09-04 17:16:08 -07:00
Rachel Fenichel
e35f4d5070 More cleanup. 2019-09-04 16:26:53 -07:00
Rachel Fenichel
b4ac23df6c Remove useless variable. 2019-09-04 16:26:53 -07:00
Rachel Fenichel
135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini
73d0b70c22 Add a spacer before and after a statement input and place use it to render a right corner before and after the statement input. (#2967) 2019-09-04 15:38:23 -07:00
Rachel Fenichel
5dc45be726 Reset default renderer to geras. (#2960) 2019-09-03 15:55:52 -07:00
Sam El-Husseini
189c561f49 Rendering type checker (#2950)
* Convert all rendering types to use a type enum flag.
2019-09-03 14:39:02 -07:00
Sam El-Husseini
96378f9183 Fix slight offset in statement input connection X location. (#2953)
* Fix slight offset in statement input connection X location.
2019-09-03 14:38:10 -07:00
Rachel Fenichel
ff64170239 Merge pull request #2947 from rachel-fenichel/pad_dummies
Fix width on dummy row.
2019-09-03 10:55:55 -07:00
Sam El-Husseini
06a882348b Render round right corners in zelos. (#2938)
* Render round right corners in zelos.
2019-08-30 18:11:01 -07:00
Rachel Fenichel
4dfb03adbf Make statement inputs store their actual width. (#2944)
* Make statement inputs store their actual width.
2019-08-30 17:55:51 -07:00
Rachel Fenichel
d3fea64f99 Fix width on dummy row. 2019-08-30 17:50:06 -07:00
Sam El-Husseini
6050456bcf Fix bug in base renderer, not respecting the bottom row's overhang Y property. (#2942) 2019-08-30 15:44:44 -07:00
Rachel Fenichel
aa8f4685da Add connectedBlockBounds option; set quieter defaults 2019-08-29 17:12:09 -07:00
Rachel Fenichel
c069316866 Debug configurability 2019-08-29 16:21:51 -07:00
Rachel Fenichel
bc50143130 Remove special case for spacer after statement 2019-08-29 15:05:09 -07:00
kozbial
25a41fd6ab Adding drop shadow into statement input height computation. 2019-08-27 17:24:29 -07:00
kozbial
e063ae5a38 Simplify statement input height computation logic. 2019-08-27 16:50:09 -07:00
Sam El-Husseini
e7f10e7c3e minor rendering fix (#2919) 2019-08-27 10:47:32 -07:00
Sam El-Husseini
dc1e7b82fe Zelos notch (#2918)
* Add the zelos notch
2019-08-26 17:49:42 -07:00
Rachel Fenichel
d28c5dd8be Rename rendering files and folders 2019-08-26 10:48:44 -07:00
Rachel Fenichel
9c27b878d7 Move the rest of the measurables into their own folder 2019-08-26 10:25:35 -07:00
Rachel Fenichel
7c40ddf141 Update warning 2019-08-26 10:22:58 -07:00
Rachel Fenichel
27cd26b264 Add a function to get the shape object of a connection, and use it 2019-08-23 17:34:41 -07:00
Rachel Fenichel
f4dc626439 lint 2019-08-23 17:05:36 -07:00