Commit Graph

28 Commits

Author SHA1 Message Date
Monica Kozbial
a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Monica Kozbial
a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Rachel Fenichel
77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
Sam El-Husseini
e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel
4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Rachel Fenichel
e35f4d5070 More cleanup. 2019-09-04 16:26:53 -07:00
Rachel Fenichel
135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini
189c561f49 Rendering type checker (#2950)
* Convert all rendering types to use a type enum flag.
2019-09-03 14:39:02 -07:00
Sam El-Husseini
06a882348b Render round right corners in zelos. (#2938)
* Render round right corners in zelos.
2019-08-30 18:11:01 -07:00
Rachel Fenichel
4dfb03adbf Make statement inputs store their actual width. (#2944)
* Make statement inputs store their actual width.
2019-08-30 17:55:51 -07:00
Rachel Fenichel
bc50143130 Remove special case for spacer after statement 2019-08-29 15:05:09 -07:00
Rachel Fenichel
27cd26b264 Add a function to get the shape object of a connection, and use it 2019-08-23 17:34:41 -07:00
Rachel Fenichel
a81c633be7 Centralize references to Blockly.blockRendering.constants 2019-08-22 18:08:59 -07:00
Rachel Fenichel
dd9fdf908f Slightly less fragile 2019-08-21 15:24:37 -07:00
Rachel Fenichel
e86c852936 Split render_info 2019-08-21 14:33:43 -07:00
Rachel Fenichel
611b9884ca Move input measurables into a separate file, and make them extend connection measurables. 2019-08-20 15:51:31 -07:00
Rachel Fenichel
d790ad98ee Merge pull request #2882 from rachel-fenichel/measurables_connections_file
Move Connection measurables to their own file
2019-08-20 15:48:33 -07:00
kozbial
ffbd483442 Storing notch_left_offset on rows and measurables. 2019-08-20 14:09:16 -07:00
Rachel Fenichel
8d32f6bef3 Move Connection measurables to their own file 2019-08-20 11:41:04 -07:00
kozbial
c50257619f Updating for loops in renderers to use constent pattern. 2019-08-20 11:40:01 -07:00
Rachel Fenichel
9dcd38abb8 Remove dead TODO 2019-08-20 10:45:53 -07:00
Rachel Fenichel
9b8636661f Make rows populate themselves 2019-08-19 15:08:23 -07:00
Rachel Fenichel
450ac4ba15 Consider min height and min width in row measure 2019-08-19 13:30:41 -07:00
Rachel Fenichel
efdf80c49c Reset height and width at the beginning of a measure 2019-08-19 11:28:39 -07:00
Rachel Fenichel
b2ebe89493 Cleanup 2019-08-19 11:28:39 -07:00
Rachel Fenichel
88a9307cdb Move all rows into rows.js 2019-08-19 11:28:12 -07:00
Rachel Fenichel
4a3fdb83db Move rows to a new file and annotate 2019-08-19 11:28:12 -07:00