9a3bd45b22
Fix #1960 by collecting block info before icons are destroyed ( #1970 )
...
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
2018-07-12 15:34:32 -07:00
ac2fa96d7f
Replace goog.dom.createDom for creating HTML
2018-07-11 12:20:02 -07:00
dce60fd152
Replace ReferenceError with Error.
...
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
c51cf0b79c
Remove goog.dom.removeNode
2018-07-11 12:20:02 -07:00
f802859547
Remove goog.dom.removeChildren
...
HTML can be nullified with innerHTML, SVG needs a loop.
2018-07-11 12:20:02 -07:00
c8e08109f2
Correct requires for goog.style
2018-07-11 12:20:02 -07:00
51e86263c7
Correct requires for goog.math.*
2018-07-11 12:20:02 -07:00
0583bee502
Correct requires for goog.dom
2018-07-11 12:20:02 -07:00
8f7674ea08
Correct requires for goog.events
2018-07-11 12:20:02 -07:00
67a18036d0
Fix Travis errors
2018-07-11 12:20:02 -07:00
07d1d86283
Remove remaining goog.math
2018-07-11 12:20:02 -07:00
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
60cce6cd0c
Remove goog.math angle functions.
2018-07-11 12:20:02 -07:00
eea2794e38
Remove goog.dom.TagName
2018-07-11 12:20:02 -07:00
06d90c9b34
Remove goog.array
2018-07-11 12:20:02 -07:00
03bf9f5e71
Remove goog.string
2018-07-11 12:20:02 -07:00
3909bd420a
Remove all goog.asserts and goog.isXxx
...
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
02dc7b1d1d
Fixing JSDoc for the return type of Blockly.WorkspaceComment.parseAttributes ( #1966 )
2018-07-03 12:07:25 -07:00
cf3f914be8
Moving TODOs out of jsdoc comments. ( #1965 )
2018-07-03 11:42:40 -07:00
13f7e75ffb
Supress empty <variables> tag in XML.
2018-06-29 17:52:26 -07:00
caac6b8324
Merge pull request #1932 from rachel-fenichel/lint/infix_curly
...
Add curly and space-infix-ops rules
2018-06-25 17:12:44 -04:00
5b1e249adc
Fix lint
2018-06-25 12:12:24 -07:00
709d31b729
Fix case of duplicate var (i)
2018-06-19 11:00:24 +01:00
100d9f1a1c
Support %{..} in flyout_button ( #1927 ) ( #1929 )
...
Expand %{..} references in toolbox <button> and <label>
2018-06-18 11:45:36 -07:00
05fcdc3510
Remove goog.Timer
2018-06-12 14:06:10 -07:00
7886d24130
Fixing xml.js: Always throw XML I/O errors; Support parsing in Node ( #1911 )
...
* Improved Blockly.XML comments.
* Support JSDOM as an alternate parser under Node.js
* Throw standard errors instead of goog.asserts.
* Adding textToDomDocument_ and override in gulpfile.
2018-06-12 14:03:10 -07:00
2c84161b4a
Correct require goog.Timer statements. ( #1906 )
2018-06-06 15:57:53 -07:00
bae346963f
Remove custom touch handling code for dropdown fields
2018-06-06 12:34:28 -07:00
dc081e3677
Fixed typo ( #1899 )
...
Correct name in FieldButton member reference.
2018-06-06 10:42:19 -07:00
e9aae34388
Adaptive popup size for FieldDropdowns ( #1897 )
...
Replace the fixed dropdown height with one responsive to the document's viewport.
This is adapted from Bohdan-Tereta's proposed solution:
https://github.com/google/blockly/pull/1483#issuecomment-381638639
It is sub-optimal, in that is does not adapt to field height (variable
due to workspace zoom), and it does not fully utilize the space above
or below the field if the block is near the top or the bottom.
2018-05-31 16:37:09 -07:00
15817e78a1
Fix case where lack of colour attribute results in null. ( #1894 )
...
Fixes regression in #1893 . Patch on change in #1831 .
Verify typeof colour variable before passing through Number().
Missing attributes return null, and Number(null) === 0, resulting in a red hues category color.
2018-05-31 12:31:18 -07:00
c6b46d854a
Fix comment in dragged_connection_manager.js
2018-05-25 10:34:04 -07:00
e6a875bb02
Make event filtering stricter for events
2018-05-24 17:12:00 -07:00
68f8639da1
Merge pull request #1888 from rachel-fenichel/cleanup/stepObject
...
Create and use a Blockly.BlockSvg.PathObject type
2018-05-23 15:44:59 -07:00
73e6cf1265
Fix undoing a drag to connect
2018-05-23 14:56:41 -07:00
c1df1c647a
Create and use a Blockly.BlockSvg.PathObject type
2018-05-23 11:40:15 -07:00
206e22e88c
Decompose some render functions so they'll be easier to work with
2018-05-22 14:06:51 -07:00
98f838c0c3
Merge pull request #1878 from rachel-fenichel/bugfix/1380
...
Fix #1380
2018-05-21 16:11:29 -07:00
178473e989
Merge pull request #1885 from rachel-fenichel/bugfix/ws_comment_enable_ie
...
Disable ws comments in IE
2018-05-21 16:11:20 -07:00
629763e8ff
Add warning message for unrecognized toolbox colour value. (PR #1881 )
...
Fixes #1831
2018-05-21 15:44:46 -07:00
efd55e5d4f
Disable ws comments in IE
2018-05-21 15:12:09 -07:00
14e846f2b7
Fix 1380
2018-05-17 16:19:44 -07:00
3fea2a2eb4
Merge pull request #1875 from rachel-fenichel/fixes_from_scratch_blocks
...
Fixes from scratch blocks
2018-05-17 16:09:11 -07:00
85206993f6
Add a missing require and rebuild
2018-05-17 11:20:49 -07:00
df7f534ad6
Performance improvements for workspace clear and load
2018-05-17 11:05:18 -07:00
8ead7dabd8
Use .textContent setter for field text
2018-05-16 14:48:41 -07:00
f623004b3a
Small changes
2018-05-16 12:52:12 -07:00
9ab746e143
Another attempt at testing for PointerEvent. ( #1870 )
...
Advanced compilation error introduced in #1856 .
Now bypassing window altogether, by testing goog.global.PointerEvent directly.
2018-05-15 17:12:53 -07:00
1b9af8771f
Revised references to window to solve Node issues. ( #1856 )
2018-05-15 14:44:15 -07:00
93eb340b23
Update gesture.js
...
Make the code match the annotation (and all other uses of the variable)
2018-05-15 14:37:24 -07:00
RoboErikG
Neil Fraser
Andrew n marshall
Rachel Fenichel
Mark Gibson
Isabelle Taylor