Neil Fraser
76b5517008
Use null-prototype objects for maps
...
A {} has a bunch of names already defined on it (like ‘toString’). When using an object as a map with arbitrary keys, it should not inherit from Object.prototype.
2021-06-09 11:41:42 -07:00
Neil Fraser
d919b0af21
Update JSDoc from Array.<> to Array<>
...
Same with Object.
2021-05-27 21:30:26 -07:00
Neil Fraser
dd0314bc0b
Normalize comments
2021-05-19 09:57:14 -07:00
Maribeth Bottorff
ae33b64f4d
update event type in blockly developer tools ( #4731 )
2021-03-24 17:47:49 -07:00
Monica Kozbial
29b96d8d35
Fix ui event checks ( #4512 )
2020-12-08 16:21:52 -08:00
Monica Kozbial
40ef586260
Refactoring Ui events in core ( #4418 )
...
* Ui events base (#4370 )
* Add constants for new ui event types
* Add property to indicate an event as UI event
* Click events (#4372 )
* Creating new ui base class.
* Refactor theme event (#4391 )
* Add themeName property to theme event
* Refactor marker move events. (#4389 )
* Refactor trashcan open event (#4392 )
* Refactor selected event (#4387 )
* Refactor toolbox item change event (#4394 )
* Refactor bubble open events (#4390 )
* Refactor block drag event (#4388 )
* Viewport events (#4395 )
* Fix event filtering for ui events (#4401 )
* Move events to new directory and rename Ui events base (#4400 )
* Move events to new directory and rename Ui events base
* Add missing fromJson implementation for click event (#4410 )
* Adding serialization tests for events
* Zoom controls event (#4407 )
* Refactor zoom event
* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
Halit Anil Donmez
b48d3a6dd3
add new typed variable ( #4352 )
...
* add new typed variable
* add typed variables to the prompt message
2020-10-07 11:07:35 -07:00
alschmiedt
3d698f4bcc
Block factory fix ( #4327 )
2020-09-28 10:42:45 -07:00
Neil Fraser
4e2f8e6e02
Use SPDX licences.
...
This is a followup to #3127 .
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
4a94dc8a85
Unpack self-closing tags when converting domToText ( #3665 )
...
* Unpack self-closing tags when converting domToText
2020-01-27 15:32:12 -08:00
Sam El-Husseini
986e965be8
Private/protected visibility cleanup ( #3263 )
...
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
Neil Fraser
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
Neil Fraser
23caa12571
Error is a constructor, ‘new’ is not required.
2019-09-12 18:02:59 -07:00
Neil Fraser
b52de5cac2
Remove self-closing XML tags in workspace factory ( #2769 )
2019-08-15 10:20:49 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
52b6ce18a5
Fix unit tests
2019-07-08 13:29:43 -07:00
Neil Fraser
cbd944106c
Strip silly code
...
Sigh.
2019-06-26 13:55:55 -07:00
Neil Fraser
3a77a3d7ce
Define colours of standard categories by hue.
...
Previously they were defined in hex.
This meant that saturation and value were hardcoded.
This also resulted in off-by-one errors (Math was hardcoded as #5C68A6, but is calculated as #5B67A5) which in turn resulted in the colour not being highlighted in the picker.
2019-06-26 13:55:55 -07:00
Neil Fraser
ef28773a52
Enable selection of “no colour” on categories.
...
Near complete rewrite of colour picker for Blockly Factory.
* Drop IE6 support.
* Flip picker as needed so it doesn’t go offscreen.
* Add support for no colour.
* Factor CSS out of JS.
* Provide palette of our standard colours.
2019-06-26 13:55:55 -07:00
Neil Fraser
7e048f2e09
Remove last Closure from Block Factory.
...
Improves UI, but is still pretty clunky. For example there’s still not way to choose “no colour”.
Closes #668 .
2019-06-26 13:55:55 -07:00
Rachel Fenichel
6092e4c517
Calls to getAllBlocks should pass a value for _ordered_
2018-09-13 16:06:19 -07:00
Andrew n marshall
b4cfe263fa
Removing (most) Closure from BlockFactory ( #1925 )
...
Replacing all Closure goog. library calls from BlockFactory, with the exception of the ColorPicker and the test for the warning about running without Closure. This includes (almost) all goog.provide and goog.require statements.
2018-06-15 15:29:41 -07:00
Andrew n marshall
03538c19a7
Fix #1601
...
Correct deprecated argument order in domToWorksapce call in WorkspaceFactory.
2018-02-12 12:52:34 -08:00
Andrew n marshall
abcc9b82a1
Adding BlocklyDevTools.Analytics ( #1217 )
...
Adding BlocklyDevTools.Analytics, an interface for integrating an analytics
library to track basic usage, including:
* navigation.
* saving, importing, and exporting.
* warnings and errors.
2017-07-11 15:39:35 -07:00
marisaleung
aff9c4867c
Correctly named block events called.
2017-06-08 15:44:43 -07:00
Andrew n marshall
7e178af49c
Fix #950 : BlockFactory typo and copypasta
2017-02-23 08:53:01 -08:00
Neil Fraser
fbd9276e9c
Lint
2016-11-18 20:26:56 -08:00
Neil Fraser
f6aef459fc
API-breaking cleanup. But doubtful anyone will be affected. ( #748 )
...
* Make add/removeClass return whether they did anything.
* Move more functions onto utils.
* Move bind functions to Blockly.
* Routine recompile.
2016-11-15 13:54:33 -08:00
Neil Fraser
4f08f2536f
Replace category colour pallet with correctly calculated colours.
2016-10-23 01:05:13 -07:00
Neil Fraser
9fe29a9cc2
Block Factory: Add missing workspace options, fix reset button.
2016-10-17 17:32:14 -07:00
Neil Fraser
728284ab61
Disable options in readonly mode. (Block Factory)
2016-10-14 08:57:39 -07:00
Neil Fraser
ea1d0d7d3a
Add labels to Block Factory.
2016-10-14 07:47:23 -07:00
Neil Fraser
8b7ce77f8e
Rotate Block Factory colour picker 90deg for more room.
2016-10-14 07:29:41 -07:00
Neil Fraser
5e797c704c
Fix orphaned and overlapping menus in Block Factory.
2016-10-14 07:16:31 -07:00
Neil Fraser
5fc9e04b5c
Untangle modal buttons.
2016-10-14 06:57:21 -07:00
Neil Fraser
ff48285a86
Block factory cleanup. Fix one-based list option.
2016-10-13 20:18:44 -07:00
picklesrus
7c2016284a
Change label of block factory to blockly developer tools. Change the icon too. Also remove old, unneeded index.html file from workspacefactory directory. ( #694 )
2016-10-12 11:21:59 -07:00
Neil Fraser
941bdcd187
Remove a bunch of Closure from Block Factory.
2016-10-11 16:50:13 -07:00
Neil Fraser
5df55ddea0
Block(ly) Factory prompts should have defaults. Drop unused copy of colourpicker code.
2016-10-11 12:16:17 -07:00
picklesrus
c102734ccb
Replace Block Factory with Blockly Factory. Save Block Factory in blockfactory_old for safety. ( #691 )
...
Keep icon.png and blocks.js back into blockfactory rather than pointing to blockfactory_old.
2016-10-11 11:25:07 -07:00