Beka Westberg
13bb9f5bf6
Refactor connect logic ( #4880 )
...
* Refactor connect logic.
* Fixup from rebase
* Fix build
* PR Comments
2021-06-18 09:53:43 -07:00
Monica Kozbial
6f7ead6e9c
Fix error caused by extra teardown call ( #4877 )
2021-06-08 10:19:08 -07:00
Beka Westberg
ab5616cff7
Add tests for connecting blocks ( #4853 )
2021-06-07 08:14:13 -07:00
Beka Westberg
5ffd43824f
Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 ( #4851 )
...
* Change lastConnectionInRow to getPlaceForOrphanedOutput
* PR comments
2021-05-26 09:16:33 -07:00
Beka Westberg
c732484180
Add programmatically setting shadows Take 2 ( #4215 )
...
* Add programmatically setting shadows
2020-09-08 08:50:01 -07:00
Monica Kozbial
49e0ff4318
Handle testing deprecated methods. ( #4195 )
...
* Handle testing deprecated methods.
2020-08-19 17:53:49 -07:00
Monica Kozbial
2e92123314
Adding async cleanup to tests ( #4103 )
...
* Adding setup and teardown to more mocha tests.
* Update workspace dispose cleanup calls.
2020-08-05 16:00:00 -07:00
Rachel Fenichel
bc0f54b769
Fix tests
2020-07-16 17:40:13 -06:00
Rachel Fenichel
3322834a9b
Add deprecation warnings and tests
2020-07-16 17:40:13 -06:00
Rachel Fenichel
7288c66294
Rename connectionTypeChecker->connectionChecker
2020-07-16 17:40:13 -06:00
Rachel Fenichel
e24f3cef9b
Add isDragging to canConnectWithReason and delete newly unused code paths.
2020-07-16 17:40:13 -06:00
Rachel Fenichel
450aed0aa2
More work on connection type checks
2020-07-16 17:40:12 -06:00
Rachel Fenichel
8c17e325b5
Update connection tests to directly use the type checker
2020-07-16 17:40:12 -06:00
Sam El-Husseini
c9563c1d24
Revert "Add programmatically setting shadows ( #3902 )"
...
This reverts commit 3aa1963be8
2020-06-12 08:54:04 -07:00
Beka Westberg
3aa1963be8
Add programmatically setting shadows ( #3902 )
...
* Add programmatically setting shadows
2020-05-21 11:44:08 -07:00
Neil Fraser
4e2f8e6e02
Use SPDX licences.
...
This is a followup to #3127 .
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
52bef4463c
Fix warnings related to connections. ( #3306 )
...
* Fix warnings related to connections.
2019-10-23 17:56:52 -04:00
alschmiedt
cf04a9529b
Fix compilier warnings for keyboard nav ( #3196 )
...
* Fix compilier warnings for keyboard nav
2019-10-08 11:34:39 -07:00
Neil Fraser
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
Beka Westberg
afbb2cca1e
Moved all database related code out of headless and into rendered.
2019-09-27 18:00:06 -07:00
Beka Westberg
1baf7d1dcf
Added a bunch of connection related tests.
2019-09-27 15:56:29 -07:00
Rachel Fenichel
269f0dc381
Enable eslint rule spaced-comment
...
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
Beka Westberg
654467e9ac
Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse.
2019-08-07 07:17:41 -07:00
Beka Westberg
b28788fad6
Added licenses to tests and changed some formatting.
2019-08-07 07:07:30 -07:00
Rachel Fenichel
16f0992764
Enable operator-linebreak rule
2019-07-31 09:45:27 -07:00
Erik Pasternak
5911e54dc0
Revert "Propagate the visible state when blocks connect ( #2003 )"
...
This reverts commit ec78eeb39b
2019-07-19 16:03:40 -07:00
Beka Westberg
148823146d
Fixed lint errors
2019-04-22 10:55:36 -07:00
RoboErikG
ec78eeb39b
Propagate the visible state when blocks connect ( #2003 )
...
* Propagate the visible state when blocks connect
This fixes #1967 .
In rendered connections when connecting:
- If the superior connection is hidden this hides the newly connected block.
- If the superior connection isn't hidden it makes sure the block is visible.
In rendered connections when disconnecting:
- If the superior connection is hidden, make the disconnected block stack visible.
TODO before review:
- write tests.
- update collapsed message
* Add missing overrides
* Add tests for hidden connections and fix a bug while disposing
2019-04-15 16:23:19 -07:00
