Commit Graph

1164 Commits

Author SHA1 Message Date
Rachel Fenichel
f3a4664dea Delete extra variables at the end of a procedure argument edit 2018-02-15 17:18:23 -08:00
Neil Fraser
73417b8317 Reduce size of XML by omitting empty variable tag. 2018-02-14 11:22:55 -08:00
Mark Gibson
54f0e06e21 Customising field types using a register of fields #1584 (#1594)
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Andrew n marshall
e1e3f273d2 Remove forceRerender() from FieldDropDown.
Errantly forced whole block to rerender, including fields that
had not yet been initialized.

Fixes #1609
2018-02-13 15:01:33 -08:00
Rachel Fenichel
5e0928e4f3 Break circular dependency 2018-02-13 10:44:07 -08:00
Rachel Fenichel
3463799d83 Merge pull request #1599 from rachel-fenichel/bugfix/sb-1373
Don't allow block deletion in the flyout.  Make copy-paste always copy to the main workspace
2018-02-12 14:43:40 -08:00
Andrew n marshall
dc7783ee01 Warn conflicts with Blockly.Generator.prototype (#1603)
Console warning if block prototypeName conflicts with Blockly.Generator.prototype.
2018-02-12 13:44:54 -08:00
Rachel Fenichel
f471a23b2b Add comment 2018-02-12 13:25:07 -08:00
Rachel Fenichel
57852f0249 Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace. 2018-02-08 17:23:22 -08:00
Rachel Fenichel
6a018515af Make WorkspaceSvg.refreshToolboxSelection_ package instead of private 2018-02-08 16:45:19 -08:00
Rachel Fenichel
e58c8a32d4 Merge pull request #1590 from rachel-fenichel/feature/bubble_dragger
Create a Dragger for moving bubbles around
2018-02-07 14:19:23 -08:00
Mark Gibson
2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson
6ab7cd25f5 Missing semi-colon! 2018-02-07 12:44:01 +00:00
Mark Gibson
d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel
9d2cb829a9 Move code into the bubble dragger where possible 2018-02-06 18:56:26 -08:00
Rachel Fenichel
7acd4133aa Remove unused code in the bubble dragger. 2018-02-06 18:07:21 -08:00
Rachel Fenichel
68914be67d Wire up bubble dragging, with coordinate problems 2018-02-05 16:57:44 -08:00
Rachel Fenichel
3b168f5370 Fix #1538 2018-01-26 15:20:19 -08:00
Rachel Fenichel
870219e750 Get rid of the last indentation lint (that is checked by eslint) and turn indentation back to erroring instead of warning. 2018-01-25 17:33:43 -08:00
Rachel Fenichel
f19d7a811c Merge pull request #1562 from rachel-fenichel/bugfix/matching_names
Fix #1559
2018-01-25 17:08:46 -08:00
Rachel Fenichel
68ff863ea9 Fix indentation 2018-01-25 13:00:08 -08:00
Rachel Fenichel
cb75946a3c Set indent problems to warnings, and fix all errors. 2018-01-25 12:43:11 -08:00
Rachel Fenichel
794520e225 Add documentation 2018-01-24 17:17:31 -08:00
Rachel Fenichel
96e2d7d102 Fix #1559 2018-01-24 17:05:58 -08:00
Rachel Fenichel
c6881677ad Merge pull request #1561 from rachel-fenichel/cleanup/lint
Indentation lint that blocks moving to eslint 4.0
2018-01-24 16:48:18 -08:00
Rachel Fenichel
2b7b4bf3af More lint 2018-01-24 16:40:07 -08:00
Rachel Fenichel
3e62ffc20a Split at higher level for multiline function calls 2018-01-24 11:26:41 -08:00
Rachel Fenichel
799148da7e More spaces 2018-01-24 10:22:13 -08:00
Andrew n marshall
36993430e1 createVariable(..) => createVariableButtonHandler(..)
Clarifying the role of Blockly.Variables.createVariableButtonHandler(..).
Updating documentation a making sure it (and its deprecated previous name)
are properly exported.
2018-01-24 09:54:21 -08:00
Rachel Fenichel
3575d53018 57 errors remaining 2018-01-23 18:42:45 -08:00
Rachel Fenichel
fb897d7786 Even more lint. 90 errors remaining. 2018-01-23 18:33:30 -08:00
Rachel Fenichel
9a53e96d53 More lint fixes 2018-01-23 18:22:53 -08:00
Rachel Fenichel
1e3450a051 Indentation lint that blocks moving to eslint 4.0 2018-01-23 17:27:35 -08:00
Rachel Fenichel
e61b51afcb Merge pull request #1546 from rachel-fenichel/bugfix/1499
Fix #1499 and add some validation
2018-01-22 17:54:11 -08:00
Rachel Fenichel
06ae9ade8e Don't update the field until all checks pass 2018-01-19 15:49:39 -08:00
Andrew n marshall
0d085c27b2 Removing Events.disable()/.enable() from disableOrphans.
Tested in Blockly Games and BlockFactory. Tests also pass.
2018-01-19 10:40:18 -08:00
Rachel Fenichel
e648f11e2d Make another function public 2018-01-18 15:59:26 -08:00
Rachel Fenichel
5cd6a51197 Make some functions public 2018-01-18 15:35:59 -08:00
Rachel Fenichel
7314bdfb3a Fix #1499 and add some validation 2018-01-17 16:54:12 -08:00
Rachel Fenichel
68cee9da42 Fix #1539 2018-01-17 11:19:38 -08:00
Rachel Fenichel
3f61f71f35 Merge pull request #1531 from google/variables_by_id
Variables by ID
2018-01-16 17:54:55 -08:00
Rachel Fenichel
fa91c6b36f Make some functions package 2018-01-16 12:41:52 -08:00
Rachel Fenichel
b593d44379 Make the potential variable map null when not needed 2018-01-12 14:51:02 -08:00
Rachel Fenichel
a30ad6ff3a More code cleanup for review 2018-01-12 13:28:17 -08:00
microsoftsam
4b064da8e8 Support pinch to zoom gesture for both touch and pointer events 2018-01-11 11:26:42 -08:00
Rachel Fenichel
80b397f532 Respond to more review comments 2018-01-10 17:27:43 -08:00
Rachel Fenichel
a43b0e7010 Respond to commit comments and make compressed blockly work again 2018-01-10 17:02:02 -08:00
Rachel Fenichel
bd4e4daebb Update comments and use try/catch with setGroup. 2018-01-09 13:31:13 -08:00
Neil Fraser
870f7b7f8a Fix document detection.
Andrew LGTMs in person.
2018-01-08 15:10:14 -08:00
Rachel Fenichel
5d6d7519cd Remove some TODOs; add a variable-referencing block to the simple playground flyout 2018-01-08 14:14:26 -08:00