Commit Graph

1551 Commits

Author SHA1 Message Date
alschmiedt
dcbac91ba3 Merge pull request #2360 from alschmiedt/Bump_RTL
Fixes bumping too much when in RTL
2019-04-04 16:26:14 -07:00
alschmiedt
a759fffcc1 Fixes bumping too much when in RTL 2019-04-04 15:54:17 -07:00
alschmiedt
124a8f1e40 Merge pull request #2359 from alschmiedt/Hide_chaff_bug
Hides chaff on document mouseup
2019-04-04 14:08:55 -07:00
alschmiedt
db7a87555f Hides chaff on document mouseup 2019-04-04 11:24:22 -07:00
Tiara Tan
e79dcecb22 Rename WorkspaceSvg.getFlyout_ (#2357) 2019-04-03 14:22:42 -07:00
alschmiedt
380d05dd08 Merge pull request #2355 from alschmiedt/unplug_fix
Adds check for a targetConnection
2019-04-02 17:18:07 -07:00
alschmiedt
1034ba835c Adds check for a targetConnection 2019-04-02 14:42:41 -07:00
RoboErikG
1a2cf96a5a Update selected menu sizing to fix #2351 (#2353) 2019-04-01 12:43:19 -07:00
Neil Fraser
767495cf76 Don’t drop newValue from bubble open events. 2019-04-01 11:15:46 -07:00
Neil Fraser
f118d33855 Corrections to JSDoc comments 2019-03-29 15:24:37 -07:00
Neil Fraser
51bfa9455d More comprehensive approach to gesture detection.
Search all workspaces.  The flaw with looking at the workspace of the selected block is that dragging a workspace is a gesture but has no selected block.
2019-03-29 15:24:37 -07:00
Neil Fraser
e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Neil Fraser
68e134b073 No keyboard access to quarks during drag.
Same issue as zooming with the mouse wheel.
2019-03-29 15:24:37 -07:00
Neil Fraser
6862a7fe70 Use hashes instead of objects. 2019-03-29 15:24:37 -07:00
Neil Fraser
45e24c2b98 No need to check non-null before nullifying 2019-03-29 15:24:37 -07:00
Neil Fraser
6fb95f9038 Consistent speling. 2019-03-29 15:24:37 -07:00
Neil Fraser
87385b0721 Make drag detection more robust.
Previously, one could drag (and hold) a quark outside the bounds of a mutator bubble, then scroll, and the old code wouldn’t query the mutator for gestures.
2019-03-29 15:24:37 -07:00
Neil Fraser
46a4f33e4e Fix JSDoc 2019-03-29 15:24:37 -07:00
Neil Fraser
d6096accca Remove Blockly.WidgetDiv.position
Nobody appears to call it.
2019-03-29 15:24:37 -07:00
Neil Fraser
2fd931cab9 Add comment regarding async nature of listening. 2019-03-29 15:24:37 -07:00
Neil Fraser
50519413d0 Line length 2019-03-29 15:24:37 -07:00
Beka Westberg
5b25843b98 Fixed trashcan flyout positioning. 2019-03-29 08:19:24 -07:00
Neil Fraser
405b1e4e78 Lint issues found while debugging. 2019-03-27 15:47:29 -07:00
Neil Fraser
dbafdcf1ff Prevent gestures from being broken by zoom/scroll. 2019-03-27 15:47:29 -07:00
alschmiedt
bf45c85bf1 Add private annotation 2019-03-22 10:14:43 -07:00
alschmiedt
b6b7ab0091 Refactor setTheme 2019-03-22 09:54:52 -07:00
alschmiedt
5c18e102ca Fixed setTheme so it doesn't error when no workspace is created 2019-03-21 15:32:18 -07:00
Beka Westberg
e947471215 Fixed updateToolbox not properly updating flyouts. (#2332) 2019-03-19 15:48:52 -07:00
alschmiedt
715fdde945 Reverts changes to fix bug with selecting dropdown 2019-03-12 10:39:09 -07:00
amber-cd
c2f30d4ca6 Update toolbox.js
Changed style attribute to categorystyle.
2019-03-05 08:39:20 -05:00
Rachel Fenichel
47fff5cddb Merge pull request #2313 from rachel-fenichel/feature/dropdowndiv
Add dropdowndiv and use it for the colour picker and angle fields
2019-03-01 12:54:39 -08:00
Rachel Fenichel
e20a7ef3c2 Use constants for dropdown div colours in the colour field 2019-03-01 12:38:37 -08:00
Rachel Fenichel
fd8865bda6 Merge pull request #2311 from BeksOmega/fixes/AbsoluteMetrics
Changed Absolute Metrics to Avoid Simple Toolboxes
2019-03-01 11:01:50 -08:00
Rachel Fenichel
c43988873e Don't try to bump if the object has already been deleted. 2019-02-28 17:32:55 -08:00
Beka Westberg
d0559a5eeb Fixed scroll event binding to work with multiple workspaces. 2019-02-28 15:43:52 -08:00
Rachel Fenichel
0b1bd78674 Clarify some dropdown rendering code 2019-02-28 15:11:57 -08:00
Beka Westberg
e0673faf41 Added event filtering to workspaceChanged in mutator. (#2320) 2019-02-27 16:06:37 -08:00
Beka Westberg
168ee80b05 Removed console log. 2019-02-26 16:37:56 -08:00
Beka Westberg
69718f2fd4 Removed accessing private flyout.width_ variable. 2019-02-26 16:33:18 -08:00
Rachel Fenichel
1546f56308 Add click target property to fields, with accessor 2019-02-26 16:23:21 -08:00
Rachel Fenichel
dfc74b8c4f Use dropdownDiv for the angle field as well 2019-02-26 14:54:21 -08:00
Rachel Fenichel
58027b9668 css cleanup 2019-02-26 11:10:55 -08:00
Rachel Fenichel
4f3bb673ef Add require and rebuild for travis 2019-02-26 11:05:27 -08:00
Rachel Fenichel
2c624c5144 Use dropdowndiv for field colour but not field dropdown 2019-02-26 11:03:28 -08:00
Beka Westberg
a0aa84d861 Changed absolute metrics to avoid simple toolboxes. 2019-02-23 14:34:26 -08:00
Rachel Fenichel
d7e47c66b2 Merge pull request #2286 from BeksOmega/fixes/AddHideChaffToDocument
Fixes Block Input Sticking to the Screen When Navigated Away
2019-02-22 14:19:11 -08:00
Rachel Fenichel
351202d7c5 Merge pull request #2306 from BeksOmega/fixes/ScrollConstants
Added Scroll deltaMode Multiplier Constants
2019-02-22 14:18:15 -08:00
Bluefox
e84a740d3d Fix error by init of dropdown in case the value is "" (#2308)
I have following dropdown options

```
[
    ["no matter", ""]
    ["Update", "true"]
    ["Command", "false"]
]
```
In case my value is "" the text is not filled with "no matter" by the initial draw and the empty selector is shown. I expect the text "no matter"

This PR fixes that
2019-02-22 10:02:14 -08:00
Beka Westberg
7e3bff2552 Readded the toolbox click subscriber. Added preventing propagation to the toolbox click subscriber. Added clearing touch identifier to the document click subscriber. 2019-02-21 14:57:19 -08:00
Rachel Fenichel
c426aad387 Use dropdown div for dropdowns 2019-02-21 13:41:45 -08:00