Commit Graph

180 Commits

Author SHA1 Message Date
Monica Kozbial
e2b510662c Fixing typo on "programmatically". (#3654) 2020-01-24 15:10:22 -08:00
Sam El-Husseini
20e55b67d7 Fix bug with dropdown menu propagating the opening click event to a menu item (#3570)
* Prevent dropdown field menu from propagating a click event onto a menu item when the dropdown appears above the field
2020-01-09 18:08:29 -08:00
Sam El-Husseini
f06d7b3cfd Fix scrolled text input widgetdiv positioning. (#3533)
* Fix scrolled text input widgetdiv positioning.

* Fix dropdown div bounds element when scrolled.
2020-01-02 17:19:32 -08:00
Sam El-Husseini
63f7af115c [zelos] Set field rect background colour (#3500)
* More consistent field rect colour in zelos. Only overriding in full block fields. Fix disabled block colours.

* Use a better constant name and fix build.
2019-12-10 08:31:43 -08:00
Sam El-Husseini
917f58ab0f Fix bugs with apply colour (#3483) 2019-12-03 13:22:41 -08:00
Sam El-Husseini
9fcc532977 [zelos] Cross browser pixel perfect text input (#3466)
* Align text and widget div text input pixel perfect on all browsers
2019-11-25 15:54:24 -08:00
Sam El-Husseini
139382e009 Field textinput pixel perfect input (#3443)
* Fix sizing of text input field in zelos, pixel perfect input in other browsers
2019-11-14 16:13:22 -08:00
Sam El-Husseini
09f6b792a6 Move field border radius into a constant (#3434)
* Move field border radius into a constant

* Drop const.
2019-11-13 17:22:21 -08:00
Sam El-Husseini
2dea7038d5 Moves field layout constants into the renderer (#3437)
* Add field constants into renderer constants
2019-11-13 16:41:35 -08:00
Rachel Fenichel
939bafddd8 Merge branch 'develop' into single_field_blocks 2019-11-12 11:52:03 -08:00
Rachel Fenichel
9d6f4c8177 Fix types and review comments 2019-11-12 11:50:34 -08:00
Sam El-Husseini
95f2b232b9 Field constants (#3423)
* Move field text sizing constants to renderer constants
2019-11-11 16:13:50 -08:00
Rachel Fenichel
5f4a308a40 Full-block editors for single-field reporters. 2019-11-11 14:32:31 -08:00
Sam El-Husseini
ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Rachel Fenichel
85c4db5a10 First pass at colourers 2019-10-30 14:42:13 -07:00
Sam El-Husseini
7d174727b0 Fix warnings for code used by blocks (#3362) 2019-10-30 08:11:18 -07:00
Sam El-Husseini
649dc116ed Using a HTML canvas for computing the text width (#3000)
* Use a helper HTML canvas element to measure text width for better performance
2019-10-24 13:02:32 -04:00
Sam El-Husseini
8eba82b906 Fix 4 misc warnings (#3283) 2019-10-17 16:52:52 -05:00
Sam El-Husseini
a5a4e5161c Fix 11 warnings related to block_svg (#3276)
* Fix 11 warnings related to block_svg
2019-10-17 16:30:48 -05:00
Sam El-Husseini
2224bb2a4e More field dispose (#3201)
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Sam El-Husseini
4b35320c86 Fix #2811 (#3205) 2019-10-09 10:10:12 -07:00
RoboErikG
663809297d Set correct defaults for Fields (#3179)
null was being converted to 0 by Number() when it should cause the
default value to be set instead. This updates FieldNumber and
FieldAngle to handle nulls correctly. Also update jsdoc.

Fixes #3177
2019-10-07 11:38:32 -07:00
Sam El-Husseini
d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Rachel Fenichel
79bedca5a7 Element -> SVGElement (#3140)
* Use SVGElement instead of Element for the results of createSvgElement

* More SVGElement annotations.
2019-10-02 16:12:31 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
494487b37f Mark fields as dirty when the workspace becomes visible. (#3072)
* Mark fields as dirty when the workspace becomes visible.
2019-09-23 11:21:45 -07:00
Sam El-Husseini
8fae0411f7 Check if a type exists before testing instanceof (#3031)
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
alschmiedt
2c98ecaed6 Update APIs and Add New Cursor Look (#3009)
* Updates methods to be private in navigation.js

* Update cursor with new look
2019-09-16 12:33:43 -07:00
Neil Fraser
23caa12571 Error is a constructor, ‘new’ is not required. 2019-09-12 18:02:59 -07:00
Sam El-Husseini
f3f3329355 Fix configure method (#2915)
* Fix configure method.
2019-09-12 17:01:03 -07:00
Rachel Fenichel
6f4476c962 Textarea Field, Multiline Block (from acbart) (#2663)
* Field Textarea, text_multiline block, generators
2019-09-11 17:57:46 -07:00
Sam El-Husseini
f23b659898 Remove this.text_ (#2910)
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
Beka Westberg
23e0733f21 Changed field and colour constructors to use better organization. (#2900) 2019-08-23 10:54:44 -07:00
Beka Westberg
a3642baf5c Updated TODOs with issue numbers. 2019-08-20 12:52:28 -07:00
Beka Westberg
4f411d2859 Added handling of dynamic functions passed to opt_config. 2019-08-18 07:54:54 -07:00
Beka Westberg
1e73f69cea Changed abstract field to new configuration paradigm. 2019-08-18 07:54:54 -07:00
Beka Westberg
cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
alschmiedt
9b3e05e3d9 Field accessibility (#2823)
* Gives fields a chance to handle keyboard events
2019-08-15 15:44:54 -07:00
Sam El-Husseini
5ada490eca Cherry pick npm distribution change to develop (#2785) 2019-08-07 10:53:53 -07:00
Beka Westberg
654467e9ac Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse. 2019-08-07 07:17:41 -07:00
Sam El-Husseini
f34f2beac7 Remove all calls to goog.style (#2781)
* Remove dependency on goog.style
2019-08-06 14:54:13 -07:00
Rachel Fenichel
ed245a3c9e Remove dealWithOffsetFields 2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00
Rachel Fenichel
3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
Neil Fraser
45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Rachel Fenichel
08982ce55e Merge pull request #2668 from BeksOmega/fixes/DeprecateSetText
Deprecated Field.setText
2019-07-26 13:02:35 -07:00
Sam El-Husseini
c1b49a1da7 Fix some jsdoc types (#2701)
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
Abby
3dd1973a5a Ran the rename script 2019-07-24 13:48:25 -07:00
Abby
1c26b6d79b Adds helper functions for keyboard nav 2019-07-24 11:42:37 -07:00