alschmiedt
cbf867f441
Add keyboard navigation support for multiple workspaces ( #3352 )
...
* Add keyboard navigation support for multiple workspaces
2019-10-28 12:53:51 -07:00
Monica Kozbial
17af987de0
Adding pinch zoom config option. ( #3317 )
...
* Adding pinch zoom config option.
2019-10-25 16:45:55 -07:00
Sam El-Husseini
759875a6c0
Resolve remaining compiler type warnings ( #3334 )
...
* Resolve remaining compiler warnings with inconsistent types.
2019-10-25 19:07:17 -04:00
Sam El-Husseini
bfe62f98ca
Dispose makes the types we use inconsistent. Suppress checkTypes in dispose. ( #3336 )
2019-10-24 15:47:42 -04:00
Sam El-Husseini
270781113d
Fix warnings related to gestures and drag. ( #3307 )
...
* Fix warnings related to gestures and drag.
2019-10-22 14:21:00 -04:00
Sam El-Husseini
4f02ceeba0
Make Blockly options an interface ( #3312 )
...
* Make workspace options an interface so it can be extended in the d.ts.
2019-10-22 14:20:26 -04:00
Sam El-Husseini
36d7e4ff8c
Suppress workspace comment module not included while Workspace comments are not bundled in. ( #3303 )
2019-10-22 08:49:17 -04:00
Sam El-Husseini
a5a4e5161c
Fix 11 warnings related to block_svg ( #3276 )
...
* Fix 11 warnings related to block_svg
2019-10-17 16:30:48 -05:00
Sam El-Husseini
e07a3f03a9
Fix 14 warnings related to workspace svg ( #3273 )
...
* Fix warnings related to workspace svg
2019-10-17 15:06:22 -05:00
Beka Westberg
8407428e8f
Reverted scrollbar resize change. ( #3274 )
2019-10-16 16:54:47 -05:00
Sam El-Husseini
3c2c4677df
Fix 55 warnings related to flyouts. ( #3211 )
...
* Fix 55 warnings related to flyouts.
2019-10-16 12:13:37 -05:00
Sam El-Husseini
986e965be8
Private/protected visibility cleanup ( #3263 )
...
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
alschmiedt
cf04a9529b
Fix compilier warnings for keyboard nav ( #3196 )
...
* Fix compilier warnings for keyboard nav
2019-10-08 11:34:39 -07:00
Sam El-Husseini
2ac4149d98
Misc compiler warnings. ( #3172 )
...
* Fix misc compiler warnings. Use ws.getToolbox() instead of ws.toolbox_
2019-10-07 11:06:56 -07:00
Rachel Fenichel
79c2fa6688
Make trashcan setOpen package and update a few annotations.
2019-10-03 18:08:27 -07:00
Rachel Fenichel
c5e691b88b
Update workspace_svg.js
2019-10-03 14:26:42 -07:00
Rachel Fenichel
78dc82f7ac
Misc cleanup: annotations, and flyoutButton disposal.
2019-10-03 10:40:43 -07:00
Rachel Fenichel
7ed47670cf
Remove block_render_svg
2019-10-02 16:21:36 -07:00
Neil Fraser
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
fc2c730e44
Make workspace comments an optional module, remove from this release. ( #3115 )
2019-09-27 11:15:11 -07:00
Neil Fraser
6650ecf13f
Make dynamic variables be an optional module.
...
Also straighten out some dependencies.
2019-09-27 10:48:14 -07:00
Sam El-Husseini
870824bc3e
Workspace theme ( #3093 )
...
* Move the theme object so it's on the workspace.
* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
Rachel Fenichel
269f0dc381
Enable eslint rule spaced-comment
...
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
Neil Fraser
a03660243e
Code cleanup, drop some CSS.
...
Random improvements to require statements.
Removal of some obviously dead CSS.
.blocklyDropDownDiv no longer supresses text selection (see comment in PR).
This PR drops the compiled size by 4 KB, which is larger than I was expecting.
2019-09-25 10:34:34 -07:00
Neil Fraser
ddb8e46b87
Make flyouts be optional modules.
...
No Blockly instances need both Horizontal and Vertical flyouts. Dropping one of these saves 2 KB. Some don’t need flyouts at all (e.g. Blockly Games Puzzle or readonly documentation blocks).
2019-09-23 22:02:59 -07:00
Neil Fraser
b84cda2c76
Strip out more bloat from toolbox ( #3068 )
...
Also removes three private accesses from workspaceSvg into toolbox tree.
The strategy for workspace.updateToolbox is no longer to clear and repopulate the toolbox, but rather to throw away the old toolbox and rebuild a new one. This is simpler and more reliable.
This commit trims off another KB from the compiled code.
2019-09-23 15:18:32 -07:00
Sam El-Husseini
494487b37f
Mark fields as dirty when the workspace becomes visible. ( #3072 )
...
* Mark fields as dirty when the workspace becomes visible.
2019-09-23 11:21:45 -07:00
Neil Fraser
b0e700307a
Quick hack to solve circular dependencies
...
Submitted without review since everything is broken. Further investigation needed to find origin of this regression.
2019-09-21 09:58:46 -07:00
Neil Fraser
56e7a46f45
Add more missing dependencies
...
Submitted without review. From this bug:
https://github.com/google/blockly-games/issues/116
2019-09-21 08:48:27 -07:00
alschmiedt
23b31c7ea8
Cursor rtl ( #3062 )
...
* Fix rtl for cursor svg & small bug fix
2019-09-20 14:34:18 -07:00
Neil Fraser
823c1c98a8
Make toolbox an optional module.
...
This drops the compiled size by 25 kb if there are no categories. Which also indicates that the toolbox itself suffers from really bad bloat. The toolbox should not represent 1/6th of our codebase.
2019-09-20 10:36:06 -07:00
kozbial
c533a0d943
Setting cursor and marker directly in Workspace and adding check to setCursor/setDrawer.
2019-09-19 10:38:23 -07:00
kozbial
3d06e7eb33
Creating cursordrawer in renderer.
2019-09-19 10:38:23 -07:00
Neil Fraser
ec34698c53
Make trashcan and zoomcontrols optional modules. ( #3043 )
...
Saves 6 KB when compiled if there is no trashcan nor zoomcontrols.
2019-09-18 15:55:12 -07:00
alschmiedt
2c98ecaed6
Update APIs and Add New Cursor Look ( #3009 )
...
* Updates methods to be private in navigation.js
* Update cursor with new look
2019-09-16 12:33:43 -07:00
Sam El-Husseini
e339ae26bc
Move the rendering object to live on the workspace_svg ( #3016 )
...
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini
fc420b7037
Support for registering renderers and switching between them ( #3013 )
...
* Added support for registering renderers and for choosing which renderer the workspace wants to use.
2019-09-13 10:30:20 -07:00
alschmiedt
ec07a36e44
Update cursor api ( #3002 )
...
* Move over to new implementation for cursor
2019-09-11 18:16:05 -07:00
Sam El-Husseini
8ab51c8639
Remove closure base file dependency ( #2976 )
...
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel
916ba8e5b8
Move rendering init call into workspace svg.
2019-08-23 13:36:56 -07:00
alschmiedt
00be6a6381
Make the navigation namespace lowercase ( #2812 )
2019-08-13 14:00:49 -07:00
RoboErikG
dac4ae2e78
Don't try to zoom flyouts and mutators ( #2772 )
...
* Don't try to zoom flyouts and mutators
Fixes #2752
Flyouts and mutator workspaces don't have enough info to handle
zooming correctly, so they were throwing errors if you pinched them.
This adds a check to quit a zoom early if in either of those. We
might want to revisit later if we should support zooming on them.
* Add TODO
2019-08-06 13:05:01 -07:00
alschmiedt
9466c6b7df
Move marker creation to the workspace ( #2742 )
...
* Move marker creation to the workspace
2019-07-31 09:04:53 -07:00
alschmiedt
62f4871e45
Fixes copy paste to work with the marker ( #2740 )
...
* Fixes copy paste to work with the marker
2019-07-31 07:49:02 -07:00
Sam El-Husseini
c1b49a1da7
Fix some jsdoc types ( #2701 )
...
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
alschmiedt
6dc9a07810
Integrates cursor into develop ( #2710 )
...
* Integrates cursor into blockly
* Fix review comments
* Add dispose to cursor
* Fixes dispose functionality
* Remove unnecessary dispose method
2019-07-25 11:14:40 -07:00
Neil Fraser
9f6c1c316a
Refactor workspace.connectionDBList
...
It seems wrong that Blockly.ConnectionDB.init reaches in to create a property on workspace.
It seems wrong that this database isn’t disposed of when the workspace is.
It seems unnecessary that disposed connections need to drop their reference *to* the workspace’s database since the connection object is going away anyway, and the databases aren’t.
2019-06-12 13:15:39 -07:00
Neil Fraser
b8cbd9e7df
Resolve 13 warnings
...
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
6d47853370
Fixed workspace scroll not properly hiding floating elements.
2019-06-11 13:32:10 -07:00
Neil Fraser
0213de11bc
Use Rect in more places.
2019-06-07 10:32:57 -07:00