CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity
3,803 Commits 106 Branches 106 Tags
e77a9b7e8102d3bae7f1dfe9a5722253f170a1bc
Commit Graph

105 Commits

Author SHA1 Message Date
Neil Fraser
e77a9b7e81 Change parseFloat() to Number() 
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number.  An audit of each case shows nowhere that parseFloat()’s features are needed.
 2019-08-01 11:36:58 -07:00
Neil Fraser
45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739) 
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
 2019-07-30 11:22:08 -07:00
Rachel Fenichel
c3eb0ed3c4 Merge pull request #2690 from rachel-fenichel/border_rect_default_height 
Define BORDER_RECT_DEFAULT_HEIGHT constant
 2019-07-23 16:21:10 -07:00
Rachel Fenichel
24866deae9 Use BORDER_RECT_DEFAULT_HEIGHT constant 2019-07-23 13:38:28 -07:00
Rachel Fenichel
71ef4b86b8 Merge pull request #2670 from BeksOmega/fixes/RemoveChangeListener 
Removed Useless Text Input Workspace Change Listener.
 2019-07-23 12:56:32 -07:00
Rachel Fenichel
fc4372dbc2 Add TODOs with github issue number 2019-07-22 16:29:44 -07:00
Beka Westberg
7e3344cf17 Removed useless text input workspace change listener. 2019-07-19 09:55:29 -07:00
Rachel Fenichel
f469a388ed Add getCorrectedSize functions to fields 2019-07-17 11:00:20 -07:00
alschmiedt
55fc506782 Merge pull request #2577 from BeksOmega/fixes/doValueInvalid 
Added Sending the Bad Value to doValueInvalid
 2019-06-24 16:09:20 -07:00
Beka Westberg
3227223c82 Renamed _newValue param to _invalidValue. 2019-06-24 14:58:33 -07:00
Beka Westberg
27a6593d27 Removed Class Option Check from Text Input fromJson (#2588) 
* Removed class option check from text input fromJson, as text input fields don't accept a class.

* Fixed syntax error.
 2019-06-24 13:34:28 -07:00
Beka Westberg
4a0d5f5df0 Added sending the bad value to doValueInvalid. 2019-06-14 12:00:10 -07:00
Neil Fraser
b8cbd9e7df Resolve 13 warnings 
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
 2019-06-12 10:59:33 -07:00
Beka Westberg
392119680e Fixed misc PR comments. 2019-06-11 13:32:10 -07:00
Beka Westberg
81035c3bcb Fixed unit tests. 2019-06-11 13:32:10 -07:00
Beka Westberg
303115953e Moved to #2125 disposal. Cleaned up some doc. 2019-06-11 13:32:09 -07:00
Beka Westberg
217206911a Fixed some formatting in text input. 2019-06-11 13:30:50 -07:00
Beka Westberg
0122f36450 Fixed field disposal, and reorganized editor creation. 2019-06-11 13:30:50 -07:00
Neil Fraser
a9fdf7844a Fix ordering of requires 
Search and replace of a name strikes again.
 2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba Alphabetize require statements. 
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
 2019-06-07 10:32:57 -07:00
Neil Fraser
566f182fa8 Move Blockly.userAgent to Blockly.utils.userAgent 2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8 Move utilities into own directory. 
TODO: There are more functions which may be migrated into dom and string.
 2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f Remove goog.math.Coordinate 2019-06-07 10:32:57 -07:00
Beka Westberg
f0d6fbd192 Reorganized field view initialization. 2019-05-31 10:38:18 -07:00
Beka Westberg
38f437a87e Fixed angle fields not displaying 0 when given an empty string. 2019-05-25 17:36:27 -07:00
Neil Fraser
9f528922a7 Fix some dependencies 2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb Refactored field validation. 2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5 Added Field Value Tests (#2459) 
* Added field value tests.

* Fixed field image src param.

* Fixed falsy values with label fields.

* Fixed falsy values with text input fields.

* Fixed some angle field tests.

* Fixed other text input when editing tests.

* Fixed colour tests.

* Cleaned up some number and variable field tests.

* Added angle field > 360 degrees tests.

* Fixed variable validator tests.

* Split setValue tests into sub-suites.

* Fixed angle >360 tests

* Changed var declarations to property declarations.
 2019-05-17 15:19:14 -07:00
Neil Fraser
28ad3a9bd3 Blockly.utils.userAgent moved to Blockly.userAgent 2019-05-10 16:56:26 -07:00
Neil Fraser
4062030731 Remove goog.userAgent dependency. 2019-05-10 14:03:21 -07:00
Beka Westberg
e8573bc0db Added isSerializable function and SERIALIZABLE property to fields. 2019-04-21 08:28:37 -07:00
Neil Fraser
e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Rachel Fenichel
dfc74b8c4f Use dropdownDiv for the angle field as well 2019-02-26 14:54:21 -08:00
alschmiedt
4bd21c5128 Added todo 2018-12-13 14:39:27 -08:00
alschmiedt
aae15f01f4 Groups events fired during field input change 2018-12-13 12:52:55 -08:00
Rachel Fenichel
d09c340c79 Mark some field properties protected 2018-09-11 16:19:34 -07:00
Andrew n marshall
7ee9b6bc3e Fix lint errors. 2018-08-28 11:21:21 -07:00
Neil Fraser
ac2fa96d7f Replace goog.dom.createDom for creating HTML 2018-07-11 12:20:02 -07:00
Neil Fraser
51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser
eea2794e38 Remove goog.dom.TagName 2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a Remove all goog.asserts and goog.isXxx 
First step to reducing Closure’s footprint.
 2018-07-11 12:20:02 -07:00
Neil Fraser
4cb4b42f8d Use named properties on Msg. 2018-04-27 11:50:51 -07:00
Rachel Fenichel
52e0241f66 Add argsIgnorePattern to the eslintrc 2018-04-06 13:29:22 -07:00
Rachel Fenichel
615c403b44 Use @nocompress annotation to fix advanced compilation. 2018-03-01 12:35:55 -08:00
Mark Gibson
54f0e06e21 Customising field types using a register of fields #1584 (#1594) 
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
 2018-02-14 10:14:59 -08:00
Mark Gibson
2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson
d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel
3e62ffc20a Split at higher level for multiline function calls 2018-01-24 11:26:41 -08:00