Commit Graph

571 Commits

Author SHA1 Message Date
Neil Fraser
dcc7de52a5 Merge branch 'master' into develop 2016-06-09 17:30:45 -07:00
picklesrus
1aecb78dd1 Fix issue #406 by calling resize from the keypress handler on text inputs. (#408) 2016-06-09 02:35:32 -07:00
Rodrigo Queiro
c09624a1b8 Remove reference to undefined variable (#413)
REASON_MUST_DISCONNECT was removed by a refactor in 2a1ffa1.
2016-06-08 10:01:04 -07:00
Neil Fraser
3012d52808 Line wrap comments in generated code. 2016-06-08 00:12:58 -07:00
Rodrigo Queiro
0585a667ec Fix typo in flyout.js (#402) 2016-06-07 09:54:57 -07:00
Rodrigo Queiro
736ff96ead Fix typo in flyout.js (#403) 2016-06-07 09:54:37 -07:00
Neil Fraser
9ca00656ad Properly deal with shadow statement blocks in stacks. 2016-06-05 16:58:27 -07:00
Neil Fraser
cf8ee673a9 Fix inheritance on rendered connection.
Closure compiler on maximum compression breaks badly due to lack of
@extends attribute.
2016-06-03 18:44:40 -07:00
Neil Fraser
a625d5b07c Fix unit tests. 2016-06-03 16:40:50 -07:00
Neil Fraser
57131165b0 Routine recompile 2016-06-03 16:12:59 -07:00
picklesrus
213469a479 Change the blockly workspace resizing strategy. (#386)
* Add a new method to be called when the contents of the workspace change and
the scrollbars need to be adjusted but the the chrome (trash, toolbox, etc)
are expected to stay in the same place.

Change a bunch of calls to svgResize to either be removed or call the new
method instead.  This is a nice performance win since the offsetHeight/Width
call in svgResize can be expensive, especially when called as often as we do -
there was some layout thrashing.

This also paves the way for moving calls to recordDeleteAreas
(which is also expensive) to a more cacheable spot than on every
mouse down/touch event.

of things (namely the scrollbars)

* Fix size of graph demo when it first loads by calling svgResize.
The graph starts with fixed width and was relying on a resize event
to fire (which I believe was removed in commit
217c681b86).

* Fix the resizing of the code demo.  The demo's tab min-width used to
match the toolbox's width was only being set on a resize event, but
commit 217c681b86 changed how that worked.

* Fix up some comments.

* Use specific workspaces rather than Blockly.getMainWorkspace().

* Make workspace required for resizeSvgContents and update
some calls to send real workspaces rather than ones that are
null.

Remove the private tag on terminateDrag_ because it is only
actually called from outside the BlockSvg object.

* Remove a rogue period.

* Recategorize BlockSvg.terminateDrag_ to @package instead of @private so that
other developers don't use it, but it still can be used by other Blockly classes.

* Add a TODO to fix issue #307.

* Add @package to workspace resizeContents.
2016-06-03 16:11:55 -07:00
rachel-fenichel
914b22789d Merge pull request #389 from rachel-fenichel/feature/render_move_connections
Move connections at the end of render, instead of in the middle of dr…
2016-06-01 15:32:41 -07:00
Rachel Fenichel
c3f27127d3 lint 2016-06-01 15:31:43 -07:00
Rachel Fenichel
66ca80c42f Make function private 2016-05-31 15:48:32 -07:00
Rachel Fenichel
03de6b6a92 Move connections at the end of render, instead of in the middle of drawing 2016-05-31 15:39:08 -07:00
Neil Fraser
a242c5d6e4 Stop context menu in context menu. Issue #372. 2016-05-29 15:59:46 -07:00
Neil Fraser
1db8092f15 Do not allow shadow blocks to have non-shadow children. 2016-05-29 14:53:29 -07:00
Neil Fraser
d6f84bff56 Do not allow importing of top-level shadow blocks. 2016-05-29 13:43:45 -07:00
Rachel Fenichel
5532e879eb Check for infinity with == in scrollbar 2016-05-27 10:38:41 -07:00
Rachel Fenichel
8afb04d9ee Move values to prototype and use coordinate. 2016-05-27 10:37:40 -07:00
Rachel Fenichel
06b9bb68e6 Rename knob to handle 2016-05-27 10:25:19 -07:00
Rachel Fenichel
5752913b4d Make some variables private and some functions public. 2016-05-26 15:22:24 -07:00
Rachel Fenichel
c80d3709e5 Merge branch 'develop' into cleanup/scrollbar_complications 2016-05-26 14:58:25 -07:00
Rachel Fenichel
f486ac949c use helper functions to set attribute on svg and in model at the same time. 2016-05-25 16:38:19 -07:00
Rachel Fenichel
4562ff8d74 Split scrollbar code into content changes and view changes; store dimensions in variables instead of querying the dom. 2016-05-25 16:20:20 -07:00
rachel-fenichel
e14e42192c Merge pull request #379 from rachel-fenichel/cleanup/more_lint
More lint and eslint configuration.
2016-05-25 15:36:03 -07:00
Rachel Fenichel
4841f136f1 More lint and eslint configuration. 2016-05-25 15:35:11 -07:00
rachel-fenichel
29234ea225 Merge pull request #380 from rachel-fenichel/cleanup/scrollbar_resize
Cache host metrics and make sure something has changed before resizin…
2016-05-25 14:10:05 -07:00
Rachel Fenichel
d6d34bf9ce Cache host metrics and make sure something has changed before resizing scrollbars. 2016-05-25 14:09:39 -07:00
Rachel Fenichel
6208ba62fb Rename a variable for clarity 2016-05-25 13:47:19 -07:00
Rachel Fenichel
8597c94a49 lint 2016-05-24 15:35:38 -07:00
Neil Fraser
0242238a44 Remove sound and animation on delete during undo/redo. 2016-05-21 06:14:33 -07:00
Neil Fraser
006bb36b89 Prevent sounds from playing on top of each other. 2016-05-21 05:55:24 -07:00
Neil Fraser
29e10e0976 Routine recompile. 2016-05-14 03:50:35 -07:00
Neil Fraser
46b1310743 Fix trashcan hotspot in RTL. 2016-05-14 03:44:37 -07:00
Neil Fraser
f162614cf1 Merge branch 'master' into develop 2016-05-14 03:13:13 -07:00
Neil Fraser
3355d3a133 Merge pull request #327 from miguel76/fix-init
Fix #326
2016-05-14 03:12:55 -07:00
Neil Fraser
15e1deacbd Merge branch 'master' into develop 2016-05-13 23:37:02 -07:00
rachel-fenichel
4de98b9f83 Merge pull request #291 from rachel-fenichel/feature/horizontal_toolbox_port
Horizontal toolbox layout with positioning at start or end.
2016-05-13 16:08:30 -07:00
Rachel Fenichel
f38b43419c Combine horizontal and vertical flyout scrolling 2016-05-13 16:07:53 -07:00
Rachel Fenichel
65aceaa1dc Fix docstrings and add horizontal scrolling. 2016-05-13 15:30:47 -07:00
Rachel Fenichel
cb4e9cd737 Fix mutator workspace in ltr 2016-05-13 15:06:06 -07:00
Rachel Fenichel
666536807a Add comments; scroll to start for always open flyout 2016-05-13 14:26:32 -07:00
Rachel Fenichel
71d3023a50 jsdoc 2016-05-12 13:24:08 -07:00
Rachel Fenichel
954b061e4a Merge branch 'develop' into feature/dragged_connection_list 2016-05-12 13:20:16 -07:00
Rodrigo Queiro
51d9981fe3 Fix typo in workspacetoCode 2016-05-11 16:52:51 -07:00
Rachel Fenichel
8cfd48554a clean up margins 2016-05-11 16:40:42 -07:00
Rachel Fenichel
e0cda58701 fix variable naming in createnewblock. 2016-05-11 15:15:12 -07:00
Rachel Fenichel
77a8b92ac2 Merge branch 'develop' into feature/horizontal_toolbox_port 2016-05-11 11:44:38 -07:00
Rachel Fenichel
e63f5aa01e Merge branch 'develop' into cleanup/rendered_connection 2016-05-10 17:03:54 -07:00