CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-06-17 00:25:14 +02:00
Code Issues Packages Projects Releases Wiki Activity
5,854 Commits 115 Branches 120 Tags
f94b1db85018b5a7261fa01f7d04cd5c8367fe2c
Commit Graph

868 Commits

Author SHA1 Message Date
Beka Westberg 13bb9f5bf6 Refactor connect logic (#4880) 
* Refactor connect logic.

* Fixup from rebase

* Fix build

* PR Comments
 2021-06-18 09:53:43 -07:00
Neil Fraser c8bea1ff3a Remove return value from Field dropdownCreate_ (#4915) 
These functions have side effects and set all kinds of private fields.  It is misleading for them to return the top-level element, for the caller to assign to a private field.
 2021-06-18 08:22:25 -07:00
Aaron Dodson 245a44b030 Merge pull request #4920 from gonfunko/capture-warning 
Use captureWarning helper from dev-tools instead of mocha/test_helpers.js implementation
 2021-06-17 16:04:23 -07:00
Monica Kozbial a15bbf1700 Revert #4697 (#4917) 2021-06-16 09:36:39 -07:00
jschanker 672574b056 Require field name to be string, test changes 
* Now throws error for getField/getFieldValue/setFieldValue if provided name is not a string
* Changed error to more specific TypeError
* Type checking and error message moved up to getField
* Tests added/modified to check that non-string types for field names produce type errors
 2021-06-16 10:46:05 +01:00
jschanker f9c5260fb0 Added tests/setFieldValue error message 
* Added tests for getting/setting field (values) when names are not supplied and test for getting a field value, setting it to a new value, and getting it again.
* Added more user-friendly error message for setFieldValue telling the developer that he/she is missing the name rather than Field "undefined" not found.
 2021-06-16 10:46:05 +01:00
Aaron Dodson 355c54f70a Use captureWarning helper from dev-tools instead of mocha/test_helpers.js implementation. 2021-06-15 19:10:13 +00:00
Aaron Dodson 5cd2d375ef Updated comment for runGeneratorsInBrowser to refer to Chrome instead of Firefox. 2021-06-14 19:06:28 +00:00
Aaron Dodson df7da795a3 Use selenium-standalone-service to automatically start and stop Selenium when running the test suite. 2021-06-14 11:52:49 -07:00
Christopher Allen f477db2251 Remove unneeded macOS setup 
Chrome comes pre-installed on GitHub hosted macOS runners, and while
`Xvfb` does not seem to be installed neither does it seem to be needed.
 2021-06-14 19:41:12 +01:00
Christopher Allen ab33cd567a Update test setup for GitHub Actions 
- Do the (hopefully now) correct test to check we are on macOS.
- Fix brew command-line syntax for installing google-chrome.
 2021-06-14 19:41:12 +01:00
Neil Fraser 96315ad449 Fix removal of spaces near parens inside strings 
Extra spaces should only be stripped from the inside of paren tokens.  Parens in strings (and other static content) should not be edited.
 2021-06-09 22:16:35 -07:00
Monica Kozbial 8e7cb406f9 Handle overriding components in ComponentManager (#4856) 2021-06-08 12:28:59 -07:00
Monica Kozbial 6f7ead6e9c Fix error caused by extra teardown call (#4877) 2021-06-08 10:19:08 -07:00
Beka Westberg ab5616cff7 Add tests for connecting blocks (#4853) 2021-06-07 08:14:13 -07:00
alschmiedt e4f15898d0 Update chrome version (#4866) 2021-06-03 17:57:40 -07:00
Neil Fraser 37a1ee55b8 Remove useless variable declarations in PHP. (#4849) 2021-05-27 21:40:04 -07:00
Neil Fraser a385f3c2a6 Enable extraction of names from name DB. 
Also gets rid of hacky name_realm contatination.
 2021-05-27 21:30:26 -07:00
Neil Fraser 2f2252f588 Rename variableDB_ to nameDB_ 
There is significant confusion in names and comments with regards to variables and procedures.  `Blockly.Generator.prototype.variableDB_` is a Blockly.Names database, not a variable map.  This rename introduces a getter and setter so deprecated references still work.  This commit also fixes some comments which are either outright wrong or misleading regarding variable and procedure names.
 2021-05-27 21:30:26 -07:00
Beka Westberg 5ffd43824f Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 (#4851) 
* Change lastConnectionInRow to getPlaceForOrphanedOutput

* PR comments
 2021-05-26 09:16:33 -07:00
Beka Westberg 9fbf06c5df PR Comments 2021-04-27 15:59:25 -07:00
Beka Westberg 43e95af14e Fix getDefinition being too restrictive 2021-04-25 14:46:51 -07:00
Monica Kozbial 5139057664 Merge consecutive viewport change events (#4792) 2021-04-23 10:56:52 -07:00
Sam El-Husseini d83279008b Remove dark theme in favour of @blockly/theme-dark (#4697) 
* Remove dark theme in favour of @blockly/theme-dark
 2021-04-21 13:33:59 -07:00
Rachel Fenichel e8d95c9137 Remove compile.sh 2021-04-13 14:28:54 -07:00
alschmiedt 91c060f872 Update metadata March 2021 (#4738) 2021-03-25 17:53:29 -07:00
Monica Kozbial 62dc2ff6fa Include oldCoordinate and oldContents in ws comment event serialization (#4718) 
* Include oldCoordinate and oldContent in ws comment event serialization
 2021-03-22 08:41:31 -07:00
Monica Kozbial 7eabb8e8a3 Update inccorect jsdoc in mocha tests (#4707) 2021-03-19 16:33:41 -07:00
alschmiedt 9a93ca486f Fix advanced compilation tests for Q1 2021 release (#4709) 2021-03-17 15:46:17 -07:00
alschmiedt c6b8791ece Update chrome driver version (#4710) 2021-03-17 12:56:10 -07:00
alschmiedt d58c80db76 Refactor flyout and toolbox metrics (#4648) 2021-03-15 12:37:23 -07:00
alschmiedt 869e4eb366 Update flyout metrics to work with the new metrics manager (#4684) 2021-03-09 17:09:49 -08:00
Sam El-Husseini 17d2e72ab0 Fix circular dependencies in shortcut + contextmenu registries (#4681) 
* Fix circular dependencies in shortcut and contextmenu registries
 2021-03-08 13:35:11 -08:00
Rachel Fenichel 855185c6cf Merge pull request #4682 from rachel-fenichel/toolbox_constants 
Use Blockly.utils.toolbox.Position enum everywhere
 2021-03-08 10:52:58 -08:00
Monica Kozbial f837f1e44e Add zoom support for single-direction-scroll (#4653) 
* Add zoom support for single-direction scroll
 2021-03-05 14:37:41 -08:00
Rachel Fenichel f7e0d5f4ea Use existing toolbox position enum 2021-03-05 14:16:43 -08:00
Rachel Fenichel 59084a043c TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc 2021-03-05 13:48:45 -08:00
Monica Kozbial 57749e6eb8 Updating bump logic to support single-direction scrollbars (#4652) 
* Updating bump logic to support single-direction scrollbars
 2021-03-01 12:20:12 -08:00
Rachel Fenichel 485e4cd505 Fix test 2021-02-26 11:25:10 -08:00
Rachel Fenichel 4e31deca2b Align constants -> Blockly.constants.ALIGN enum 2021-02-26 11:12:53 -08:00
alschmiedt 7b30cc76a4 Adds tests for metrics manager (#4635) 2021-02-18 13:45:53 -08:00
alschmiedt a8f28c6b11 Metrics refactor (#4627) 2021-02-10 16:19:56 -08:00
Beka Westberg 87f4799be7 Remove last FieldLabel call and fix adding dummy inputs to json (#4601) 
* Change insertFieldAt to use registry

* Fix adding dummy input for non field_ prefixed fields

* Remove bad new keyword

* Add type cast
 2021-02-05 16:03:32 -08:00
alschmiedt 26beff4b2c Migrate our tests to use github actions (#4614) 2021-02-02 10:08:51 -08:00
Beka Westberg 75f118b4f9 Refactor interpolate_ into multiple functions & remove direct new Field call (#4585) 
* Refactor interpolation

* Added docs

* Add tests

* Add test for dummy input after field not prefixed with field_

* Fix typings

* Pr comments
 2021-01-22 12:44:50 -08:00
alschmiedt a3adc42e8a Remove keyboard navigation from core (#4593) 2021-01-19 11:50:51 -08:00
Monica Kozbial 540ab16842 Fix serialization of workspace comment events and add tests (#4578) 
* Fix serialization of workspace comment events and add tests
 2021-01-11 16:14:34 -08:00
alschmiedt fe0f401977 Fix collapsing bug and add tests (#4568) 2021-01-11 09:05:59 -08:00
Fishuke 16979f7458 Fix misplaced percent sign in css, close iframe html tag (#4560) 2021-01-05 11:09:37 -08:00
alschmiedt be317617f9 Updates the metadata information (#4550) 2020-12-17 16:29:42 -08:00