Previously it returned x,y,width,height. Returning top,bottom,left,right results in simpler code, both in this function and in downstream callers.
This commit makes the minumum change to the metrics_test. I’m happy to change the test’s data if that makes more sense.
Replace individual .travis.yml commands and test_runner.js with tests/run_all_tests.sh, which manages the travis_fold statements and accumulating the output of all the test phases.
This script is now in charge of test_setup.sh (previously handled by npm pretest script). It also adds green/red color coding to each test section, based on success and failure.
* Changing root script for tests under Node.
Was: tests/jsunit/test_runner.js
Now: tests/test_runner.js
The webdriver & jsunit calls formerly in tests/jsunit/test_runner.js
are now in function runJsUnitTestsInBrowser, in
run_jsunit_tests_in_browser.js, called from tests/test_runner.js.
This makes room for additional tests under Node, such as headless and generator tests.
* Add skeleton for workspace comments
* XML parsing and encoding of workspace comments.
* Minor fix: piping the height and width from xml to newWorkspaceComment
* Move height and width into workspace_comment_svg
* rename newWorkspaceComment to newComment
* minor refactoring. PR changes
* Functions for managing the comment's lifecycle
* Add initial tests
* Add another test
* Add basic rendering of a comment.
* Cleanup remaining highlighting steps from render
* Fix lint
* Fix aslant
* Add basic comment translate
* Simplify render code into one setPath method
* Move steps to setPath_
* Remove svg elements when disposing of a comment; some code cleanup
* Add a workspace comment on context menu click and position it where the initial context menu was clicked.
* Minor rendering changes, fixes RTL. Fix positioning of new (context menu) comments while workspace is scaled.
* PR feedback
* Gesture code for dragging comments
* Add comment (block drag) surface methods
* minor comment fix
* Comment fixes
* Add comment dragger
* Making rendered private
* Require CommentDragger
* Make basic comment dragging work
* Increase the border around the comment to make a bigger drag handle
* Remove typo
* Allow comments to be selected. Highlight selected comment. Only edit comment on click. Updated comment rendering.
* minor refactor: remove commented out code
* PR comments
* lint and rebuild
* Fix renamed function call
* Fix workspace getMetrics by storing comment size as a number, not a string
* Enable comment deletion when dragging over the toolbox or trash can
* Give issue references to some todos
* Create a helper function for workspace comment creation
* Integrate sam's workspace comments, using the bubble dragger
* Remove comment_dragger references
* Remove comment dragger.js
* Remove pointer handling
* Fix lint
* Move comment XML functions into the comment files.
* Fix tests
* Fix type annotations
* Fix comments on comments
* Fix compiler errors related to visibility.
* Fix merge issues and add an issue number to a TODO
* Add a new message for default text on workspace comments, and rebuild
* Add support for a context menu on workspace comment showing delete and duplication options.
Add copy and paste support.
* PR comment feedback
* Show a delete icon on the comment when selected. Delete icon deletes the comment. Comment can be deleted if dragged onto the toolbox or the trash icon. A normal bubble cannot be deleted that way.
* use isDeletable instead
* Support drag of the comment during editing mode using the top handle.
* Add skeletons for all workspace comment events
* Rebuild with new comments
* Get rid of confused TODO
* JSDoc on a function
* Fix broken tests
* More PR feedback
* Fix lint
* Delete comment on mouse out, highlight on mouse down.
* Fix lint.
* Show delete hand cursor when dragging a comment to delete over the toolbox
* Focus textarea on select
* Add delete events
* Remove workspace comment create event, and add TODO placeholder
* Provide default values if comment height and width are missing in XML
* Set comment handle fill to none by default
* Rebuild
* Comment de/serialization should include location.
* Add comment move events, with undo and redo
* Add comment change events
* Move files up to core
* Add package/private annotations wherever possible
* Move the workspace comment events up to core and into a single file
* Mark things package or private where possible
* Get rid of unnecessary changes to messge files
* Fix lint
* Fix some review feedback
* Make changes to the comment db happen in addTopComment and removeTopComment
* Add css classes for toggling comment focus
* Clean up css for comment focus
* Rebuild
Neil Fraser
alschmiedt
Beka Westberg
Rachel Fenichel
alschmiedt
Neil Fraser
RoboErikG
Andrew n marshall