Rachel Fenichel
61db23c78a
Get rid of workspace.deleteVariable
2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b
Move getOrCreateVariable to variables.js
2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf
Fix default variable name
2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4
Make unique variable names in the flyout
2017-12-13 11:50:07 -08:00
Rachel Fenichel
523a10413b
All tests pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a
All but XML tests now pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
4d76f2948c
Move code from renameVariableInternal to renameVariableById
2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45
Update tests in workspace_test. Get rid of renameVariable
2017-12-13 11:50:07 -08:00
Rachel Fenichel
6974208fa3
Fix variable_map_test and variable_model_test
2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f
Fix tests in field_variable_test.js
2017-12-13 11:50:07 -08:00
Rachel Fenichel
012ba022c8
Delete by id
2017-12-13 11:50:07 -08:00
Rachel Fenichel
47457d1683
Fix renaming
2017-12-13 11:50:07 -08:00
Rachel Fenichel
c157412fc5
Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables
2017-12-13 11:50:07 -08:00
Rachel Fenichel
24462fbc91
Add TODOs and fix return type
2017-12-13 11:50:07 -08:00
Rachel Fenichel
779be46a92
Allow variables of different types to share the same name.
2017-12-13 11:50:07 -08:00
Rachel Fenichel
733a629f06
Merge pull request #1504 from areyeshot/develop
...
fix #1376
2017-12-13 09:41:40 -08:00
duzc2dtw@gmail.com
da429688f8
space between if and (
2017-12-13 17:02:34 +08:00
Neil Fraser
bc1a5baa48
Fixes to Generator tests ( #1510 )
...
* Remove unneeded report variable from generator tests.
* Fix missing message parameter in unittest_fail. This was a compile error in Dart.
* Fix indentation in PHP.
* Equality helper function not needed in PHP.
2017-12-12 17:38:38 -08:00
Rachel Fenichel
05351569c5
Fix html escaping and flyouts opening
2017-12-12 17:19:41 -08:00
Rachel Fenichel
9d71c972cb
Respond to review comments in variable_map
2017-12-12 17:19:41 -08:00
Rachel Fenichel
9f4b52a834
Clean up TODOs and move potential variable map to the flyout workspace
2017-12-12 17:19:41 -08:00
Rachel Fenichel
f0b4b4402c
Avoid spurious rename event
2017-12-12 17:19:41 -08:00
Rachel Fenichel
676253ec32
Fix missing events for variable creation
2017-12-12 17:19:41 -08:00
Rachel Fenichel
1491950394
Fix checkmarks when the variable dropdown is open.
2017-12-12 17:19:41 -08:00
Rachel Fenichel
464b2769a8
Tests
2017-12-12 17:19:41 -08:00
Rachel Fenichel
e7e66fb7b7
Tests
2017-12-12 17:19:41 -08:00
Rachel Fenichel
96e814deff
Fix events for variable renaming
2017-12-12 17:19:41 -08:00
Rachel Fenichel
3b91de7bb4
Remove ws.updateVariableStore and tests, and ws.getVariableUses
2017-12-12 17:19:41 -08:00
Rachel Fenichel
72e4be9b4e
Get rid of workspace.deleteVariable
2017-12-12 17:19:41 -08:00
Rachel Fenichel
9e0d908133
Move getOrCreateVariable to variables.js
2017-12-12 17:19:41 -08:00
Rachel Fenichel
f7438d9c95
Fix default variable name
2017-12-12 17:19:41 -08:00
Rachel Fenichel
7df7750b19
Make unique variable names in the flyout
2017-12-12 17:19:41 -08:00
Rachel Fenichel
2bb66aa9aa
All tests pass
2017-12-12 17:19:41 -08:00
Rachel Fenichel
f3f3f34fc2
All but XML tests now pass
2017-12-12 17:19:41 -08:00
Rachel Fenichel
a7b98f7479
Move code from renameVariableInternal to renameVariableById
2017-12-12 17:19:41 -08:00
Rachel Fenichel
62737bc233
Update tests in workspace_test. Get rid of renameVariable
2017-12-12 17:19:41 -08:00
Rachel Fenichel
5145ad6918
Fix variable_map_test and variable_model_test
2017-12-12 17:19:41 -08:00
Rachel Fenichel
c541a544c6
Fix tests in field_variable_test.js
2017-12-12 17:19:41 -08:00
Rachel Fenichel
0516310f66
Delete by id
2017-12-12 17:19:41 -08:00
Rachel Fenichel
08e065a75b
Fix renaming
2017-12-12 17:19:41 -08:00
Rachel Fenichel
745bed5ac3
Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables
2017-12-12 17:19:41 -08:00
Rachel Fenichel
731d2735c0
Add TODOs and fix return type
2017-12-12 17:19:41 -08:00
Rachel Fenichel
c825e60813
Allow variables of different types to share the same name.
2017-12-12 17:19:41 -08:00
Rachel Fenichel
0cb5dfc437
Merge pull request #1492 from Kenny2github/patch-1
...
Remove "fake some drags!"
2017-12-11 17:12:11 -08:00
Rachel Fenichel
4b3cac71e1
Merge pull request #1495 from rachel-fenichel/feature/variables_by_id
...
Act on variables by ID, not name + type
2017-12-11 15:47:37 -08:00
duzc2dtw@gmail.com
26ea42c264
#1376
2017-12-09 20:41:43 +08:00
Tianwei Du
0ce3963648
Merge pull request #2 from google/develop
...
Develop
2017-12-09 20:30:39 +08:00
RoboErikG
0142aa0e94
Don't require flyouts to run Blockly ( #1502 )
...
* Don't require flyouts to run Blockly
There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.
* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du
383f1d9bac
Develop ( #1501 )
...
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG
a83a625e3b
Rebuild core and fix indents in field_variable.js ( #1500 )
...
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
