mirror of
https://github.com/google/blockly.git
synced 2026-01-07 17:10:11 +01:00
## The basics - [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change) ## The details ### Resolves Fixes #8206 Fixes #8210 Fixes #8213 Fixes #8255 Fixes #8211 Fixes #8212 Fixes #8254 Fixes part of #9301 Fixes part of #9304 ### Proposed Changes This PR completes the remaining ARIA roles and properties needed for all core fields. Specifically: - #8206: A better name needed to be used for the checkbox value, plus there was an ARIA property missing for actually representing the checkbox state. The latter needed to be updated upon toggling the checkbox, as well. These changes bring checkbox fields in compliance with the ARIA checkbox pattern documented here: https://www.w3.org/WAI/ARIA/apg/patterns/checkbox/. - #8210: This one required a lot of changes in order to adapt to the ARIA combobox pattern documented here: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/. Specifically: - Menus needed to have a unique ID that's also exposed in order to link the combobox element to its menu when open. - ARIA's `activedescendant` proved very useful in ensuring that the current dropdown selection is correctly read when the combobox has focus but its menu isn't opened. - The default properties available for options (label and value) aren't very good for readout, so a custom ARIA property was added for much clearer option readouts. This is only demonstrated for the math arithmetic block for now. - The text element is normally hidden for ARIA but it's useful in conjunction with `activedescendant` to represent the current value selection. - Images have been handled here as well (partly as part of #8255) by leveraging their alt text for readouts. This actually seems to work quite well both for current value and selection. - #8213: Much of the improvements here come from the combobox (`FieldDropdown`) improvements explained above. However one additional bit was done to provide an explicit 'Variable <name>' readout for the purpose of clarity. This demonstrates some contextualization of the value of the field which may be a generally useful pattern to copy in other field contexts. - #8255: Image fields have been refined since they were redundantly specifying 'image' when an `image` ARIA role is already being used. Now only the alt text is supplied along with the role context. Note that images need special handling since they can sometimes be navigable (such as when they have click handlers). - #8211: Text input fields have had their labeling improved like all other fields, and the field's value is now exposed via its `text` element since this will show up as a `StaticText` node in the accessibility tree and automatically be read as part of the field's value. - #8212: This gets the same benefits as the previous point since those improvements were included for both text and number input. However, existing `valuemin` and `valuemax` ARIA properties have been removed. It seems these are really only useful when introducing a slider mechanism (see https://www.w3.org/WAI/ARIA/apg/patterns/slider/) and from testing seems to not really be utilized for the basic text input that `FieldNumber` currently uses. It may be the case that this is a better pattern to use in the future, but it's more likely that other custom fields could benefit from more specific patterns like slider rather than `FieldNumber` being changed in that way. - #8254 and part of #9304: Field labels have been completely removed from the accessibility node tree since they can never be navigated to (as #8254 explains all labels will be included as part of the block's ARIA label itself for readout parity with navigation options). Note that it doesn't cover external fields (such as those supplied in blockly-samples), nor does it fully set up the infrastructure work for those. Ultimately that work needs to happen as part of #9301. Beyond the role work above, this PR also introduces some fundamental work for #9301. Specifically: - It demonstrates how block definitions could be used to introduce accessibility label customizations (in this case for the options of the arithmetic operator block's drop-down field, plus the block itself). - It sets up some central label computation for all fields, though more thought is needed on whether this is sufficient for custom fields outside of core Blockly and on how to properly contextualize labels for field values. Core Blockly's fields are fairly simple for representing values which is why that aspect of #9301 didn't need to be solved in this PR. Note that the field labeling here is being used to improve all of the fields above, but also it tries to aggressively fall back to the _next best_ label to be used (though it's possible to run out of options which is why fields still need contextually-specific fallbacks). ### Reason for Changes Generally the initial approach for implementing labels is leveraging as specific ARIA roles as exist to directly represent the element. This PR is completing that work for all of core Blockly's built-in fields, and laying some of the groundwork for generalizing this support for custom fields. Having specific roles does potentially introduce inconsistencies across screen readers (though should improve consistency across sites for a single screen reader), and expectations for behaviors (like shortcuts) that may need to be ignored or only partially supported (#9313 is discussing this). ### Test Coverage Only manual testing has been completed since this is experimental work. Video demonstrating most of the changes: [Screen recording 2025-10-01 4.05.35 PM.webm](https://github.com/user-attachments/assets/c7961caa-eae0-4585-8fd9-87d7cbe65988) ### Documentation N/A -- Experimental work. ### Additional Information This has only been tested on ChromeVox.
226 lines
7.0 KiB
TypeScript
226 lines
7.0 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2019 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
// Former goog.module ID: Blockly.utils.aria
|
|
|
|
/** ARIA states/properties prefix. */
|
|
const ARIA_PREFIX = 'aria-';
|
|
|
|
/** ARIA role attribute. */
|
|
const ROLE_ATTRIBUTE = 'role';
|
|
|
|
/**
|
|
* ARIA role values.
|
|
* Copied from Closure's goog.a11y.aria.Role
|
|
*/
|
|
export enum Role {
|
|
// ARIA role for a group of related elements like tree item siblings.
|
|
GROUP = 'group',
|
|
|
|
// ARIA role for a listbox.
|
|
LISTBOX = 'listbox',
|
|
|
|
// ARIA role for a popup menu.
|
|
MENU = 'menu',
|
|
|
|
// ARIA role for menu item elements.
|
|
MENUITEM = 'menuitem',
|
|
// ARIA role for option items that are children of combobox, listbox, menu,
|
|
// radiogroup, or tree elements.
|
|
OPTION = 'option',
|
|
// ARIA role for ignorable cosmetic elements with no semantic significance.
|
|
PRESENTATION = 'presentation',
|
|
|
|
// ARIA role for a tree.
|
|
TREE = 'tree',
|
|
|
|
// ARIA role for a tree item that sometimes may be expanded or collapsed.
|
|
TREEITEM = 'treeitem',
|
|
|
|
// ARIA role for a visual separator in e.g. a menu.
|
|
SEPARATOR = 'separator',
|
|
|
|
// ARIA role for a live region providing information.
|
|
STATUS = 'status',
|
|
|
|
IMAGE = 'image',
|
|
FIGURE = 'figure',
|
|
BUTTON = 'button',
|
|
CHECKBOX = 'checkbox',
|
|
TEXTBOX = 'textbox',
|
|
COMBOBOX = 'combobox',
|
|
SPINBUTTON = 'spinbutton',
|
|
}
|
|
|
|
/**
|
|
* ARIA states and properties.
|
|
* Copied from Closure's goog.a11y.aria.State
|
|
*/
|
|
export enum State {
|
|
// ARIA property for setting the currently active descendant of an element,
|
|
// for example the selected item in a list box. Value: ID of an element.
|
|
ACTIVEDESCENDANT = 'activedescendant',
|
|
// ARIA state for a disabled item. Value: one of {true, false}.
|
|
DISABLED = 'disabled',
|
|
|
|
// ARIA state for setting whether the element like a tree node is expanded.
|
|
// Value: one of {true, false, undefined}.
|
|
EXPANDED = 'expanded',
|
|
|
|
// ARIA state indicating that the entered value does not conform. Value:
|
|
// one of {false, true, 'grammar', 'spelling'}
|
|
INVALID = 'invalid',
|
|
|
|
// ARIA property that provides a label to override any other text, value, or
|
|
// contents used to describe this element. Value: string.
|
|
LABEL = 'label',
|
|
// ARIA property for setting the element which labels another element.
|
|
// Value: space-separated IDs of elements.
|
|
LABELLEDBY = 'labelledby',
|
|
|
|
// ARIA property for setting the level of an element in the hierarchy.
|
|
// Value: integer.
|
|
LEVEL = 'level',
|
|
|
|
// ARIA property that defines an element's number of position in a list.
|
|
// Value: integer.
|
|
POSINSET = 'posinset',
|
|
|
|
// ARIA state for setting the currently selected item in the list.
|
|
// Value: one of {true, false, undefined}.
|
|
SELECTED = 'selected',
|
|
// ARIA property defining the number of items in a list. Value: integer.
|
|
SETSIZE = 'setsize',
|
|
|
|
// ARIA property for slider maximum value. Value: number.
|
|
VALUEMAX = 'valuemax',
|
|
|
|
// ARIA property for slider minimum value. Value: number.
|
|
VALUEMIN = 'valuemin',
|
|
|
|
VALUENOW = 'valuenow',
|
|
|
|
// ARIA property for live region chattiness.
|
|
// Value: one of {polite, assertive, off}.
|
|
LIVE = 'live',
|
|
|
|
// ARIA property for removing elements from the accessibility tree.
|
|
// Value: one of {true, false, undefined}.
|
|
HIDDEN = 'hidden',
|
|
|
|
ROLEDESCRIPTION = 'roledescription',
|
|
OWNS = 'owns',
|
|
HASPOPUP = 'haspopup',
|
|
CONTROLS = 'controls',
|
|
CHECKED = 'checked',
|
|
}
|
|
|
|
/**
|
|
* Updates the specific role for the specified element.
|
|
*
|
|
* @param element The element whose ARIA role should be changed.
|
|
* @param roleName The new role for the specified element, or null if its role
|
|
* should be cleared.
|
|
*/
|
|
export function setRole(element: Element, roleName: Role | null) {
|
|
if (roleName) {
|
|
element.setAttribute(ROLE_ATTRIBUTE, roleName);
|
|
} else element.removeAttribute(ROLE_ATTRIBUTE);
|
|
}
|
|
|
|
/**
|
|
* Returns the ARIA role of the specified element, or null if it either doesn't
|
|
* have a designated role or if that role is unknown.
|
|
*
|
|
* @param element The element from which to retrieve its ARIA role.
|
|
* @returns The ARIA role of the element, or null if undefined or unknown.
|
|
*/
|
|
export function getRole(element: Element): Role | null {
|
|
// This is an unsafe cast which is why it needs to be checked to ensure that
|
|
// it references a valid role.
|
|
const currentRoleName = element.getAttribute(ROLE_ATTRIBUTE) as Role;
|
|
if (Object.values(Role).includes(currentRoleName)) {
|
|
return currentRoleName;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Sets the specified ARIA state by its name and value for the specified
|
|
* element.
|
|
*
|
|
* Note that the type of value is not validated against the specific type of
|
|
* state being changed, so it's up to callers to ensure the correct value is
|
|
* used for the given state.
|
|
*
|
|
* @param element The element whose ARIA state may be changed.
|
|
* @param stateName The state to change.
|
|
* @param value The new value to specify for the provided state.
|
|
*/
|
|
export function setState(
|
|
element: Element,
|
|
stateName: State,
|
|
value: string | boolean | number | string[],
|
|
) {
|
|
if (Array.isArray(value)) {
|
|
value = value.join(' ');
|
|
}
|
|
const attrStateName = ARIA_PREFIX + stateName;
|
|
element.setAttribute(attrStateName, `${value}`);
|
|
}
|
|
|
|
/**
|
|
* Clears the specified ARIA state by removing any related attributes from the
|
|
* specified element that have been set using setState().
|
|
*
|
|
* @param element The element whose ARIA state may be changed.
|
|
* @param stateName The state to clear from the provided element.
|
|
*/
|
|
export function clearState(element: Element, stateName: State) {
|
|
element.removeAttribute(ARIA_PREFIX + stateName);
|
|
}
|
|
|
|
/**
|
|
* Returns a string representation of the specified state for the specified
|
|
* element, or null if it's not defined or specified.
|
|
*
|
|
* Note that an explicit set state of 'null' will return the 'null' string, not
|
|
* the value null.
|
|
*
|
|
* @param element The element whose state is being retrieved.
|
|
* @param stateName The state to retrieve.
|
|
* @returns The string representation of the requested state for the specified
|
|
* element, or null if not defined.
|
|
*/
|
|
export function getState(element: Element, stateName: State): string | null {
|
|
const attrStateName = ARIA_PREFIX + stateName;
|
|
return element.getAttribute(attrStateName);
|
|
}
|
|
|
|
/**
|
|
* Softly requests that the specified text be read to the user if a screen
|
|
* reader is currently active.
|
|
*
|
|
* This relies on a centrally managed ARIA live region that should not interrupt
|
|
* existing announcements (that is, this is what's considered a polite
|
|
* announcement).
|
|
*
|
|
* Callers should use this judiciously. It's often considered bad practice to
|
|
* over announce information that can be inferred from other sources on the
|
|
* page, so this ought to only be used when certain context cannot be easily
|
|
* determined (such as dynamic states that may not have perfect ARIA
|
|
* representations or indications).
|
|
*
|
|
* @param text The text to politely read to the user.
|
|
*/
|
|
export function announceDynamicAriaState(text: string) {
|
|
const ariaAnnouncementSpan = document.getElementById('blocklyAriaAnnounce');
|
|
if (!ariaAnnouncementSpan) {
|
|
throw new Error('Expected element with id blocklyAriaAnnounce to exist.');
|
|
}
|
|
ariaAnnouncementSpan.innerHTML = text;
|
|
}
|