mirror of
https://github.com/google/blockly.git
synced 2026-01-11 10:57:07 +01:00
PR #6244 made a change to have the npm run prepare script (automatically invoked by npm install after package installation) not bother running the buildJavaScriptAndDeps gulp task when run from a GitHub action (since our build action will do npm test straight afterwards, which runs this task already). Unfortunately, due my misunderstanding of how gulp tasks work the revised version generated a "Did you forget to signal async completion?" error from gulp. Fix this by adding a done parameter and passing the provided callback to buildJavaScriptAndDeps. This also allows a simplification of the the don't-run case by simply calling done and then returning.