Files
blockly/core/utils/toolbox.ts
T
Beka Westberg 29e1f0cb03 fix: tsc errors picked up from develop (#6224)
* fix: relative path for deprecation utils

* fix: checking if properties exist in svg_math

* fix: set all timeout PIDs to AnyDuringMigration

* fix: make nullability errors explicity in block drag surface

* fix: make null check in events_block_change explicit

* fix: make getEventWorkspace_ internal so we can access it from CommentCreateDeleteHelper

* fix: rename DIV -> containerDiv in tooltip

* fix: ignore backwards compat check in category

* fix: set block styles to AnyDuringMigration

* fix: type typo in KeyboardShortcut

* fix: constants name in row measurables

* fix: typecast in mutator

* fix: populateProcedures type of flattened array

* fix: ignore errors related to workspace comment deserialization

* chore: format files

* fix: renaming imports missing file extensions

* fix: remove check for sound.play

* fix: temporarily remove bad requireType.

All `export type` statements are stripped when tsc is run. This means
that when we attempt to require BlockDefinition from the block files, we
get an error because it does not exist.

We decided to temporarily remove the require, because this will no
longer be a problem when we conver the blocks to typescript, and
everything gets compiled together.

* fix: bad jsdoc in array

* fix: silence missing property errors

Closure was complaining about inexistant properties, but they actually
do exist, they're just not being transpiled by tsc in a way that closure
understands.

I.E. if things are initialized in a function called by the constructor,
rather than in a class field or in the custructor itself, closure would
error.

It would also error on enums, because they are transpiled to a weird
IIFE.

* fix: context menu action handler not knowing the type of this.

this: TypeX information gets stripped when tsc is run, so closure could
not know that this was not global. Fixed this by reorganizing to use the
option object directly instead of passing it to onAction to be bound to
this.

* fix: readd getDeveloperVars checks (should not be part of migration)

This was found because ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE was no
longer being accessed.

* fix: silence closure errors about overriding supertype props

We propertly define the overrides in typescript, but these get removed
from the compiled output, so closure doesn't know they exist.

* fix: silence globalThis errors

this: TypeX annotations get stripped from the compiled output, so
closure can't know that we're accessing the correct things. However,
typescript makes sure that this always has the correct properties, so
silencing this should be fine.

* fix: bad jsdoc name

* chore: attempt compiling with blockly.js

* fix: attempt moving the import statement above the namespace line

* chore: add todo comments to block def files

* chore: remove todo from context menu

* chore: add comments abotu disabled errors
2022-06-27 09:25:56 -07:00

424 lines
13 KiB
TypeScript

/**
* @license
* Copyright 2020 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
/**
* @fileoverview Utility functions for the toolbox and flyout.
*/
/**
* Utility functions for the toolbox and flyout.
* @namespace Blockly.utils.toolbox
*/
import * as goog from '../../closure/goog/goog.js';
goog.declareModuleId('Blockly.utils.toolbox');
/* eslint-disable-next-line no-unused-vars */
// Unused import preserved for side-effects. Remove if unneeded.
import '../toolbox/category.js';
/* eslint-disable-next-line no-unused-vars */
// Unused import preserved for side-effects. Remove if unneeded.
import '../toolbox/separator.js';
/* eslint-disable-next-line no-unused-vars */
import {ConnectionState} from '../serialization/blocks.js';
import {CssConfig as CategoryCssConfig} from '../toolbox/category.js';
import {CssConfig as SeparatorCssConfig} from '../toolbox/separator.js';
import * as Xml from '../xml.js';
import * as userAgent from './useragent.js';
/**
* The information needed to create a block in the toolbox.
* Note that disabled has a different type for backwards compatibility.
* @alias Blockly.utils.toolbox.BlockInfo
*/
export interface BlockInfo {
kind: string;
blockxml: string|Node|undefined;
type: string|undefined;
gap: string|number|undefined;
disabled: string|boolean|undefined;
enabled: boolean|undefined;
id: string|undefined;
x: number|undefined;
y: number|undefined;
collapsed: boolean|undefined;
inline: boolean|undefined;
data: string|undefined;
extraState: AnyDuringMigration|undefined;
icons: {[key: string]: AnyDuringMigration}|undefined;
fields: {[key: string]: AnyDuringMigration}|undefined;
inputs: {[key: string]: ConnectionState}|undefined;
next: ConnectionState|undefined;
}
/**
* The information needed to create a separator in the toolbox.
* @alias Blockly.utils.toolbox.SeparatorInfo
*/
export interface SeparatorInfo {
kind: string;
id: string|undefined;
gap: number|undefined;
cssconfig: SeparatorCssConfig|undefined;
}
/**
* The information needed to create a button in the toolbox.
* @alias Blockly.utils.toolbox.ButtonInfo
*/
export interface ButtonInfo {
kind: string;
text: string;
callbackkey: string;
}
/**
* The information needed to create a label in the toolbox.
* @alias Blockly.utils.toolbox.LabelInfo
*/
export interface LabelInfo {
kind: string;
text: string;
id: string|undefined;
}
/**
* The information needed to create either a button or a label in the flyout.
* @alias Blockly.utils.toolbox.ButtonOrLabelInfo
*/
export type ButtonOrLabelInfo = ButtonInfo|LabelInfo;
/**
* The information needed to create a category in the toolbox.
* @alias Blockly.utils.toolbox.StaticCategoryInfo
*/
export interface StaticCategoryInfo {
kind: string;
name: string;
contents: ToolboxItemInfo[];
id: string|undefined;
categorystyle: string|undefined;
colour: string|undefined;
cssconfig: CategoryCssConfig|undefined;
hidden: string|undefined;
}
/**
* The information needed to create a custom category.
* @alias Blockly.utils.toolbox.DynamicCategoryInfo
*/
export interface DynamicCategoryInfo {
kind: string;
custom: string;
id: string|undefined;
categorystyle: string|undefined;
colour: string|undefined;
cssconfig: CategoryCssConfig|undefined;
hidden: string|undefined;
}
/**
* The information needed to create either a dynamic or static category.
* @alias Blockly.utils.toolbox.CategoryInfo
*/
export type CategoryInfo = StaticCategoryInfo|DynamicCategoryInfo;
/**
* Any information that can be used to create an item in the toolbox.
* @alias Blockly.utils.toolbox.ToolboxItemInfo
*/
export type ToolboxItemInfo = FlyoutItemInfo|StaticCategoryInfo;
/**
* All the different types that can be displayed in a flyout.
* @alias Blockly.utils.toolbox.FlyoutItemInfo
*/
export type FlyoutItemInfo =
BlockInfo|SeparatorInfo|ButtonInfo|LabelInfo|DynamicCategoryInfo;
/**
* The JSON definition of a toolbox.
* @alias Blockly.utils.toolbox.ToolboxInfo
*/
export interface ToolboxInfo {
kind?: string;
contents: ToolboxItemInfo[];
}
/**
* An array holding flyout items.
* @alias Blockly.utils.toolbox.FlyoutItemInfoArray
*/
export type FlyoutItemInfoArray = FlyoutItemInfo[];
/**
* All of the different types that can create a toolbox.
* @alias Blockly.utils.toolbox.ToolboxDefinition
*/
export type ToolboxDefinition = Node|ToolboxInfo|string;
/**
* All of the different types that can be used to show items in a flyout.
* @alias Blockly.utils.toolbox.FlyoutDefinition
*/
export type FlyoutDefinition = FlyoutItemInfoArray|NodeList|ToolboxInfo|Node[];
/**
* The name used to identify a toolbox that has category like items.
* This only needs to be used if a toolbox wants to be treated like a category
* toolbox but does not actually contain any toolbox items with the kind
* 'category'.
*/
const CATEGORY_TOOLBOX_KIND = 'categoryToolbox';
/**
* The name used to identify a toolbox that has no categories and is displayed
* as a simple flyout displaying blocks, buttons, or labels.
*/
const FLYOUT_TOOLBOX_KIND = 'flyoutToolbox';
/**
* Position of the toolbox and/or flyout relative to the workspace.
* @alias Blockly.utils.toolbox.Position
*/
export enum Position {
TOP,
BOTTOM,
LEFT,
RIGHT
}
/**
* Converts the toolbox definition into toolbox JSON.
* @param toolboxDef The definition of the toolbox in one of its many forms.
* @return Object holding information for creating a toolbox.
* @alias Blockly.utils.toolbox.convertToolboxDefToJson
* @internal
*/
export function convertToolboxDefToJson(toolboxDef: ToolboxDefinition|
null): ToolboxInfo|null {
if (!toolboxDef) {
return null;
}
if (toolboxDef instanceof Element || typeof toolboxDef === 'string') {
toolboxDef = parseToolboxTree(toolboxDef);
// AnyDuringMigration because: Argument of type 'Node | null' is not
// assignable to parameter of type 'Node'.
toolboxDef = convertToToolboxJson(toolboxDef as AnyDuringMigration);
}
const toolboxJson = toolboxDef as ToolboxInfo;
validateToolbox(toolboxJson);
return toolboxJson;
}
/**
* Validates the toolbox JSON fields have been set correctly.
* @param toolboxJson Object holding information for creating a toolbox.
* @throws {Error} if the toolbox is not the correct format.
*/
function validateToolbox(toolboxJson: ToolboxInfo) {
const toolboxKind = toolboxJson['kind'];
const toolboxContents = toolboxJson['contents'];
if (toolboxKind) {
if (toolboxKind !== FLYOUT_TOOLBOX_KIND &&
toolboxKind !== CATEGORY_TOOLBOX_KIND) {
throw Error(
'Invalid toolbox kind ' + toolboxKind + '.' +
' Please supply either ' + FLYOUT_TOOLBOX_KIND + ' or ' +
CATEGORY_TOOLBOX_KIND);
}
}
if (!toolboxContents) {
throw Error('Toolbox must have a contents attribute.');
}
}
/**
* Converts the flyout definition into a list of flyout items.
* @param flyoutDef The definition of the flyout in one of its many forms.
* @return A list of flyout items.
* @alias Blockly.utils.toolbox.convertFlyoutDefToJsonArray
* @internal
*/
export function convertFlyoutDefToJsonArray(flyoutDef: FlyoutDefinition|
null): FlyoutItemInfoArray {
if (!flyoutDef) {
return [];
}
if ((flyoutDef as AnyDuringMigration)['contents']) {
return (flyoutDef as AnyDuringMigration)['contents'];
}
// If it is already in the correct format return the flyoutDef.
// AnyDuringMigration because: Property 'nodeType' does not exist on type
// 'Node | FlyoutItemInfo'.
if (Array.isArray(flyoutDef) && flyoutDef.length > 0 &&
!((flyoutDef[0]) as AnyDuringMigration).nodeType) {
// AnyDuringMigration because: Type 'FlyoutItemInfoArray | Node[]' is not
// assignable to type 'FlyoutItemInfoArray'.
return flyoutDef as AnyDuringMigration;
}
// AnyDuringMigration because: Type 'ToolboxItemInfo[] | FlyoutItemInfoArray'
// is not assignable to type 'FlyoutItemInfoArray'.
return xmlToJsonArray(flyoutDef as Node[] | NodeList) as AnyDuringMigration;
}
/**
* Whether or not the toolbox definition has categories.
* @param toolboxJson Object holding information for creating a toolbox.
* @return True if the toolbox has categories.
* @alias Blockly.utils.toolbox.hasCategories
* @internal
*/
export function hasCategories(toolboxJson: ToolboxInfo|null): boolean {
if (!toolboxJson) {
return false;
}
const toolboxKind = toolboxJson['kind'];
if (toolboxKind) {
return toolboxKind === CATEGORY_TOOLBOX_KIND;
}
const categories = toolboxJson['contents'].filter(function(item) {
return item['kind'].toUpperCase() === 'CATEGORY';
});
return !!categories.length;
}
/**
* Whether or not the category is collapsible.
* @param categoryInfo Object holing information for creating a category.
* @return True if the category has subcategories.
* @alias Blockly.utils.toolbox.isCategoryCollapsible
* @internal
*/
export function isCategoryCollapsible(categoryInfo: CategoryInfo): boolean {
if (!categoryInfo || !(categoryInfo as AnyDuringMigration)['contents']) {
return false;
}
const categories =
(categoryInfo as AnyDuringMigration)['contents'].filter(function(
item: AnyDuringMigration) {
return item['kind'].toUpperCase() === 'CATEGORY';
});
return !!categories.length;
}
/**
* Parses the provided toolbox definition into a consistent format.
* @param toolboxDef The definition of the toolbox in one of its many forms.
* @return Object holding information for creating a toolbox.
*/
function convertToToolboxJson(toolboxDef: Node): ToolboxInfo {
const contents = xmlToJsonArray(toolboxDef as Node | Node[]);
const toolboxJson = {'contents': contents};
if (toolboxDef instanceof Node) {
addAttributes(toolboxDef, toolboxJson);
}
return toolboxJson;
}
/**
* Converts the xml for a toolbox to JSON.
* @param toolboxDef The definition of the toolbox in one of its many forms.
* @return A list of objects in the toolbox.
*/
function xmlToJsonArray(toolboxDef: Node|Node[]|NodeList): FlyoutItemInfoArray|
ToolboxItemInfo[] {
const arr = [];
// If it is a node it will have children.
// AnyDuringMigration because: Property 'childNodes' does not exist on type
// 'Node | NodeList | Node[]'.
let childNodes = (toolboxDef as AnyDuringMigration).childNodes;
if (!childNodes) {
// Otherwise the toolboxDef is an array or collection.
childNodes = toolboxDef;
}
for (let i = 0, child; child = childNodes[i]; i++) {
if (!child.tagName) {
continue;
}
const obj = {};
const tagName = child.tagName.toUpperCase();
(obj as AnyDuringMigration)['kind'] = tagName;
// Store the XML for a block.
if (tagName === 'BLOCK') {
(obj as AnyDuringMigration)['blockxml'] = child;
} else if (child.childNodes && child.childNodes.length > 0) {
// Get the contents of a category
(obj as AnyDuringMigration)['contents'] = xmlToJsonArray(child);
}
// Add XML attributes to object
addAttributes(child, obj);
arr.push(obj);
}
// AnyDuringMigration because: Type '{}[]' is not assignable to type
// 'ToolboxItemInfo[] | FlyoutItemInfoArray'.
return arr as AnyDuringMigration;
}
/**
* Adds the attributes on the node to the given object.
* @param node The node to copy the attributes from.
* @param obj The object to copy the attributes to.
*/
function addAttributes(node: Node, obj: AnyDuringMigration) {
// AnyDuringMigration because: Property 'attributes' does not exist on type
// 'Node'.
for (let j = 0; j < (node as AnyDuringMigration).attributes.length; j++) {
// AnyDuringMigration because: Property 'attributes' does not exist on type
// 'Node'.
const attr = (node as AnyDuringMigration).attributes[j];
if (attr.nodeName.indexOf('css-') > -1) {
obj['cssconfig'] = obj['cssconfig'] || {};
obj['cssconfig'][attr.nodeName.replace('css-', '')] = attr.value;
} else {
obj[attr.nodeName] = attr.value;
}
}
}
/**
* Parse the provided toolbox tree into a consistent DOM format.
* @param toolboxDef DOM tree of blocks, or text representation of same.
* @return DOM tree of blocks, or null.
* @alias Blockly.utils.toolbox.parseToolboxTree
*/
export function parseToolboxTree(toolboxDef: Element|null|string): Element|
null {
if (toolboxDef) {
if (typeof toolboxDef !== 'string') {
if (userAgent.IE && toolboxDef.outerHTML) {
// In this case the tree will not have been properly built by the
// browser. The HTML will be contained in the element, but it will
// not have the proper DOM structure since the browser doesn't support
// XSLTProcessor (XML -> HTML).
toolboxDef = toolboxDef.outerHTML;
} else if (!(toolboxDef instanceof Element)) {
toolboxDef = null;
}
}
if (typeof toolboxDef === 'string') {
toolboxDef = Xml.textToDom(toolboxDef);
if (toolboxDef.nodeName.toLowerCase() !== 'xml') {
throw TypeError('Toolbox should be an <xml> document.');
}
}
} else {
toolboxDef = null;
}
return toolboxDef;
}