mirror of
https://github.com/google/blockly.git
synced 2026-01-13 11:57:10 +01:00
91632a4861
## The basics - [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change) ## The details ### Resolves Fixes https://github.com/google/blockly-keyboard-experimentation/issues/526 ### Proposed Changes This limits synchronizing in `LineCursor` from `FocusManager` to just nodes that have a corresponding block. ### Reason for Changes Limiting the synchronizing in this way ensures that navigation can't enter a bad state. The reason for why this is needed is explained in https://github.com/google/blockly-keyboard-experimentation/issues/526#issuecomment-2885117998. Longer term it would maybe be ideal to do one or both of the following: - Figure out ways of making navigation a bit more robust (perhaps on the keyboard navigation side) such that if cursor _is_ in a bad state there's some way to recover (rather than ending up permanently broken). - Remove `Marker`'s internal state in favor of always relying on `FocusManager`'s state to cover the cases where there can be automatic focus shifting. ### Test Coverage This was manually tested with the keyboard navigation plugin and verified to ensure that both https://github.com/google/blockly-keyboard-experimentation/issues/526 and https://github.com/google/blockly-keyboard-experimentation/issues/499 are (still) working as expected. Some basic testing was done with the core simple playground with the developer console open to ensure there weren't any expected failures. Automated testing cases would be better addressed as part of resolving #8915. ### Documentation No new documentation is needed here. ### Additional Information This behavior is expected to only affect the keyboard navigation plugin.