mirror of
https://github.com/google/blockly.git
synced 2026-01-05 08:00:09 +01:00
* docs: Make JSDoc @deprecated usage more consistent * refactor(VariableMap)!: Refresh toolbox when map modified Delete the following methods from WorkspaceSvg: - renameVariableById - deleteVariableById - createVariable Modify the following methods on VariableMap to call this.workspace.refreshToolboxSelection() if this.workspace is a WorkspaceSvg, replicating the behaviour of the aforementioned deleted methods and additionally ensuring that that method is called following any change to the variable map: - renameVariable - changeVariableType - renameVariableAndUses - createVariable - addVariable - deleteVariable BREAKING CHANGE: This change ensures that the toolbox will be refreshed regardless of what route the VaribleMap was updated, rather than only being refreshed when it is updated via calls to methods on WorkspaceSvg. Overall this is much more likely to fix a bug (where the toolbox wasn't being refreshed when it should have been) than cause one (by refreshing the toolbox when it shouldn't be), but this is still a behaviour change which could _conceivably_ result an unexpected regression. * refactor(VariableMap): Remove calls to deprecated getVariableUsesById Also refactor to use named imports core/variables.ts methods. * refactor(Workspace): Use named imports for core/variables.ts methods * refactor(FieldVariable): Remove call to deprecated getVariablesOfType * refactor(variables): Remove calls to deprecated methods * refactor(variables_dynamic): Remove call to deprecated getAllVariables * refactor(xml): Remove calls to deprecated createVariable * refactor(Events.VarCreate): Remove calls to deprecated methods * refactor(Events.VarDelete): Remove calls to deprecated methods * refactor(Events.VarRename): Remove calls to deprecated methods
125 lines
3.3 KiB
TypeScript
125 lines
3.3 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2018 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
// Former goog.module ID: Blockly.Events.VarDelete
|
|
|
|
import type {
|
|
IVariableModel,
|
|
IVariableState,
|
|
} from '../interfaces/i_variable_model.js';
|
|
import * as registry from '../registry.js';
|
|
|
|
import type {Workspace} from '../workspace.js';
|
|
import {VarBase, VarBaseJson} from './events_var_base.js';
|
|
import {EventType} from './type.js';
|
|
|
|
/**
|
|
* Notifies listeners that a variable model has been deleted.
|
|
*/
|
|
export class VarDelete extends VarBase {
|
|
override type = EventType.VAR_DELETE;
|
|
/** The type of the variable that was deleted. */
|
|
varType?: string;
|
|
/** The name of the variable that was deleted. */
|
|
varName?: string;
|
|
|
|
/**
|
|
* @param opt_variable The deleted variable. Undefined for a blank event.
|
|
*/
|
|
constructor(opt_variable?: IVariableModel<IVariableState>) {
|
|
super(opt_variable);
|
|
|
|
if (!opt_variable) {
|
|
return; // Blank event to be populated by fromJson.
|
|
}
|
|
this.varType = opt_variable.getType();
|
|
this.varName = opt_variable.getName();
|
|
}
|
|
|
|
/**
|
|
* Encode the event as JSON.
|
|
*
|
|
* @returns JSON representation.
|
|
*/
|
|
override toJson(): VarDeleteJson {
|
|
const json = super.toJson() as VarDeleteJson;
|
|
if (this.varType === undefined) {
|
|
throw new Error(
|
|
'The var type is undefined. Either pass a variable to ' +
|
|
'the constructor, or call fromJson',
|
|
);
|
|
}
|
|
if (!this.varName) {
|
|
throw new Error(
|
|
'The var name is undefined. Either pass a variable to ' +
|
|
'the constructor, or call fromJson',
|
|
);
|
|
}
|
|
json['varType'] = this.varType;
|
|
json['varName'] = this.varName;
|
|
return json;
|
|
}
|
|
|
|
/**
|
|
* Deserializes the JSON event.
|
|
*
|
|
* @param event The event to append new properties to. Should be a subclass
|
|
* of VarDelete, but we can't specify that due to the fact that parameters
|
|
* to static methods in subclasses must be supertypes of parameters to
|
|
* static methods in superclasses.
|
|
* @internal
|
|
*/
|
|
static fromJson(
|
|
json: VarDeleteJson,
|
|
workspace: Workspace,
|
|
event?: any,
|
|
): VarDelete {
|
|
const newEvent = super.fromJson(
|
|
json,
|
|
workspace,
|
|
event ?? new VarDelete(),
|
|
) as VarDelete;
|
|
newEvent.varType = json['varType'];
|
|
newEvent.varName = json['varName'];
|
|
return newEvent;
|
|
}
|
|
|
|
/**
|
|
* Run a variable deletion event.
|
|
*
|
|
* @param forward True if run forward, false if run backward (undo).
|
|
*/
|
|
override run(forward: boolean) {
|
|
const workspace = this.getEventWorkspace_();
|
|
if (!this.varId) {
|
|
throw new Error(
|
|
'The var ID is undefined. Either pass a variable to ' +
|
|
'the constructor, or call fromJson',
|
|
);
|
|
}
|
|
if (!this.varName) {
|
|
throw new Error(
|
|
'The var name is undefined. Either pass a variable to ' +
|
|
'the constructor, or call fromJson',
|
|
);
|
|
}
|
|
const variableMap = workspace.getVariableMap();
|
|
if (forward) {
|
|
const variable = variableMap.getVariableById(this.varId);
|
|
if (variable) variableMap.deleteVariable(variable);
|
|
} else {
|
|
variableMap.createVariable(this.varName, this.varType, this.varId);
|
|
}
|
|
}
|
|
}
|
|
|
|
export interface VarDeleteJson extends VarBaseJson {
|
|
varType: string;
|
|
varName: string;
|
|
}
|
|
|
|
registry.register(registry.Type.EVENT, EventType.VAR_DELETE, VarDelete);
|