mirror of
https://github.com/google/blockly.git
synced 2026-01-05 08:00:09 +01:00
6f20ac290d
* fix(build): Have buildShims clean up up after itself
We need to create a build/package.json file to allow node.js to
load build/src/core/blockly.js and the other chunk entry points
as ES modules (it forcibly assumes .js means CJS even if one is
trying to import, unless package.json says {"type": "module"}),
but this interferes with scripts/migration/js2ts doing a
require('build/deps.js'), which is _not_ an ES module.
Specific error message was:
/Users/cpcallen/src/blockly/scripts/migration/js2ts:56
require(path.resolve(__dirname, '../../build/deps.js'));
^
Error [ERR_REQUIRE_ESM]: require() of ES Module
/Users/cpcallen/src/blockly/build/deps.js from /Users/cpcallen/src/blockly/scripts/migration/js2ts
not supported.
deps.js is treated as an ES module file as it is a .js file whose
nearest parent package.json contains "type": "module" which
declares all .js files in that package scope as ES modules.
Instead rename deps.js to end in .cjs, change the requiring code
to use dynamic import() which is available in all CommonJS
modules, or change "type": "module" to "type": "commonjs" in
/Users/cpcallen/src/blockly/build/package.json to treat all .js
files as CommonJS (using .mjs for all ES modules instead).
at Object.<anonymous> (/Users/cpcallen/src/blockly/scripts/migration/js2ts:56:1) {
code: 'ERR_REQUIRE_ESM'
}
* chore(tests): Reorder to put interesting script nearer top of file
* chore(tests): Add missing imports of closure/goog/goog.js
These modules were depending on being loaded via the
debug module loader, which cannot be used without first loading
base.js as a script, and thereby defining goog.declareModuleId
as a side effect—but if they are to be loaded via direct import
statements then they need to actually import their own
dependencies.
This is a temporary measure as soon the goog.declareMouleId
calls can themselves be deleted.
* refactor(tests): Use import instead of bootstrap to load Blockly
* chores(build): Stop generating deps.mocha.js
This file was only needed by tests/mocha/index.html's use of
the debug module loader (via bootstrap.js), which has now been
removed.
* chore(tests): Remove unneeded goog.declareModuleId calls
These were only needed because these modules were previously
being loaded by goog.require and/or goog.bootstrap.
* chores(tests): Remove dead code
We are fully committed to proper modules now.
272 lines
7.4 KiB
JavaScript
272 lines
7.4 KiB
JavaScript
/**
|
|
* @license
|
|
* Copyright 2020 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import {
|
|
sharedTestSetup,
|
|
sharedTestTeardown,
|
|
} from './test_helpers/setup_teardown.js';
|
|
|
|
suite('WidgetDiv', function () {
|
|
setup(function () {
|
|
sharedTestSetup.call(this);
|
|
});
|
|
teardown(function () {
|
|
sharedTestTeardown.call(this);
|
|
});
|
|
|
|
suite('positionWithAnchor', function () {
|
|
function makeBBox(left, top, width, height) {
|
|
return {
|
|
left: left,
|
|
right: left + width,
|
|
top: top,
|
|
bottom: top + height,
|
|
width: width,
|
|
height: height,
|
|
};
|
|
}
|
|
|
|
setup(function () {
|
|
Blockly.WidgetDiv.createDom();
|
|
this.viewportBBox = makeBBox(0, 0, 1000, 1003);
|
|
this.widgetSize = {
|
|
width: 100,
|
|
height: 102,
|
|
};
|
|
this.anchorSize = {
|
|
width: 90,
|
|
height: 91,
|
|
};
|
|
|
|
this.testWidgetPosition = function (
|
|
anchorBBox,
|
|
rtl,
|
|
expectedX,
|
|
expectedY,
|
|
expectedHeight,
|
|
) {
|
|
Blockly.WidgetDiv.positionWithAnchor(
|
|
this.viewportBBox,
|
|
anchorBBox,
|
|
this.widgetSize,
|
|
rtl,
|
|
);
|
|
const style = Blockly.WidgetDiv.getDiv().style;
|
|
chai.assert.equal(style.left, expectedX + 'px', 'Left');
|
|
chai.assert.equal(style.top, expectedY + 'px', 'Top');
|
|
chai.assert.equal(style.height, expectedHeight + 'px', 'Height');
|
|
};
|
|
});
|
|
|
|
suite('LTR', function () {
|
|
test('noConflict', function () {
|
|
// Anchor placed in the middle.
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed just below at the left side of the
|
|
// anchor.
|
|
const expectedX = anchorBBox.left;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
false,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('topConflict', function () {
|
|
// Anchor close to the top.
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
50,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed just below the anchor.
|
|
const expectedX = anchorBBox.left;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
false,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('bottomConflict', function () {
|
|
// Anchor placed close to the bottom.
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
900,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed just above the anchor.
|
|
const expectedX = anchorBBox.left;
|
|
const expectedY = anchorBBox.top - this.widgetSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
false,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('leftConflict', function () {
|
|
// Anchor placed close to the left side.
|
|
const anchorBBox = makeBBox(
|
|
50,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed at the anchor.
|
|
const expectedX = anchorBBox.left;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
false,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('rightConflict', function () {
|
|
// Anchor placed close to the right side.
|
|
const anchorBBox = makeBBox(
|
|
950,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed as far right as possible--at the edge of
|
|
// the screen.
|
|
const expectedX = this.viewportBBox.width - this.widgetSize.width;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
false,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
});
|
|
suite('RTL', function () {
|
|
test('noConflict', function () {
|
|
// Anchor placed in the middle
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed at the right side of the anchor.
|
|
const expectedX = anchorBBox.right - this.widgetSize.width;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
true,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('topConflict', function () {
|
|
// Anchor close to the top.
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
50,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed just below the anchor.
|
|
const expectedX = anchorBBox.right - this.widgetSize.width;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
true,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('bottomConflict', function () {
|
|
// Anchor placed close to the bottom.
|
|
const anchorBBox = makeBBox(
|
|
500,
|
|
900,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed just above the anchor.
|
|
const expectedX = anchorBBox.right - this.widgetSize.width;
|
|
const expectedY = anchorBBox.top - this.widgetSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
true,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('leftConflict', function () {
|
|
// Anchor placed close to the left side.
|
|
const anchorBBox = makeBBox(
|
|
10,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed as far left as possible--at the edge of
|
|
// the screen.
|
|
const expectedX = 0;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
true,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
|
|
test('rightConflict', function () {
|
|
// Anchor placed close to the right side.
|
|
const anchorBBox = makeBBox(
|
|
950,
|
|
500,
|
|
this.anchorSize.width,
|
|
this.anchorSize.height,
|
|
);
|
|
// The widget div should be placed as far right as possible--at the edge of
|
|
// the screen.
|
|
const expectedX = this.viewportBBox.width - this.widgetSize.width;
|
|
const expectedY = anchorBBox.top + this.anchorSize.height;
|
|
this.testWidgetPosition(
|
|
anchorBBox,
|
|
true,
|
|
expectedX,
|
|
expectedY,
|
|
this.widgetSize.height,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
});
|