Files
blockly/core
Ben Henning e7af75e051 fix: Improve robustness of IFocusableNode uses (#9031)
## The basics

- [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change)

## The details
### Resolves

Fixes https://github.com/google/blockly-keyboard-experimentation/issues/515

### Proposed Changes

This adds `canBeFocused()` checks to all the places that could currently cause problems if a node were to return `false`.

### Reason for Changes

This can't introduce a problem in current Core and, in fact, most of these classes can never return `false` even through subclasses. However, this adds better robustness and fixes the underlying issue by ensuring that `getFocusableElement()` isn't called for a node that has indicated it cannot be focused.

### Test Coverage

I've manually tested this through the keyboard navigation plugin. However, there are clearly additional tests that would be nice to add both for the traverser and for `WorkspaceSvg`, both likely as part of resolving #8915.

### Documentation

No new documentation changes should be needed here.

### Additional Information

This is fixing theoretical issues in Core, but a real issue tracked by the keyboard navigation plugin repository.
2025-05-12 23:36:23 +00:00
..
2024-08-15 03:16:14 +01:00
2024-08-15 03:16:14 +01:00
2024-04-17 19:47:51 -07:00
2024-08-15 03:16:14 +01:00
2025-04-30 15:54:21 -07:00
2024-08-15 03:16:14 +01:00
2024-08-15 03:16:14 +01:00
2024-08-15 03:16:14 +01:00
2025-04-14 13:56:46 -07:00
2024-12-04 12:15:19 -08:00
2024-12-04 12:15:19 -08:00