mirror of
https://github.com/google/blockly.git
synced 2026-01-08 01:20:12 +01:00
* refactor(xml): Move textToDom to core/utils/xml.ts This function being in core/xml.ts was the cause for the last remaining circular import in core/ (between variables.ts and xml.ts). Moving it to utils/xml.ts makes sense anyway, since there is nothing Blockly-specific about this function. Fixes #6817. * fix(closure): Reenable goog.declareModuleId multiple-call check Reenable an assertion which check to make sure that goog.declareModuleId is not called more than once in a module (and which also catches circular imports amongst ES modules, which are not detected by closure-make-deps). * chore(tests,demos): Augo-migrate use of textToDom Testing the migration file entry by auto-migrating all uses of Blockly.Xml.textToDom to Blockly.utils.xml.textToDom. * chore(blocks): Manually migrate remaining use of textToDom Update the one remaining call to textToDom (in blocks/lists.ts) to the function's new location - also removing the last use of the Blockly.Xml / core/xml.ts) module from this file. * docs(xml): Remove unneeded @alias per comments on PR #6818 * fix(imports): Remove unused import
137 lines
4.4 KiB
JavaScript
137 lines
4.4 KiB
JavaScript
/**
|
|
* @license
|
|
* Copyright 2019 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
goog.declareModuleId('Blockly.test.comments');
|
|
|
|
import {assertEventFired} from './test_helpers/events.js';
|
|
import * as eventUtils from '../../build/src/core/events/utils.js';
|
|
import {sharedTestSetup, sharedTestTeardown} from './test_helpers/setup_teardown.js';
|
|
|
|
|
|
suite('Comments', function() {
|
|
setup(function() {
|
|
sharedTestSetup.call(this);
|
|
Blockly.defineBlocksWithJsonArray([
|
|
{
|
|
"type": "empty_block",
|
|
"message0": "",
|
|
"args0": [],
|
|
},
|
|
]);
|
|
this.workspace = Blockly.inject('blocklyDiv', {
|
|
comments: true,
|
|
scrollbars: true,
|
|
});
|
|
this.block = Blockly.Xml.domToBlock(Blockly.utils.xml.textToDom(
|
|
'<block type="empty_block"/>'
|
|
), this.workspace);
|
|
this.comment = new Blockly.Comment(this.block);
|
|
this.comment.computeIconLocation();
|
|
});
|
|
teardown(function() {
|
|
sharedTestTeardown.call(this);
|
|
});
|
|
suite('Visibility and Editability', function() {
|
|
setup(function() {
|
|
this.block.setCommentText('test text');
|
|
});
|
|
|
|
function assertEditable(comment) {
|
|
chai.assert.isNotOk(comment.paragraphElement_);
|
|
chai.assert.isOk(comment.textarea_);
|
|
chai.assert.equal(comment.textarea_.value, 'test text');
|
|
}
|
|
function assertNotEditable(comment) {
|
|
chai.assert.isNotOk(comment.textarea_);
|
|
chai.assert.isOk(comment.paragraphElement_);
|
|
chai.assert.equal(comment.paragraphElement_.firstChild.textContent,
|
|
'test text');
|
|
}
|
|
test('Editable', function() {
|
|
this.comment.setVisible(true);
|
|
chai.assert.isTrue(this.comment.isVisible());
|
|
assertEditable(this.comment);
|
|
assertEventFired(
|
|
this.eventsFireStub, Blockly.Events.BubbleOpen,
|
|
{bubbleType: 'comment', isOpen: true, type: eventUtils.BUBBLE_OPEN}, this.workspace.id,
|
|
this.block.id);
|
|
});
|
|
test('Not Editable', function() {
|
|
sinon.stub(this.block, 'isEditable').returns(false);
|
|
|
|
this.comment.setVisible(true);
|
|
|
|
chai.assert.isTrue(this.comment.isVisible());
|
|
assertNotEditable(this.comment);
|
|
assertEventFired(
|
|
this.eventsFireStub, Blockly.Events.BubbleOpen,
|
|
{bubbleType: 'comment', isOpen: true, type: eventUtils.BUBBLE_OPEN},
|
|
this.workspace.id, this.block.id);
|
|
});
|
|
test('Editable -> Not Editable', function() {
|
|
this.comment.setVisible(true);
|
|
sinon.stub(this.block, 'isEditable').returns(false);
|
|
|
|
this.comment.updateEditable();
|
|
|
|
chai.assert.isTrue(this.comment.isVisible());
|
|
assertNotEditable(this.comment);
|
|
assertEventFired(
|
|
this.eventsFireStub, Blockly.Events.BubbleOpen,
|
|
{bubbleType: 'comment', isOpen: true, type: eventUtils.BUBBLE_OPEN},
|
|
this.workspace.id, this.block.id);
|
|
});
|
|
test('Not Editable -> Editable', function() {
|
|
const editableStub = sinon.stub(this.block, 'isEditable').returns(false);
|
|
|
|
this.comment.setVisible(true);
|
|
|
|
editableStub.returns(true);
|
|
|
|
this.comment.updateEditable();
|
|
chai.assert.isTrue(this.comment.isVisible());
|
|
assertEditable(this.comment);
|
|
assertEventFired(
|
|
this.eventsFireStub, Blockly.Events.BubbleOpen,
|
|
{bubbleType: 'comment', isOpen: true, type: eventUtils.BUBBLE_OPEN},
|
|
this.workspace.id, this.block.id);
|
|
});
|
|
});
|
|
suite('Set/Get Bubble Size', function() {
|
|
teardown(function() {
|
|
sinon.restore();
|
|
});
|
|
function assertBubbleSize(comment, height, width) {
|
|
const size = comment.getBubbleSize();
|
|
chai.assert.equal(size.height, height);
|
|
chai.assert.equal(size.width, width);
|
|
}
|
|
function assertBubbleSizeDefault(comment) {
|
|
assertBubbleSize(comment, 80, 160);
|
|
}
|
|
test('Set Size While Visible', function() {
|
|
this.comment.setVisible(true);
|
|
const bubbleSizeSpy = sinon.spy(this.comment.bubble_, 'setBubbleSize');
|
|
|
|
assertBubbleSizeDefault(this.comment);
|
|
this.comment.setBubbleSize(100, 100);
|
|
assertBubbleSize(this.comment, 100, 100);
|
|
sinon.assert.calledOnce(bubbleSizeSpy);
|
|
|
|
this.comment.setVisible(false);
|
|
assertBubbleSize(this.comment, 100, 100);
|
|
});
|
|
test('Set Size While Invisible', function() {
|
|
assertBubbleSizeDefault(this.comment);
|
|
this.comment.setBubbleSize(100, 100);
|
|
assertBubbleSize(this.comment, 100, 100);
|
|
|
|
this.comment.setVisible(true);
|
|
assertBubbleSize(this.comment, 100, 100);
|
|
});
|
|
});
|
|
});
|