From d21c03d09c45356adf206153b633b35349aded75 Mon Sep 17 00:00:00 2001 From: "J.M. de Jong" Date: Sun, 6 Apr 2025 23:15:48 +0200 Subject: [PATCH] Remove broken `int` type check in WebRTC Signaling demo (#1186) JSON.parse_string() parses all numbers as floats, even if there are no decimals. `str(JSON.parse_string('{"type": 3}').asdf)` would result in `"3.0"`, which is not a valid int. Because of this, the demo is not working. --- networking/webrtc_signaling/client/ws_webrtc_client.gd | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/networking/webrtc_signaling/client/ws_webrtc_client.gd b/networking/webrtc_signaling/client/ws_webrtc_client.gd index c81ae6cf..4882f26f 100644 --- a/networking/webrtc_signaling/client/ws_webrtc_client.gd +++ b/networking/webrtc_signaling/client/ws_webrtc_client.gd @@ -64,11 +64,9 @@ func _parse_msg() -> bool: return false var msg := parsed as Dictionary - if not str(msg.type).is_valid_int() or not str(msg.id).is_valid_int(): - return false - var type := str(msg.type).to_int() - var src_id := str(msg.id).to_int() + var type := int(msg.type) + var src_id := int(msg.id) if type == Message.ID: connected.emit(src_id, msg.data == "true")