From 168dc2ad4872d2deadd71ac4d1e0ff9fb7b18239 Mon Sep 17 00:00:00 2001 From: Robin Dunn Date: Tue, 15 Oct 2019 09:50:04 -0700 Subject: [PATCH] Also include the vcredist DLLs for Python 3.8 --- build.py | 4 ++-- wscript | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build.py b/build.py index 60559b52..1009e079 100755 --- a/build.py +++ b/build.py @@ -1523,9 +1523,9 @@ def copyWxDlls(options): dlls += glob.glob(os.path.join(cairo_root, arch, 'bin', '*.dll')) # For Python 3.5 and 3.6 builds we also need to copy some VC14 redist DLLs. - # NOTE: Do it for 3.7 too for now. But when we fully switch over to VS 2017 + # NOTE: Do it for 3.7+ too for now. But when we fully switch over to VS 2017 # this may need to change. See notes in wscript about it. - if PYVER in ['3.5', '3.6', '3.7']: + if PYVER in ['3.5', '3.6', '3.7', '3.8']: redist_dir = os.path.join( phoenixDir(), 'packaging', 'Py3.5', 'vcredist', arch, 'Microsoft.VC140.CRT', '*.dll') diff --git a/wscript b/wscript index 7bc8d19e..983fcc83 100644 --- a/wscript +++ b/wscript @@ -84,7 +84,7 @@ def configure(conf): # On the other hand, microsoft says that v141 and v140 (Visual # Studio 2015) are binary compatible, so for now let's just drop # it back to "14.0" until I get all the details worked out for - # using VS 2017 everywhere for Python 3.7. + # using VS 2017 everywhere for Python 3.7+. msvc_version = '14.0' # In some cases (Azure DevOps at least) we're getting "14.1" for Python