From 3d3aaae5246a2efe56f49bd7ed4b7e06ff9523d8 Mon Sep 17 00:00:00 2001 From: Robin Dunn Date: Thu, 17 May 2012 02:49:13 +0000 Subject: [PATCH] Tweak some comments git-svn-id: https://svn.wxwidgets.org/svn/wx/wxPython/Phoenix/trunk@71461 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/string.sip | 23 ++++------------------- src/wxpybuffer.sip | 1 - 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/src/string.sip b/src/string.sip index 87588b23..bfea28c3 100644 --- a/src/string.sip +++ b/src/string.sip @@ -17,25 +17,10 @@ %MappedType wxString { - // TODO: Will something like this work (and be a good idea) in order to - // share the conversion code here and in the utlities module? - //%ConvertToTypeCode - // // Code to test a PyObject for compatibility with wxString - // if (!sipIsErr) { - // if (PyString_Check(sipPy) || PyUnicode_Check(sipPy)) - // return TRUE; - // return FALSE; - // } - // - // // Convert a compatible PyObject to a wxString - // wxString str = Py2wxString(sipPy, true, *sipIsErr); - // if (*sipIsErr) - // return 0; - // *sipCppPtr = new wxString(str); - // return sipGetState(sipTransferObj); - //%End - - + + // TODO: It is still possible to have a wx build that uses utf-8 inside + // wxString, so we should probably be checking wxUSE_UNICODE_WCHAR or + // wxUSE_UNICODE_UTF8 for this conversion. %ConvertToTypeCode // Code to test a PyObject for compatibility with wxString diff --git a/src/wxpybuffer.sip b/src/wxpybuffer.sip index 702ce1ca..d37df2f2 100644 --- a/src/wxpybuffer.sip +++ b/src/wxpybuffer.sip @@ -15,7 +15,6 @@ #include "wxpybuffer.h" %End -// TODO: Use new buffer APIs and memoryview or bytearray objects? %MappedType wxPyBuffer {