From a3b10d5d6393fc5e6c27fd2cdb8a1638626e7efa Mon Sep 17 00:00:00 2001 From: Scott Talbert Date: Sat, 20 Aug 2016 23:14:50 -0400 Subject: [PATCH] Fix crash in ribbonbar sample The ArtProvider shouldn't be cloned in this case because SetArtProvider() does not take ownership of the object in this case. Because of that, once the cloned provider goes out of scope and gets garbage collected, future uses will crash. Fixes #141. --- samples/ribbon/ribbonbar_demo.py | 1 - 1 file changed, 1 deletion(-) diff --git a/samples/ribbon/ribbonbar_demo.py b/samples/ribbon/ribbonbar_demo.py index b7d33f78..d4feb256 100644 --- a/samples/ribbon/ribbonbar_demo.py +++ b/samples/ribbon/ribbonbar_demo.py @@ -335,7 +335,6 @@ class RibbonFrame(wx.Frame): if event.GetGalleryItem() != None: if provider == self._ribbon.GetArtProvider(): - provider = provider.Clone() gallery.SetArtProvider(provider) provider.SetColour(RB.RIBBON_ART_GALLERY_HOVER_BACKGROUND_COLOUR,