From f679024027e84cafa4ef59da9e67cbdcca2e3f0d Mon Sep 17 00:00:00 2001 From: Robin Dunn Date: Sun, 28 Feb 2016 00:45:24 -0800 Subject: [PATCH] Use cp1252 encoding on Windows for cmd output --- buildtools/config.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/buildtools/config.py b/buildtools/config.py index ff947ea8..53c60d3c 100644 --- a/buildtools/config.py +++ b/buildtools/config.py @@ -787,9 +787,10 @@ def runcmd(cmd, getOutput=False, echoCmd=True, fatal=True): output = None if getOutput: + outputEncoding = 'cp1252' if sys.platform == 'win32' else 'utf-8' output = sp.stdout.read() if sys.version_info > (3,): - output = output.decode('utf-8', 'ignore') # TODO: is utf-8 okay here? + output = output.decode(outputEncoding) output = output.rstrip() rval = sp.wait()