Commit Graph

694 Commits

Author SHA1 Message Date
Robin Dunn
9627bb8035 Merge branch 'master' into update-wx 2021-12-13 21:40:18 -08:00
Robin Dunn
3d45e62b0e Merge pull request #2029 from swt2c/fix_unbind_outorder
Fix unbinding of events in FIFO order
2021-12-13 20:44:03 -08:00
Scott Talbert
b143cff821 Fix unbinding of events in FIFO order
When binding events to multiple methods and then unbinding them later,
in the same order they were bound, the wrong method would get unbound.

For example:
    self.btn.Bind(wx.EVT_BUTTON, self.onButton1)
    self.btn.Bind(wx.EVT_BUTTON, self.onButton1)
followed by:
    self.btn.Unbind(wx.EVT_BUTTON, handler=self.onButton2)
    self.btn.Unbind(wx.EVT_BUTTON, handler=self.onButton1)
works, but the reverse fails:
    self.btn.Unbind(wx.EVT_BUTTON, handler=self.onButton1)
    self.btn.Unbind(wx.EVT_BUTTON, handler=self.onButton2)

The reason is that the wxPython Disconnect() method called the wxWidgets
Disconnect() method with the userData parameter set to NULL.  In this
case, wxWidgets performs no filtering based on the userData parameter
and this could result in the wrong handler getting disconnected.

Fix this by setting the userData to a known value before calling
wxWidgets Disconnect() method so that it will disconnect the correct
handler.

This commit also adds a test that verifies the fix.

Fixes #2027.
2021-11-17 19:28:54 -05:00
Christian Clauss
25ba122168 Fix typos discovered by codespell 2021-08-07 18:55:49 +02:00
Robin Dunn
70535a722b remove wx.webkit 2021-07-24 15:59:37 -07:00
Robin Dunn
3d4155395b Add test cases for GenericDirCtrl.GetPath and GetPaths 2021-01-19 10:07:50 -08:00
Robin Dunn
c4f1e9f3bd Add missing context manager methods for wx.LogNull 2020-11-10 14:43:18 -08:00
Stefan Brüns
cf30fc3e17 Remove test for default-constructed wxPGWindowList, use Getters
The default constructor has been removed in wxWidgets 3.1.4, commit
https://github.com/wxWidgets/wxWidgets/commit/f2f9cbe61960
"(Get rid of unused wxPGWindowList ctor").

Now, at least the primary is required, the secondary is defaulted.

The members are no longer public in the interface.
2020-10-04 18:53:21 +02:00
Stefan Brüns
83e1470f25 Remove pagebreak array from HtmlDCRenderer::Render parameters
The Render call was changed in
https://github.com/wxWidgets/wxWidgets/commit/e01892c669748065
("Split and simplify wxHtmlDCRenderer::Render()")
2020-10-02 20:54:31 +02:00
Stefan Brüns
dab4757525 Remove tests for removed OS/2 list states, and invalid hittest case
These states were OS/2 specific and have been removed:
https://github.com/wxWidgets/wxWidgets/commit/01f9accd19755fdc
("Remove wxPM, wxWidgets port to OS/2.")

ONITEMRIGHT is only meaningfull for trees, and was removed from the
interface:
https://github.com/wxWidgets/wxWidgets/commit/6c9b3a825407b362
("Improved wxListCtrl::HitTest() docs")
2020-10-02 20:42:54 +02:00
Stefan Brüns
6d59201c00 Remove instatiation test of accidentially exposed values
The values are just internal constants and were only exposed by accident,
reverted by https://github.com/wxWidgets/wxWidgets/commit/9e5dd5091402a7f4
("Revert some changes from incorrect merge that discarded formatting, etc.")
2020-10-02 19:56:42 +02:00
Stefan Brüns
36686a8c75 Pass data as bytes in UIActionSimulator::Test
The Test parameter no longer is a wxString but a const char*, as the
method only handles plain ASCII.
2020-10-02 17:56:53 +02:00
Stefan Brüns
62cda454f1 Do not specify invalid alignment in BoxSizer flags
Specyfing a horizontal alignment in a wxHORIZONTAL layed out BoxSizer
is pointless, and doing so throws an exception:

wx._core.wxAssertionError: C++ assertion "!(flags & wxALIGN_RIGHT)"
failed at ./src/common/sizer.cpp(2133) in DoInsert():
Horizontal alignment flags are ignored in horizontal sizers
2020-10-02 17:56:43 +02:00
Stefan Brüns
9baba68cff Remove constructor test for no longer existant AuiPanelButton
The helper class was removed in wxWidgets 3.1.4, commit
https://github.com/wxWidgets/wxWidgets/commit/5663157674c31ea0
("Fix link between flags and buttons in wxAuiManager").
2020-10-02 15:23:26 +02:00
Stefan Brüns
0168c425ec Do not try to manually create a wx.PaintEvent
Since wxWidgets 3.1.4, manually creating a wxPaintEvent is no longer
possible, also see commit 3761507882 ("wxObjectDataPtr, wxGridCell*Ptr,
and other changes needed for updated wxWidgets").
2020-10-01 01:52:34 +02:00
Stefan Brüns
7015096786 Fix tests, current wxWidgets uses rounding for wxPoint from real
Since wxWigets 3.1.2, several wxPoint/wxRealPoint/wxSize operations
no longer truncate results and do correct rounding. Reflect this in
the expected results.
2020-07-30 02:52:29 +02:00
Stefan Brüns
6cd96a3d71 Fix test, remove check for TB_3DBUTTONS toolbar style
The style has been removed for wxWidgets 3.1.0, see
https://github.com/wxWidgets/wxWidgets/pull/137
2020-07-30 02:52:29 +02:00
Stefan Brüns
4d2beb5be5 Fix SearchCtrl test by removing checks for TextCtrl methods
Since commit 9eb9497afc ("The new native wxSearchCtrl on GTK does not
include the wxTextCtrl methods, just those from wxTextEntry.") the
methods are no longer part of the SearchCtrl.
2020-07-30 02:52:29 +02:00
Stefan Brüns
ae237e7c45 Fix STC.StartStyling call in unittests
See https://github.com/wxWidgets/Phoenix/pull/1643
Fixes https://github.com/wxWidgets/Phoenix/issues/1748
2020-07-30 02:52:24 +02:00
Robin Dunn
ff6311cc06 Revert an incorrect part of the last change 2020-04-22 13:20:53 -07:00
Robin Dunn
c55a4450b6 Ensure sip sees that there is an implementation of DisplayEditorDialog in classes derived from wxEditorDialogProperty 2020-04-22 13:17:33 -07:00
Robin Dunn
e1b0435f8e Added wrappers for the wx.grid.GridBlockCoords, wx.grid.GridBlocks, and wx.grid.GridBlockDiffResult classes 2020-04-17 16:35:37 -07:00
Robin Dunn
7a05d20d82 Merge pull request #1572 from pbrod/Fix_issue1571
Fixes issue 1571:
2020-03-23 16:07:22 -07:00
Robin Dunn
41c5af9cde Merge pull request #1569 from pbrod/Fix_issue1554
Fixes issue # 1554:
2020-03-23 15:35:41 -07:00
Per A. Brodtkorb
e4e8bf8317 Fixes issue 1571:
Adding missing close for open.
If the "close()" call is missing after a "open(filename)" call, the filename isn't guaranteed to be closed before the interpreter exits.
This is generally a bad practice as explained here: https://stackoverflow.com/questions/7395542/is-explicitly-closing-files-important

Also replaced "fid=open(filename) fid.close()" statements for files with the safer
"with open(filename) as fid:" blocks. See https://www.python.org/dev/peps/pep-0343/
2020-03-23 17:16:44 +01:00
Per A. Brodtkorb
fc1823315b Fixes issue # 1554:
Replaced "== None" and "!= None" with "is None" and "is not None", respectively, because the former is slower and error-prone.
2020-03-23 11:53:36 +01:00
Robin Dunn
8e2627e8e3 Merge pull request #1564 from pbrod/Fix_issue1556
Fixes issue #1556
2020-03-20 15:19:40 -07:00
Robin Dunn
1eafa7e77d Merge pull request #1559 from pbrod/Fix_test_propgridprops2
Fixes issue #1549: test_propgridprops12 fails on windows
2020-03-20 14:49:10 -07:00
Per A. Brodtkorb
033c18fd9f Fixes issue #1556
Replaced XXX.keys() calls with idiomatic python 3 calls that are compatible with python 2 such as eg:
 * replaced "y = xxx.keys()" or "y = list(xxx.keys())" with just "y = list(xxx)"
 * replaced "sorted(xxx.keys())" or "sorted(list(xxx.keys()))" with just "sorted(xxx)"
 * replaced "if not A in B.keys():" with "if A not in B:"
 * replaced "for A in B.keys():"  with "for A in B:"

See also https://python-future.org/compatible_idioms.html
https://python-future.org/compatible_idioms.html#dict-keys-values-items-as-a-list
2020-03-20 18:51:19 +01:00
Per A. Brodtkorb
2830ccf783 Fixes issue #1549: test_propgridprops12 fails on windows 2020-03-20 12:40:36 +01:00
Robin Dunn
adf1a1522c Skip the pyi unittests for now.
It seems that ensuring that they are valid executable Python is not as important as it was in the past.
2020-03-17 17:48:36 -07:00
Robin Dunn
4444d63c1f Add missing clipboard event type and binder 2020-03-17 15:57:10 -07:00
Robin Dunn
e16401abc4 Use UTI strings for custom data format names.
It seems to be required on macOS now.
2020-03-05 09:52:24 -08:00
Robin Dunn
9096426603 Add __index__ to wx.WindowID, and __bool__ to wx.Region 2020-02-26 11:10:27 -08:00
Robin Dunn
42dd0c6e12 Add wx.NotebookPage alias 2019-12-31 13:46:50 -08:00
jensgoe
8c3f231b0c added unittests for setters
(cherry picked from commit 216b9a824b)
2019-12-18 18:15:16 -08:00
Robin Dunn
49cceecbdf Added wrappers for the wx.CollapsibleHeaderCtrl class 2019-10-30 13:03:51 -07:00
Robin Dunn
e972814cd3 Add wx.ActivityIndicator 2019-10-29 15:23:08 -07:00
Robin Dunn
56e53107a7 Show and Destroy the test dialogs on Macs, yield after update, and more test fixes
(cherry picked from commit 7f2e86a72c)
2019-10-23 18:57:39 -07:00
Robin Dunn
a757f15cab Test fixes 2019-10-17 14:08:13 -07:00
Robin Dunn
8395898ea5 Merge branch 'improve-hypertreelist' of https://github.com/ThomasP0815/Phoenix into ThomasP0815-improve-hypertreelist 2019-10-07 13:35:23 -07:00
Robin Dunn
fea9c980f8 Remove use of some constants that no longer exist in 4.1 2019-09-12 13:13:34 -07:00
Pappenreiter.Thomas
fbe0951950 Feature: Colouring columns in hypertreelist 2019-08-28 14:26:32 +02:00
ricpol
6088d873f8 fixes and tests for CDate.py 2019-05-25 18:53:04 +02:00
ricpol
a8bf4a5113 some new test for wx.lib.calendar 2019-05-25 17:14:07 +02:00
Robin Dunn
0378328d45 Merge pull request #1201 from RobinD42/fix-issue1198
Fix access to members of transient wx.VisualAttributes

(cherry picked from commit d6324a0578)
2019-04-13 16:25:55 -07:00
Robin Dunn
beac13c0bb Merge pull request #1131 from swt2c/fix_access_test
Xfail unimplemented access test instead of failing it
(cherry picked from commit 92fc4afa9d)
2019-01-15 16:02:37 -08:00
Robin Dunn
fde6792936 Merge pull request #1127 from swt2c/fix_vlbox_test
Fix vlbox test on Python 3
(cherry picked from commit 8c9b379bc4)
2019-01-15 16:01:59 -08:00
jensgoe
714a9a222d ignore newline added by Tokenize module since Python 3.6 (fixes #1109) 2018-12-12 16:00:46 +01:00
Robin Dunn
1f735769a1 Merge pull request #1082 from Metallicow/Fix-Image-Issues
Fix image issues
2018-11-30 14:52:26 -08:00