5174 Commits

Author	SHA1	Message	Date
Lunny Xiao	5340db4dbe	Fix bug when updating user email (#36058) ... Fix #20390 We should use `ReplacePrimaryEmailAddress` instead of `AdminAddOrSetPrimaryEmailAddress` when modify user's email from admin panel. And also we need a database transaction to keep deletion and insertion succeed at the same time.	2025-12-01 23:50:10 +00:00
Bryan Mutai	7d6861ac54	Add "Go to file", "Delete Directory" to repo file list page (#35911) ... /claim #35898 Resolves #35898 ### Summary of key changes: 1. Add file name search/Go to file functionality to repo button row. 2. Add backend functionality to delete directory 3. Add context menu for directories with functionality to copy path & delete a directory 4. Move Add/Upload file dropdown to right for parity with Github UI 5. Add tree view to the edit/upload UI --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-11-30 11:58:15 +08:00
bytedream	ede7f1a069	Fix incorrect viewed files counter if file has changed (#36009) ... File changes since last review didn't decrease the viewed files counter --- <img width="440" height="178" alt="image" src="https://github.com/user-attachments/assets/da34fcf4-452f-4f71-8da2-97edbfc31fdd" /> Also reported here -> https://github.com/go-gitea/gitea/issues/35803#issuecomment-3567850285 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2025-11-27 14:02:03 +00:00
wxiaoguang	000c06d41b	Fix oauth2 session gob register (#36017) ... `gob.Register` must be called before Sessioner Fix #36016	2025-11-26 23:25:34 +08:00
wxiaoguang	abe2755f7a	Fix container registry error handling (#36021) ... 1. the `if` check in `handleCreateManifestResult` didn't handler err correctly 2. add more error details for debugging	2025-11-25 12:13:30 +08:00
Andrew Melnick	688430e3ce	Allow admins to rename non-local users (#35970) ... Presently, attempting to rename a non-local (e.g. Oauth2 or LDAP) user results in an error, even if the requester is an administrator. As far as I can tell, this is a security feature, not architectural in nature, as automatic account linking could be used to take control of another user's account. This is not a concern for an administrator, who we should trust to know what they are doing. This patch allows admins, and only admins, to rename non-local users. Fixes https://github.com/go-gitea/gitea/issues/18308 (sort of) --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-11-23 20:59:55 +00:00
Lunny Xiao	62d750eadb	Fix various permission & login related bugs (#36002) ... Permission & protection check: - Fix Delete Release permission check - Fix Update Pull Request with rebase branch protection check - Fix Issue Dependency permission check - Fix Delete Comment History ID check Information leaking: - Show unified message for non-existing user and invalid password - Fix #35984 - Don't expose release draft to non-writer users. - Make API returns signature's email address instead of the user profile's. Auth & Login: - Avoid GCM OAuth2 attempt when OAuth2 is disabled - Fix #35510 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-11-22 07:16:08 +00:00
wxiaoguang	e1372e5bc1	Make composer registry support tar.gz and tar.bz2 and fix bugs (#35958) ... Fix #35957	2025-11-18 23:15:50 +00:00
wxiaoguang	0fb3be7f0e	Fix diff blob excerpt expansion (#35922) ... And add comments and tests	2025-11-14 04:50:48 +00:00
wxiaoguang	358de23a50	Fix container push tag overwriting (#35936) ... Fix #35853	2025-11-14 03:49:57 +00:00
wxiaoguang	1f3558b65c	Fix corrupted external render content (#35946) ... Fix #35944	2025-11-14 08:31:11 +08:00
wxiaoguang	b95fd7e13e	Don't show unnecessary error message to end users for DeleteBranchAfterMerge (#35937)	2025-11-13 07:03:13 +08:00
wxiaoguang	372d24b84b	Limit reading bytes instead of ReadAll (#35928)	2025-11-12 19:44:49 +08:00
lifegpc	1c8c56503f	Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (#35882) ... Releated issue: https://github.com/go-gitea/gitea/issues/30487 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-11-09 21:31:25 -08:00
Mithilesh Gupta	60314cb688	Add proper page title for project pages (#35773) ... Fix #35763 Co-authored-by: Mithilesh Gupta <guptamithilesh@protonmail.com>	2025-11-09 21:54:34 +00:00
Alberty Pascal	c4c4cf5687	Use correct form field for allowed force push users in branch protection API (#35894) ... Test was wrong and preventing update of force push allow users list by the API Resolves #35893 Signed-off-by: Alberty Pascal <github@albertyorban.be>	2025-11-09 21:23:46 +00:00
wxiaoguang	050c9485df	Fix team member access check (#35899) ... Fix #35499	2025-11-09 03:13:31 +00:00
Luohao Wang	bfaddbcd0d	Fix conda null depend issue (#35900) ... Fix #35895	2025-11-08 23:29:17 +08:00
Divyun Raje Vaid	61e5cc173e	fix(api/repo/contents): set the dates to now when not specified by the caller (#35861) ... Since 1.25.0, the dates get set to `2001-01-01T00:00:00Z`, when not specified by the caller. Fixes #35860 Co-authored-by: Giteabot <teabot@gitea.io>	2025-11-05 18:52:24 +00:00
wxiaoguang	525265c1a8	Refactor ls-tree and git path related problems (#35858) ... Fix #35852, the root problem is that the "name" field is heavily abused (since #6816, and no way to get a clear fix) There are still a lot of legacy problems in old code. Co-authored-by: Giteabot <teabot@gitea.io>	2025-11-05 17:48:38 +00:00
Lunny Xiao	de26c8acce	Fix viewed files number is not right if not all files loaded (#35821) ... Fix #35803 --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io>	2025-11-03 13:34:52 -08:00
Lunny Xiao	b148bef471	Remove unnecessary function parameter (#35765)	2025-10-31 21:56:08 -07:00
Zettat123	3ab8ae5807	Fix actions rerun bug (#35783) ... Related issues: #35780, #35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: #34970	2025-10-30 01:08:59 +00:00
bytedream	39c08ce4c1	Update tab title when navigating file tree (#35757) ... Fix #35749. --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2025-10-29 13:38:09 +00:00
Lunny Xiao	95b18eb781	Remove unnecessary code and fix comments (#35761) ... Follow #35459, #32562 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-28 18:03:57 +00:00
wxiaoguang	6b5563c54a	Support selecting theme on the footer (#35741) ... Fixes: https://github.com/go-gitea/gitea/pull/27576	2025-10-28 18:25:00 +08:00
wxiaoguang	2f309b844c	Revert #18491, fix oauth2 client link account (#35745) ... Fix #35744 by reverting #18491 * "OpenID" options don't mean "OAuth2Client" options * "OAuth2(server)" options don't mean "OAuth2Client" options	2025-10-26 21:26:38 +00:00
Zettat123	c9beb0b01f	Support actions and reusable workflows from private repos (#32562) ... Resolve https://gitea.com/gitea/act_runner/issues/102 This PR allows administrators of a private repository to specify some collaborative owners. The repositories of collaborative owners will be allowed to access this repository's actions and workflows. Settings for private repos:  --- This PR also moves "Enable Actions" setting to `Actions > General` page <img width="960" alt="image" src="https://github.com/user-attachments/assets/49337ec2-afb1-4a67-8516-5c9ef0ce05d4" /> <img width="960" alt="image" src="https://github.com/user-attachments/assets/f58ee6d5-17f9-4180-8760-a78e859f1c37" /> --------- Signed-off-by: Zettat123 <zettat123@gmail.com> Co-authored-by: ChristopherHX <christopher.homberger@web.de>	2025-10-25 17:37:33 +00:00
Lunny Xiao	5454fdacd4	Use git model to detect whether branch exist instead of gitrepo method (#35459)	2025-10-25 10:08:25 -07:00
Zettat123	0d740a6a72	Improve online runner check (#35722) ... This PR moves "no online runner" warning to the runs list. A job's `runs-on` may contain expressions like `runs-on: [self-hosted, "${{ inputs.chosen-os }}"]` so the value of `runs-on` may be different in each run. We cannot check it through the workflow file. <details> <summary>Screenshots</summary> Before: <img width="960" alt="3d2a91746271d8b1f12c8f7d20eba550" src="https://github.com/user-attachments/assets/7a972c50-db97-49d2-b12b-c1a439732a11" /> After: <img width="960" alt="image" src="https://github.com/user-attachments/assets/fc076e0e-bd08-4afe-99b9-c0eb0fd2c7e7" /> </details> This PR also splits `prepareWorkflowDispatchTemplate` function into 2 functions: - `prepareWorkflowTemplate` get and check all of the workflows - `prepareWorkflowDispatchTemplate` only prepare workflow dispatch config for `workflow_dispatch` workflows. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-24 12:02:52 -07:00
wxiaoguang	9a73a1fb83	Make "update file" API can create a new file when SHA is not set (#35738) ... Fix #19008, use GitHub's behavior (empty SHA to create a new file)	2025-10-24 12:46:54 +08:00
wxiaoguang	522c466e24	Make external iframe render work (#35730) ... Fix #35729, #17635, #21098	2025-10-23 08:01:38 +00:00
wxiaoguang	195fc715ff	Fix external render (#35727) ... Fix #35725 --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-22 23:41:38 +00:00
ChristopherHX	08b9776970	Refactor Actions Token Access (#35688) ... * use a single function to do Action Tokens Permission checks * allows easier customization * add basic tests * lfs file locks should work now --------- Signed-off-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-22 11:12:31 +00:00
Kemal Zebari	a9f2ea720b	Honor delete branch on merge repo setting when using merge API (#35488) ... Fix #35463. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-22 05:06:56 +00:00
a1012112796	a4e23b81d3	fix attachment file size limit in server backend (#35519) ... fix #35512 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-21 15:07:11 +00:00
wxiaoguang	b2ee5be52e	Refactor legacy code (#35708) ... And by the way, remove the legacy TODO, split large functions into small ones, and add more tests	2025-10-20 11:43:08 -07:00
Zettat123	897e48dde3	Add quick approve button on PR page (#35678) ... This PR adds a quick approve button on PR page to allow reviewers to approve all pending checks. Only users with write permission to the Actions unit can approve. --------- Signed-off-by: Zettat123 <zettat123@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-20 18:46:37 +08:00
Bryan Mutai	c30d74d0f9	feat(diff): Enable commenting on expanded lines in PR diffs (#35662) ... Fixes #32257 /claim #32257 Implemented commenting on unchanged lines in Pull Request diffs, lines are accessed by expanding the diff preview. Comments also appear in the "Files Changed" tab on the unchanged lines where they were placed. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-19 18:19:12 +08:00
wxiaoguang	2d36a0c9ff	Fix various bugs (#35684) ... 1. Fix incorrect column in `applySubscribedCondition`, add a test 2. Fix debian version parsing, add more tests fix #35695 3. Fix log level for HTTP errors, fix #35651 4. Fix abused "panic" handler in API `Migrate` 5. Fix the redirection from PR to issue, add a test 6. Fix Actions variable & secret name validation, add more tests * envNameCIRegexMatch is unnecessary, removed * validating in "delete" function doesn't make sense, removed 7. Fix incorrect link in release email --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2025-10-19 00:37:50 +08:00
ChristopherHX	322cb048e7	Fix workflow run event status while rerunning a failed job (#35689) ... The event reported a completion status instead of requested, therefore sent an email	2025-10-18 03:31:34 +00:00
Lunny Xiao	a7eceb57a9	Use gitrepo.Repository instead of wikipath (#35398) ... Now the wikipath will not be referenced directly.	2025-10-17 20:00:44 -07:00
Surya Purohit	bf8ecf7c93	Use LFS object size instead of blob size when viewing a LFS file (#35679) ... shows the main LFS filesize instead of the pointer filesize when viewing a file --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-16 17:42:54 +08:00
Lunny Xiao	16fc3323b9	Fix a bug missed return (#35655)	2025-10-14 20:12:07 -07:00
silverwind	49a0a11f55	Update JS deps, misc tweaks (#35643) ... - Update all JS dependencies - Enable eslint `no-useless-assignment` and fix 2 discovered issues - Replace `gitea-vscode` svg with new `octicon-vscode` - Remove now-unused `@ts-expect-error` comments - Change Monaco wrapping behaviour to match the wrapping in code view: no wrapping indent and break on any character.	2025-10-12 21:07:15 +00:00
ChristopherHX	2401812b76	Cleanup ActionRun creation (#35624) ... Closes #35622 --------- Signed-off-by: ChristopherHX <christopher.homberger@web.de> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-12 12:23:37 +00:00
鲁汀	b029ad431b	Fix code tag style problem and LFS view bug (#35628) ... Fix #35567 --------- Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-12 02:38:42 +08:00
Zettat123	40f71bcd4c	Support Actions concurrency syntax (#32751) ... Fix #24769 Fix #32662 Fix #33260 Depends on https://gitea.com/gitea/act/pulls/124 - https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#concurrency ## ⚠️ BREAKING ⚠️ This PR removes the auto-cancellation feature added by #25716. Users need to manually add `concurrency` to workflows to control concurrent workflows or jobs. --------- Signed-off-by: Zettat123 <zettat123@gmail.com> Co-authored-by: Christopher Homberger <christopher.homberger@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-10 18:58:55 +00:00
Surya Purohit	b8e5e2a93e	Fix diffpatch API endpoint (#35610) ... Fix the swagger documentation for the `diffpatch` API endpoint, and fix the wrong API path caused by a refactoring change. Closes #35602 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-10 00:39:14 +08:00
Lunny Xiao	69f5ee970c	Move some functions to gitrepo package (#35543) ... Refactor Git command functions to use WithXXX methods instead of exposing RunOpts. This change simplifies reuse across gitrepo and improves consistency, encapsulation, and maintainability of command options. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-10-07 17:06:51 +08:00