From 3b0a4386a8309d0c3485daab2e988f34003c4ee7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Sat, 12 Oct 2024 23:00:27 +0200 Subject: [PATCH] gsk: gsk_border_node_new(): Fix dead cleanup code The `gdk_color_finish()` calls are currently after the `return`, so they are never executed. Move the `return` below the cleanup code to avoid that. Fixes: bd3d1f7715c6f0 ("gsk: Add private border node api") --- gsk/gskrendernodeimpl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gsk/gskrendernodeimpl.c b/gsk/gskrendernodeimpl.c index ba13b4ff2e..59f413ddc6 100644 --- a/gsk/gskrendernodeimpl.c +++ b/gsk/gskrendernodeimpl.c @@ -2586,15 +2586,18 @@ gsk_border_node_new (const GskRoundedRect *outline, const float border_width[4], const GdkRGBA border_color[4]) { + GskRenderNode *node; GdkColor color[4]; for (int i = 0; i < 4; i++) gdk_color_init_from_rgba (&color[i], &border_color[i]); - return gsk_border_node_new2 (outline, border_width, color); + node = gsk_border_node_new2 (outline, border_width, color); for (int i = 0; i < 4; i++) gdk_color_finish (&color[i]); + + return node; } /*< private >