From 087eed88f304ef8e9aaf842ee393c98e9d8fb241 Mon Sep 17 00:00:00 2001 From: Elliot Lee Date: Thu, 13 Jan 2000 21:17:40 +0000 Subject: [PATCH] Add note about gtk_tooltips_set_colors(). 2000-01-13 Elliot Lee * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). --- ChangeLog | 3 +++ ChangeLog.pre-2-0 | 3 +++ ChangeLog.pre-2-10 | 3 +++ ChangeLog.pre-2-2 | 3 +++ ChangeLog.pre-2-4 | 3 +++ ChangeLog.pre-2-6 | 3 +++ ChangeLog.pre-2-8 | 3 +++ gtk/gtktooltips.c | 13 +++++++++++++ 8 files changed, 34 insertions(+) diff --git a/ChangeLog b/ChangeLog index 706704e136..af88af8922 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 706704e136..af88af8922 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,6 @@ +2000-01-13 Elliot Lee + * gtk/gtktooltips.c: Add note about gtk_tooltips_set_colors(). + 2000-01-07 Jesus Bravo Alvarez * configure.in (ALL_LINGUAS): Oops, Galician (gl) wasn't there yet diff --git a/gtk/gtktooltips.c b/gtk/gtktooltips.c index d5e5a6a68b..e685d79bdf 100644 --- a/gtk/gtktooltips.c +++ b/gtk/gtktooltips.c @@ -391,6 +391,19 @@ gtk_tooltips_set_tip (GtkTooltips *tooltips, } } +/* +Elliot Lee writes: + +> Not only are the if() conditions backwards, but it is using the pointers +> as passed in instead of copying the values. + +This has been reported a lot of times. The thing is, this +tooltips->foreground/background aren't used at all; the +colors are taken from the style now. So it doesn't matter. + +Regards, + Owen + */ void gtk_tooltips_set_colors (GtkTooltips *tooltips, GdkColor *background,