From 1b6dbf0ea2923f344983429dc67780fd53f98add Mon Sep 17 00:00:00 2001 From: Owen Taylor Date: Wed, 2 Aug 2000 19:07:00 +0000 Subject: [PATCH] Move is_viewable() test further inside the function, since removing the Wed Aug 2 14:57:38 2000 Owen Taylor * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move is_viewable() test further inside the function, since removing the window from the redraw list without clearing ->update_area was also very broken. --- ChangeLog | 7 +++++++ ChangeLog.pre-2-0 | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ ChangeLog.pre-2-2 | 7 +++++++ ChangeLog.pre-2-4 | 7 +++++++ ChangeLog.pre-2-6 | 7 +++++++ ChangeLog.pre-2-8 | 7 +++++++ gdk/gdkwindow.c | 5 +---- 8 files changed, 50 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index dc4697d1c7..1c946cd112 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +Wed Aug 2 14:57:38 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Move + is_viewable() test further inside the function, since removing the + window from the redraw list without clearing ->update_area + was also very broken. + 2000-08-02 Tor Lillqvist * configure.in: Check for . diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c index d019b7c206..bad3113e63 100644 --- a/gdk/gdkwindow.c +++ b/gdk/gdkwindow.c @@ -1416,9 +1416,6 @@ gdk_window_process_updates_internal (GdkWindow *window) GdkWindowObject *private = (GdkWindowObject *)window; gboolean save_region = FALSE; - if (!gdk_window_is_viewable (window)) - return; - /* If an update got queued during update processing, we can get a * window in the update queue that has an empty update_area. * just ignore it. @@ -1428,7 +1425,7 @@ gdk_window_process_updates_internal (GdkWindow *window) GdkRegion *update_area = private->update_area; private->update_area = NULL; - if (gdk_event_func) + if (gdk_event_func && gdk_window_is_viewable (window)) { GdkEvent event; GdkRectangle window_rect;