From 235de57cd801199488d2701646cafd6201a1658b Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Fri, 18 Sep 2020 11:34:14 +0200 Subject: [PATCH] gl: Properly report error if shader linking fails In gsk_gl_shader_builder_create_program(), if linking fails we need to return -1 to indicate error, rather than the old deleted program id. --- gsk/gl/gskglshaderbuilder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gsk/gl/gskglshaderbuilder.c b/gsk/gl/gskglshaderbuilder.c index a133527784..66f0a3843e 100644 --- a/gsk/gl/gskglshaderbuilder.c +++ b/gsk/gl/gskglshaderbuilder.c @@ -188,6 +188,7 @@ gsk_gl_shader_builder_create_program (GskGLShaderBuilder *self, g_free (buffer); glDeleteProgram (program_id); + program_id = -1; goto out; }