From 251bf45cf24c9635e75f376776d2f2253dcc740e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= <mail@baedert.org>
Date: Sat, 10 Aug 2019 19:36:56 +0200
Subject: [PATCH] iconcache: ref textures

We can't just assume that the pointer we'se using as a cache key will
stay unique forever. The texture might be freed, and a later allocated
texture might have the same addres now, causing the cache to return
incorrect results.
---
 gsk/gl/gskgliconcache.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gsk/gl/gskgliconcache.c b/gsk/gl/gskgliconcache.c
index bb66e8dfaf..4030bf7fbe 100644
--- a/gsk/gl/gskgliconcache.c
+++ b/gsk/gl/gskgliconcache.c
@@ -13,11 +13,13 @@ typedef struct
   GskGLTextureAtlas *atlas;
   int frame_age; /* Number of frames this icon is unused */
   guint used: 1;
+  GdkTexture *source_texture;
 } IconData;
 
 static void
 icon_data_free (gpointer p)
 {
+  g_object_unref (((IconData *)p)->source_texture);
   g_free (p);
 }
 
@@ -182,6 +184,7 @@ gsk_gl_icon_cache_lookup_or_add (GskGLIconCache  *self,
     icon_data->atlas = atlas;
     icon_data->frame_age = 0;
     icon_data->used = TRUE;
+    icon_data->source_texture = g_object_ref (texture);
     graphene_rect_init (&icon_data->texture_rect,
                         (float)(packed_x + 1) / atlas->width,
                         (float)(packed_y + 1) / atlas->height,