From 29c4d0a3ee410bb6fc2338fa326adf4065db3d78 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Wed, 18 Oct 2017 15:35:19 +0200 Subject: [PATCH] GtkGestureZoom: Don't leak the list of sequences https://bugzilla.gnome.org/show_bug.cgi?id=789149 --- gtk/gtkgesturezoom.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gtk/gtkgesturezoom.c b/gtk/gtkgesturezoom.c index 8b61b3594e..f16fcee379 100644 --- a/gtk/gtkgesturezoom.c +++ b/gtk/gtkgesturezoom.c @@ -79,17 +79,18 @@ _gtk_gesture_zoom_get_distance (GtkGestureZoom *zoom, const GdkEvent *last_event; gdouble x1, y1, x2, y2; GtkGesture *gesture; - GList *sequences; + GList *sequences = NULL; gdouble dx, dy; + gboolean retval = FALSE; gesture = GTK_GESTURE (zoom); if (!gtk_gesture_is_recognized (gesture)) - return FALSE; + goto out; sequences = gtk_gesture_get_sequences (gesture); if (!sequences) - return FALSE; + goto out; last_event = gtk_gesture_get_last_event (gesture, sequences->data); @@ -104,18 +105,21 @@ _gtk_gesture_zoom_get_distance (GtkGestureZoom *zoom, else { if (!sequences->next) - return FALSE; + goto out; gtk_gesture_get_point (gesture, sequences->data, &x1, &y1); gtk_gesture_get_point (gesture, sequences->next->data, &x2, &y2); - g_list_free (sequences); dx = x1 - x2; dy = y1 - y2;; *distance = sqrt ((dx * dx) + (dy * dy)); } - return TRUE; + retval = TRUE; + + out: + g_list_free (sequences); + return retval; } static gboolean