From 3724592efb87567691d47e6f02a7cfb2dc014a3d Mon Sep 17 00:00:00 2001 From: Christian Hergert Date: Mon, 20 Jun 2016 15:17:00 -0700 Subject: [PATCH] listbox: short-circuit if no sort function is set do_sort will crash if sort_func is not defined. Instead of adding a check there in the hot path, just check for sort_func before invalidating the sort of the underlying GSequence. --- gtk/gtklistbox.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtklistbox.c b/gtk/gtklistbox.c index 91c08e361e..17f19072ec 100644 --- a/gtk/gtklistbox.c +++ b/gtk/gtklistbox.c @@ -1280,6 +1280,9 @@ gtk_list_box_invalidate_sort (GtkListBox *box) g_return_if_fail (GTK_IS_LIST_BOX (box)); + if (priv->sort_func == NULL) + return; + g_sequence_sort (priv->children, (GCompareDataFunc)do_sort, box); g_sequence_foreach (priv->children, gtk_list_box_css_node_foreach, &previous);