From 3ea8cfc02fcd4015ad5e364d0dcd47f1eede89fd Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Wed, 29 Jun 2011 17:34:50 +0200 Subject: [PATCH] tests: Add assert to accessibility-dump Check that number of selected children == number of children that actually are selected. If that's not the case, assert, to avoid people being careless about adding tests. --- tests/a11y/accessibility-dump.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tests/a11y/accessibility-dump.c b/tests/a11y/accessibility-dump.c index eb92424050..f6737ec4b4 100644 --- a/tests/a11y/accessibility-dump.c +++ b/tests/a11y/accessibility-dump.c @@ -390,22 +390,28 @@ dump_atk_selection (AtkSelection *atk_selection, guint depth, GString *string) { + guint n_selections, n_counted_selections; gint i; + n_selections = atk_selection_get_selection_count (atk_selection); g_string_append_printf (string, "%*s\n", depth, ""); + g_string_append_printf (string, "%*sselection count: %d\n", depth, "", n_selections); - g_string_append_printf (string, "%*sselection count: %d\n", depth, "", atk_selection_get_selection_count (atk_selection)); - - if (atk_selection_get_selection_count (atk_selection) > 0) + n_counted_selections = 0; + for (i = 0; i < atk_object_get_n_accessible_children (ATK_OBJECT (atk_selection)); i++) { - g_string_append_printf (string, "%*sselected children:", depth, ""); - for (i = 0; i < atk_object_get_n_accessible_children (ATK_OBJECT (atk_selection)); i++) + if (atk_selection_is_child_selected (atk_selection, i)) { - if (atk_selection_is_child_selected (atk_selection, i)) - g_string_append_printf (string, " %d", i); + if (n_counted_selections == 0) + g_string_append_printf (string, "%*sselected children:", depth, ""); + g_string_append_printf (string, " %d", i); + n_counted_selections++; } - g_string_append_c (string, '\n'); } + if (n_counted_selections) + g_string_append_c (string, '\n'); + + g_assert_cmpint (n_selections, ==, n_counted_selections); } static void