From 41045df10dec7dfa964caa527e0f6fde0233dd49 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 22 Jul 2004 02:48:00 +0000 Subject: [PATCH] Don't leak the list store. (#148134, Crispin Flowerday) * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the list store. (#148134, Crispin Flowerday) --- ChangeLog | 7 ++++++- ChangeLog.pre-2-10 | 7 ++++++- ChangeLog.pre-2-6 | 7 ++++++- ChangeLog.pre-2-8 | 7 ++++++- gtk/gtkcombobox.c | 2 +- 5 files changed, 25 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7c3a3c62f6..72b6653a3a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,11 @@ +Wed Jul 21 22:47:28 2004 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the + list store. (#148134, Crispin Flowerday) + Wed Jul 21 22:35:47 2004 Matthias Clasen - * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the + * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the menu. (#148110, Tommi Komulainen) Wed Jul 21 22:24:10 2004 Matthias Clasen diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 7c3a3c62f6..72b6653a3a 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,6 +1,11 @@ +Wed Jul 21 22:47:28 2004 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the + list store. (#148134, Crispin Flowerday) + Wed Jul 21 22:35:47 2004 Matthias Clasen - * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the + * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the menu. (#148110, Tommi Komulainen) Wed Jul 21 22:24:10 2004 Matthias Clasen diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 7c3a3c62f6..72b6653a3a 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,6 +1,11 @@ +Wed Jul 21 22:47:28 2004 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the + list store. (#148134, Crispin Flowerday) + Wed Jul 21 22:35:47 2004 Matthias Clasen - * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the + * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the menu. (#148110, Tommi Komulainen) Wed Jul 21 22:24:10 2004 Matthias Clasen diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 7c3a3c62f6..72b6653a3a 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,6 +1,11 @@ +Wed Jul 21 22:47:28 2004 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the + list store. (#148134, Crispin Flowerday) + Wed Jul 21 22:35:47 2004 Matthias Clasen - * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the + * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the menu. (#148110, Tommi Komulainen) Wed Jul 21 22:24:10 2004 Matthias Clasen diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c index aee4935429..5cdefe64ce 100644 --- a/gtk/gtkcombobox.c +++ b/gtk/gtkcombobox.c @@ -3328,8 +3328,8 @@ gtk_combo_box_new_text (void) GtkListStore *store; store = gtk_list_store_new (1, G_TYPE_STRING); - combo_box = gtk_combo_box_new_with_model (GTK_TREE_MODEL (store)); + g_object_unref (store); cell = gtk_cell_renderer_text_new (); gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (combo_box), cell, TRUE);